Merge pull request #1148 from bundyo/fix-window-open-options

Fix window.open options parsing

atom/renderer/lib/override.coffee

@@ -26,21 +26,25 @@ unless process.guestInstanceId?
 # Make the browser window or guest view emit "new-window" event.
 window.open = (url, frameName='', features='') ->
   options = {}
-  for feature in features.split ','
+  ints = [ 'x', 'y', 'width', 'height', 'min-width', 'max-width', 'min-height', 'max-height', 'zoom-factor' ]
-    [name, value] = feature.split '='
+  # Make sure to get rid of excessive whitespace in the property name
+  for feature in features.split /,\s*/
+    [name, value] = feature.split /\s*=/
     options[name] =
-      if value is 'yes'
+      if value is 'yes' or value is '1'
         true
-      else if value is 'no'
+      else if value is 'no' or value is '0'
         false
       else
         value
-  options.x ?= options.left
+  options.x ?= options.left if options.left
-  options.y ?= options.top
+  options.y ?= options.top if options.top
   options.title ?= name
   options.width ?= 800
   options.height ?= 600
 
+  (options[name] = parseInt(options[name], 10) if options[name]?) for name in ints
+
   guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options
   if guestId
     new FakeWindow(guestId)