From 43e44f8c350776fdec4936a02fcf5d0193abac3b Mon Sep 17 00:00:00 2001
From: Bundyo <bundyo@gmail.com>
Date: Wed, 18 Feb 2015 14:36:05 +0200
Subject: [PATCH] Fix window.open options parsing: remove excessive whitespace
 (gets inserted in property names), avoid creating dummy properties if not
 needed, turn 1/0 to true/false, convert integer strings to strings (fixes
 width/height).

---
 atom/renderer/lib/override.coffee | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/atom/renderer/lib/override.coffee b/atom/renderer/lib/override.coffee
index 43ae271fb1d0..c61cce889040 100644
--- a/atom/renderer/lib/override.coffee
+++ b/atom/renderer/lib/override.coffee
@@ -26,21 +26,25 @@ unless process.guestInstanceId?
 # Make the browser window or guest view emit "new-window" event.
 window.open = (url, frameName='', features='') ->
   options = {}
-  for feature in features.split ','
-    [name, value] = feature.split '='
+  ints = [ 'x', 'y', 'width', 'height', 'min-width', 'max-width', 'min-height', 'max-height', 'zoom-factor' ]
+  # Make sure to get rid of excessive whitespace in the property name
+  for feature in features.split /,\s*/
+    [name, value] = feature.split /\s*=/
     options[name] =
-      if value is 'yes'
+      if value is 'yes' or value is '1'
         true
-      else if value is 'no'
+      else if value is 'no' or value is '0'
         false
       else
         value
-  options.x ?= options.left
-  options.y ?= options.top
+  options.x ?= options.left if options.left
+  options.y ?= options.top if options.top
   options.title ?= name
   options.width ?= 800
   options.height ?= 600
 
+  (options[name] = parseInt(options[name], 10) if options[name]?) for name in ints
+
   guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options
   if guestId
     new FakeWindow(guestId)