mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: pass gfx::ResizeEdge by value (#46962)

Browse source 
refactor: pass gfx::ResizeEdge by value

It is an enum class, so no reason to pass by reference

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-05-06 14:37:34 -05:00 • committed by GitHub
parent fdc322c93f
commit 695448e142
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_base_window.cc
View file

@ -254,7 +254,7 @@ void BaseWindow::OnWindowRestore() {
} }
void BaseWindow::OnWindowWillResize(const gfx::Rect& new_bounds, void BaseWindow::OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge, const gfx::ResizeEdge edge,
bool* prevent_default) { bool* prevent_default) {
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate(); v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
v8::HandleScope handle_scope(isolate); v8::HandleScope handle_scope(isolate);

2
shell/browser/api/electron_api_base_window.h
View file

@ -71,7 +71,7 @@ class BaseWindow : public gin_helper::TrackableObject<BaseWindow>,
void OnWindowMinimize() override; void OnWindowMinimize() override;
void OnWindowRestore() override; void OnWindowRestore() override;
void OnWindowWillResize(const gfx::Rect& new_bounds, void OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge, gfx::ResizeEdge edge,
bool* prevent_default) override; bool* prevent_default) override;
void OnWindowResize() override; void OnWindowResize() override;
void OnWindowResized() override; void OnWindowResized() override;

2
shell/browser/native_window.cc
View file

@ -587,7 +587,7 @@ void NativeWindow::NotifyWindowRestore() {
} }
void NativeWindow::NotifyWindowWillResize(const gfx::Rect& new_bounds, void NativeWindow::NotifyWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge, const gfx::ResizeEdge edge,
bool* prevent_default) { bool* prevent_default) {
observers_.Notify(&NativeWindowObserver::OnWindowWillResize, new_bounds, edge, observers_.Notify(&NativeWindowObserver::OnWindowWillResize, new_bounds, edge,
prevent_default); prevent_default);

2
shell/browser/native_window.h
View file

@ -317,7 +317,7 @@ class NativeWindow : public base::SupportsUserData,
void NotifyWindowRestore(); void NotifyWindowRestore();
void NotifyWindowMove(); void NotifyWindowMove();
void NotifyWindowWillResize(const gfx::Rect& new_bounds, void NotifyWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge, gfx::ResizeEdge edge,
bool* prevent_default); bool* prevent_default);
void NotifyWindowResize(); void NotifyWindowResize();
void NotifyWindowResized(); void NotifyWindowResized();

2
shell/browser/native_window_observer.h
View file

@ -78,7 +78,7 @@ class NativeWindowObserver : public base::CheckedObserver {
virtual void OnWindowMinimize() {} virtual void OnWindowMinimize() {}
virtual void OnWindowRestore() {} virtual void OnWindowRestore() {}
virtual void OnWindowWillResize(const gfx::Rect& new_bounds, virtual void OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge, gfx::ResizeEdge edge,
bool* prevent_default) {} bool* prevent_default) {}
virtual void OnWindowResize() {} virtual void OnWindowResize() {}
virtual void OnWindowResized() {} virtual void OnWindowResized() {}

2
shell/common/gin_converters/gfx_converter.cc
View file

@ -197,7 +197,7 @@ v8::Local<v8::Value> Converter<display::Display>::ToV8(
v8::Local<v8::Value> Converter<gfx::ResizeEdge>::ToV8( v8::Local<v8::Value> Converter<gfx::ResizeEdge>::ToV8(
v8::Isolate* isolate, v8::Isolate* isolate,
const gfx::ResizeEdge& val) { const gfx::ResizeEdge val) {
switch (val) { switch (val) {
case gfx::ResizeEdge::kRight: case gfx::ResizeEdge::kRight:
return StringToV8(isolate, "right"); return StringToV8(isolate, "right");

2
shell/common/gin_converters/gfx_converter.h
View file

@ -77,7 +77,7 @@ struct Converter<display::Display> {
template <> template <>
struct Converter<gfx::ResizeEdge> { struct Converter<gfx::ResizeEdge> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const gfx::ResizeEdge& val); const gfx::ResizeEdge val);
}; };
template <> template <>