From 695448e14249e73b501b1a0f42d68f8c87d101f5 Mon Sep 17 00:00:00 2001
From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com>
Date: Tue, 6 May 2025 14:37:34 -0500
Subject: [PATCH] refactor: pass `gfx::ResizeEdge` by value (#46962)

refactor: pass gfx::ResizeEdge by value

It is an enum class, so no reason to pass by reference

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---
 shell/browser/api/electron_api_base_window.cc | 2 +-
 shell/browser/api/electron_api_base_window.h  | 2 +-
 shell/browser/native_window.cc                | 2 +-
 shell/browser/native_window.h                 | 2 +-
 shell/browser/native_window_observer.h        | 2 +-
 shell/common/gin_converters/gfx_converter.cc  | 2 +-
 shell/common/gin_converters/gfx_converter.h   | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/shell/browser/api/electron_api_base_window.cc b/shell/browser/api/electron_api_base_window.cc
index 506350baa80e..4140db9e0b63 100644
--- a/shell/browser/api/electron_api_base_window.cc
+++ b/shell/browser/api/electron_api_base_window.cc
@@ -254,7 +254,7 @@ void BaseWindow::OnWindowRestore() {
 }
 
 void BaseWindow::OnWindowWillResize(const gfx::Rect& new_bounds,
-                                    const gfx::ResizeEdge& edge,
+                                    const gfx::ResizeEdge edge,
                                     bool* prevent_default) {
   v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
   v8::HandleScope handle_scope(isolate);
diff --git a/shell/browser/api/electron_api_base_window.h b/shell/browser/api/electron_api_base_window.h
index 68619364a8fb..0a44c592781e 100644
--- a/shell/browser/api/electron_api_base_window.h
+++ b/shell/browser/api/electron_api_base_window.h
@@ -71,7 +71,7 @@ class BaseWindow : public gin_helper::TrackableObject<BaseWindow>,
   void OnWindowMinimize() override;
   void OnWindowRestore() override;
   void OnWindowWillResize(const gfx::Rect& new_bounds,
-                          const gfx::ResizeEdge& edge,
+                          gfx::ResizeEdge edge,
                           bool* prevent_default) override;
   void OnWindowResize() override;
   void OnWindowResized() override;
diff --git a/shell/browser/native_window.cc b/shell/browser/native_window.cc
index 658c11950b4c..9fa01c2fdc09 100644
--- a/shell/browser/native_window.cc
+++ b/shell/browser/native_window.cc
@@ -587,7 +587,7 @@ void NativeWindow::NotifyWindowRestore() {
 }
 
 void NativeWindow::NotifyWindowWillResize(const gfx::Rect& new_bounds,
-                                          const gfx::ResizeEdge& edge,
+                                          const gfx::ResizeEdge edge,
                                           bool* prevent_default) {
   observers_.Notify(&NativeWindowObserver::OnWindowWillResize, new_bounds, edge,
                     prevent_default);
diff --git a/shell/browser/native_window.h b/shell/browser/native_window.h
index a88d17a6d8dd..8c4618073a02 100644
--- a/shell/browser/native_window.h
+++ b/shell/browser/native_window.h
@@ -317,7 +317,7 @@ class NativeWindow : public base::SupportsUserData,
   void NotifyWindowRestore();
   void NotifyWindowMove();
   void NotifyWindowWillResize(const gfx::Rect& new_bounds,
-                              const gfx::ResizeEdge& edge,
+                              gfx::ResizeEdge edge,
                               bool* prevent_default);
   void NotifyWindowResize();
   void NotifyWindowResized();
diff --git a/shell/browser/native_window_observer.h b/shell/browser/native_window_observer.h
index 22efa174aedd..1adf24d47404 100644
--- a/shell/browser/native_window_observer.h
+++ b/shell/browser/native_window_observer.h
@@ -78,7 +78,7 @@ class NativeWindowObserver : public base::CheckedObserver {
   virtual void OnWindowMinimize() {}
   virtual void OnWindowRestore() {}
   virtual void OnWindowWillResize(const gfx::Rect& new_bounds,
-                                  const gfx::ResizeEdge& edge,
+                                  gfx::ResizeEdge edge,
                                   bool* prevent_default) {}
   virtual void OnWindowResize() {}
   virtual void OnWindowResized() {}
diff --git a/shell/common/gin_converters/gfx_converter.cc b/shell/common/gin_converters/gfx_converter.cc
index c6c75da3f137..c54ec7062eab 100644
--- a/shell/common/gin_converters/gfx_converter.cc
+++ b/shell/common/gin_converters/gfx_converter.cc
@@ -197,7 +197,7 @@ v8::Local<v8::Value> Converter<display::Display>::ToV8(
 
 v8::Local<v8::Value> Converter<gfx::ResizeEdge>::ToV8(
     v8::Isolate* isolate,
-    const gfx::ResizeEdge& val) {
+    const gfx::ResizeEdge val) {
   switch (val) {
     case gfx::ResizeEdge::kRight:
       return StringToV8(isolate, "right");
diff --git a/shell/common/gin_converters/gfx_converter.h b/shell/common/gin_converters/gfx_converter.h
index 43903b464ed2..700ce8134c3f 100644
--- a/shell/common/gin_converters/gfx_converter.h
+++ b/shell/common/gin_converters/gfx_converter.h
@@ -77,7 +77,7 @@ struct Converter<display::Display> {
 template <>
 struct Converter<gfx::ResizeEdge> {
   static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
-                                   const gfx::ResizeEdge& val);
+                                   const gfx::ResizeEdge val);
 };
 
 template <>