mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

address review comments

Browse source
This commit is contained in:
deepak1556 2017-02-01 21:12:17 +05:30
parent 6cb626db88
commit 671a8a2cd6
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/ui/webui/pdf_viewer_handler.cc
View file

@ -132,7 +132,7 @@ void PdfViewerHandler::GetStrings(const base::ListValue* args) {
CHECK(args->Get(0, &callback_id)); CHECK(args->Get(0, &callback_id));
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue); std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
// TODO(deepak1556): Generate strings from componenets/pdf_strings.grdp. // TODO(deepak1556): Generate strings from components/pdf_strings.grdp.
#define SET_STRING(id, resource) result->SetString(id, resource) #define SET_STRING(id, resource) result->SetString(id, resource)
SET_STRING("passwordPrompt", SET_STRING("passwordPrompt",
"This document is password protected. Please enter a password."); "This document is password protected. Please enter a password.");

2
atom/browser/ui/webui/pdf_viewer_ui.cc
View file

@ -48,7 +48,7 @@ class BundledDataSource : public content::URLDataSource {
int render_frame_id, int render_frame_id,
const GotDataCallback& callback) override { const GotDataCallback& callback) override {
std::string filename = PathWithoutParams(path); std::string filename = PathWithoutParams(path);
std::map<base::FilePath, int>::const_iterator entry = auto entry =
path_to_resource_id_.find(base::FilePath::FromUTF8Unsafe(filename)); path_to_resource_id_.find(base::FilePath::FromUTF8Unsafe(filename));
if (entry != path_to_resource_id_.end()) { if (entry != path_to_resource_id_.end()) {