From 671a8a2cd6ec7948861a7844bf88d5c7aeb28d86 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Wed, 1 Feb 2017 21:12:17 +0530 Subject: [PATCH] address review comments --- atom/browser/ui/webui/pdf_viewer_handler.cc | 2 +- atom/browser/ui/webui/pdf_viewer_ui.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/ui/webui/pdf_viewer_handler.cc b/atom/browser/ui/webui/pdf_viewer_handler.cc index 70fa995d889..37b18de39e2 100644 --- a/atom/browser/ui/webui/pdf_viewer_handler.cc +++ b/atom/browser/ui/webui/pdf_viewer_handler.cc @@ -132,7 +132,7 @@ void PdfViewerHandler::GetStrings(const base::ListValue* args) { CHECK(args->Get(0, &callback_id)); std::unique_ptr result(new base::DictionaryValue); - // TODO(deepak1556): Generate strings from componenets/pdf_strings.grdp. +// TODO(deepak1556): Generate strings from components/pdf_strings.grdp. #define SET_STRING(id, resource) result->SetString(id, resource) SET_STRING("passwordPrompt", "This document is password protected. Please enter a password."); diff --git a/atom/browser/ui/webui/pdf_viewer_ui.cc b/atom/browser/ui/webui/pdf_viewer_ui.cc index 2d031872974..0c642a28ee7 100644 --- a/atom/browser/ui/webui/pdf_viewer_ui.cc +++ b/atom/browser/ui/webui/pdf_viewer_ui.cc @@ -48,7 +48,7 @@ class BundledDataSource : public content::URLDataSource { int render_frame_id, const GotDataCallback& callback) override { std::string filename = PathWithoutParams(path); - std::map::const_iterator entry = + auto entry = path_to_resource_id_.find(base::FilePath::FromUTF8Unsafe(filename)); if (entry != path_to_resource_id_.end()) {