mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: deinit platform before resetting node env (#23116)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-04-15 15:30:13 -07:00 committed by GitHub
parent 111f9155e0
commit 5f43c829a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/electron_browser_main_parts.cc
View file

@ -507,8 +507,8 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
// Destroy node platform after all destructors_ are executed, as they may // Destroy node platform after all destructors_ are executed, as they may
// invoke Node/V8 APIs inside them. // invoke Node/V8 APIs inside them.
node_debugger_->Stop(); node_debugger_->Stop();
node_env_.reset();
js_env_->OnMessageLoopDestroying(); js_env_->OnMessageLoopDestroying();
node_env_.reset();
fake_browser_process_->PostMainMessageLoopRun(); fake_browser_process_->PostMainMessageLoopRun();
} }