From 5f43c829a054db2db76808ab1c73cdde1d604513 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 15 Apr 2020 15:30:13 -0700 Subject: [PATCH] fix: deinit platform before resetting node env (#23116) --- shell/browser/electron_browser_main_parts.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc index 88c8495a63f9..aaff6d4e955c 100644 --- a/shell/browser/electron_browser_main_parts.cc +++ b/shell/browser/electron_browser_main_parts.cc @@ -507,8 +507,8 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() { // Destroy node platform after all destructors_ are executed, as they may // invoke Node/V8 APIs inside them. node_debugger_->Stop(); - node_env_.reset(); js_env_->OnMessageLoopDestroying(); + node_env_.reset(); fake_browser_process_->PostMainMessageLoopRun(); }