Fix pylint warnings

This commit is contained in:
Cheng Zhao 2015-04-08 19:19:40 +08:00
parent 1b3b2cd402
commit 555e06573a
2 changed files with 8 additions and 22 deletions

View file

@ -1,6 +1,5 @@
#!/usr/bin/env python #!/usr/bin/env python
import argparse
import os import os
import re import re
import shutil import shutil
@ -79,8 +78,6 @@ def main():
rm_rf(DIST_DIR) rm_rf(DIST_DIR)
os.makedirs(DIST_DIR) os.makedirs(DIST_DIR)
args = parse_args()
force_build() force_build()
create_symbols() create_symbols()
copy_binaries() copy_binaries()
@ -96,17 +93,6 @@ def main():
create_symbols_zip() create_symbols_zip()
def parse_args():
parser = argparse.ArgumentParser(description='Create distributions')
parser.add_argument('-u', '--url',
help='The base URL from which to download '
'libchromiumcontent (i.e., the URL you passed to '
'libchromiumcontent\'s script/upload script',
default=BASE_URL,
required=False)
return parser.parse_args()
def force_build(): def force_build():
build = os.path.join(SOURCE_ROOT, 'script', 'build.py') build = os.path.join(SOURCE_ROOT, 'script', 'build.py')
execute([sys.executable, build, '-c', 'Release']) execute([sys.executable, build, '-c', 'Release'])

View file

@ -47,14 +47,14 @@ def run_gyp(target_arch, component):
# Force using win32 python on cygwin. # Force using win32 python on cygwin.
python = os.path.join('vendor', 'python_26', 'python.exe') python = os.path.join('vendor', 'python_26', 'python.exe')
gyp = os.path.join('vendor', 'brightray', 'vendor', 'gyp', 'gyp_main.py') gyp = os.path.join('vendor', 'brightray', 'vendor', 'gyp', 'gyp_main.py')
return subprocess.call([python, gyp, defines = [
'-f', 'ninja', '--depth', '.', 'atom.gyp', '-Dlibchromiumcontent_component={0}'.format(component),
'-Icommon.gypi', '-Dlinux_clang=0', # FIXME remove me.
'-Dlibchromiumcontent_component={0}'.format(component), '-Dtarget_arch={0}'.format(target_arch),
'-Dlinux_clang=0', # FIXME remove me. '-Dlibrary=static_library',
'-Dtarget_arch={0}'.format(target_arch), ]
'-Dlibrary=static_library']) return subprocess.call([python, gyp, '-f', 'ninja', '--depth', '.',
'atom.gyp', '-Icommon.gypi'] + defines)
if __name__ == '__main__': if __name__ == '__main__':
sys.exit(main()) sys.exit(main())