From 555e06573a1d54faae372cbd6c8c20d891d92a01 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Wed, 8 Apr 2015 19:19:40 +0800
Subject: [PATCH] Fix pylint warnings

---
 script/create-dist.py | 14 --------------
 script/update.py      | 16 ++++++++--------
 2 files changed, 8 insertions(+), 22 deletions(-)

diff --git a/script/create-dist.py b/script/create-dist.py
index 0b3152b8cbb7..4341adad37e8 100755
--- a/script/create-dist.py
+++ b/script/create-dist.py
@@ -1,6 +1,5 @@
 #!/usr/bin/env python
 
-import argparse
 import os
 import re
 import shutil
@@ -79,8 +78,6 @@ def main():
   rm_rf(DIST_DIR)
   os.makedirs(DIST_DIR)
 
-  args = parse_args()
-
   force_build()
   create_symbols()
   copy_binaries()
@@ -96,17 +93,6 @@ def main():
   create_symbols_zip()
 
 
-def parse_args():
-  parser = argparse.ArgumentParser(description='Create distributions')
-  parser.add_argument('-u', '--url',
-                      help='The base URL from which to download '
-                      'libchromiumcontent (i.e., the URL you passed to '
-                      'libchromiumcontent\'s script/upload script',
-                      default=BASE_URL,
-                      required=False)
-  return parser.parse_args()
-
-
 def force_build():
   build = os.path.join(SOURCE_ROOT, 'script', 'build.py')
   execute([sys.executable, build, '-c', 'Release'])
diff --git a/script/update.py b/script/update.py
index 67a0c2b5002d..9b47ead488cd 100755
--- a/script/update.py
+++ b/script/update.py
@@ -47,14 +47,14 @@ def run_gyp(target_arch, component):
     # Force using win32 python on cygwin.
     python = os.path.join('vendor', 'python_26', 'python.exe')
   gyp = os.path.join('vendor', 'brightray', 'vendor', 'gyp', 'gyp_main.py')
-  return subprocess.call([python, gyp,
-                          '-f', 'ninja', '--depth', '.', 'atom.gyp',
-                          '-Icommon.gypi',
-                          '-Dlibchromiumcontent_component={0}'.format(component),
-                          '-Dlinux_clang=0',  # FIXME remove me.
-                          '-Dtarget_arch={0}'.format(target_arch),
-                          '-Dlibrary=static_library'])
-
+  defines = [
+    '-Dlibchromiumcontent_component={0}'.format(component),
+    '-Dlinux_clang=0',  # FIXME remove me.
+    '-Dtarget_arch={0}'.format(target_arch),
+    '-Dlibrary=static_library',
+  ]
+  return subprocess.call([python, gyp, '-f', 'ninja', '--depth', '.',
+                          'atom.gyp', '-Icommon.gypi'] + defines)
 
 if __name__ == '__main__':
   sys.exit(main())