mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Use closed event instead of destroyed event.

Browse source 
We now do not delete window manually so the destroyed would be delayed
until the object is GCed.
This commit is contained in:
Cheng Zhao 2014-04-23 08:50:33 +08:00
parent 5a316c0c41
commit 5037daadfb
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/lib/browser-window.coffee
View file

@ -19,7 +19,7 @@ BrowserWindow::_init = ->
# Remove the window from weak map immediately when it's destroyed, since we # Remove the window from weak map immediately when it's destroyed, since we
# could be iterating windows before GC happended. # could be iterating windows before GC happended.
@once 'destroyed', -> @once 'closed', ->
BrowserWindow.windows.remove id if BrowserWindow.windows.has id BrowserWindow.windows.remove id if BrowserWindow.windows.has id
# Tell the rpc server that a render view has been deleted and we need to # Tell the rpc server that a render view has been deleted and we need to

2
spec/api-browser-window-spec.coffee
View file

@ -14,7 +14,7 @@ describe 'browser-window module', ->
w.on 'loading-state-changed', (event, isLoading) -> w.on 'loading-state-changed', (event, isLoading) ->
if (!isLoading) if (!isLoading)
w.close() w.close()
w.on 'destroyed', -> w.on 'closed', ->
test = path.join(fixtures, 'api', 'unload') test = path.join(fixtures, 'api', 'unload')
content = fs.readFileSync(test) content = fs.readFileSync(test)
fs.unlinkSync(test) fs.unlinkSync(test)