From 5037daadfb6027741d075d924c5755651ec84099 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Wed, 23 Apr 2014 08:50:33 +0800 Subject: [PATCH] Use closed event instead of destroyed event. We now do not delete window manually so the destroyed would be delayed until the object is GCed. --- atom/browser/api/lib/browser-window.coffee | 2 +- spec/api-browser-window-spec.coffee | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/lib/browser-window.coffee b/atom/browser/api/lib/browser-window.coffee index a359b28218dd..94ca508b3959 100644 --- a/atom/browser/api/lib/browser-window.coffee +++ b/atom/browser/api/lib/browser-window.coffee @@ -19,7 +19,7 @@ BrowserWindow::_init = -> # Remove the window from weak map immediately when it's destroyed, since we # could be iterating windows before GC happended. - @once 'destroyed', -> + @once 'closed', -> BrowserWindow.windows.remove id if BrowserWindow.windows.has id # Tell the rpc server that a render view has been deleted and we need to diff --git a/spec/api-browser-window-spec.coffee b/spec/api-browser-window-spec.coffee index 6f8cab50bd21..c67c873f7dae 100644 --- a/spec/api-browser-window-spec.coffee +++ b/spec/api-browser-window-spec.coffee @@ -14,7 +14,7 @@ describe 'browser-window module', -> w.on 'loading-state-changed', (event, isLoading) -> if (!isLoading) w.close() - w.on 'destroyed', -> + w.on 'closed', -> test = path.join(fixtures, 'api', 'unload') content = fs.readFileSync(test) fs.unlinkSync(test)