mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: [gn] copy node.dll in addition to node.dll.lib (#13489)

Browse source 
On Windows, you need to link against the `.lib` but the `.dll` needs to be next to the `.exe` at runtime, so we need to copy both.
This commit is contained in:
Jeremy Apthorp 2018-06-28 14:25:56 -07:00 committed by GitHub
parent 6492732631
commit 475eef01c3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
build/node/BUILD.gn
View file

@ -77,7 +77,7 @@ action("build_node") {
outputs = [ "$target_out_dir/Release/lib/libnode.so" ] outputs = [ "$target_out_dir/Release/lib/libnode.so" ]
} }
if (is_win) { if (is_win) {
outputs = [ "$target_out_dir/Release/node.dll" ] outputs = [ "$target_out_dir/Release/node.dll.lib", "$target_out_dir/Release/node.dll" ]
} }
} }
@ -95,7 +95,7 @@ config("node_config") {
"//third_party/electron_node/deps/uv/include", "//third_party/electron_node/deps/uv/include",
"//third_party/electron_node/deps/cares/include", "//third_party/electron_node/deps/cares/include",
] ]
libs = node_libs libs = [ node_libs[0] ]
cflags_cc = [ cflags_cc = [
"-Wno-deprecated-declarations", "-Wno-deprecated-declarations",
] ]