From 475eef01c3913d90625f36547a9b883c92d9450e Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Thu, 28 Jun 2018 14:25:56 -0700 Subject: [PATCH] chore: [gn] copy node.dll in addition to node.dll.lib (#13489) On Windows, you need to link against the `.lib` but the `.dll` needs to be next to the `.exe` at runtime, so we need to copy both. --- build/node/BUILD.gn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/node/BUILD.gn b/build/node/BUILD.gn index 9eab747415b..686fdac5569 100644 --- a/build/node/BUILD.gn +++ b/build/node/BUILD.gn @@ -77,7 +77,7 @@ action("build_node") { outputs = [ "$target_out_dir/Release/lib/libnode.so" ] } if (is_win) { - outputs = [ "$target_out_dir/Release/node.dll" ] + outputs = [ "$target_out_dir/Release/node.dll.lib", "$target_out_dir/Release/node.dll" ] } } @@ -95,7 +95,7 @@ config("node_config") { "//third_party/electron_node/deps/uv/include", "//third_party/electron_node/deps/cares/include", ] - libs = node_libs + libs = [ node_libs[0] ] cflags_cc = [ "-Wno-deprecated-declarations", ]