mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove _ prefix on binding methods

Browse source
This commit is contained in:
Kevin Sawicki 2017-02-02 13:00:00 -08:00
parent e4c54fd0d8
commit 3e18d8baf5
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/common/api/atom_api_crash_reporter.cc
View file

@ -38,11 +38,11 @@ void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
auto report = base::Unretained(CrashReporter::GetInstance()); auto report = base::Unretained(CrashReporter::GetInstance());
dict.SetMethod("start", dict.SetMethod("start",
base::Bind(&CrashReporter::Start, report)); base::Bind(&CrashReporter::Start, report));
dict.SetMethod("_getUploadedReports", dict.SetMethod("getUploadedReports",
base::Bind(&CrashReporter::GetUploadedReports, report)); base::Bind(&CrashReporter::GetUploadedReports, report));
dict.SetMethod("_setUploadToServer", dict.SetMethod("setUploadToServer",
base::Bind(&CrashReporter::SetUploadToServer, report)); base::Bind(&CrashReporter::SetUploadToServer, report));
dict.SetMethod("_getUploadToServer", dict.SetMethod("getUploadToServer",
base::Bind(&CrashReporter::GetUploadToServer, report)); base::Bind(&CrashReporter::GetUploadToServer, report));
} }

4
lib/common/api/crash-reporter.js
View file

@ -104,7 +104,7 @@ class CrashReporter {
getUploadToServer () { getUploadToServer () {
if (process.type === 'browser') { if (process.type === 'browser') {
return binding._getUploadToServer() return binding.getUploadToServer()
} else { } else {
throw new Error('getUploadToServer can only be called from the main process') throw new Error('getUploadToServer can only be called from the main process')
} }
@ -112,7 +112,7 @@ class CrashReporter {
setUploadToServer (uploadToServer) { setUploadToServer (uploadToServer) {
if (process.type === 'browser') { if (process.type === 'browser') {
return binding._setUploadToServer(uploadToServer) return binding.setUploadToServer(uploadToServer)
} else { } else {
throw new Error('setUploadToServer can only be called from the main process') throw new Error('setUploadToServer can only be called from the main process')
} }