From 3e18d8baf564943664951fd385bb23296a302e95 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 2 Feb 2017 13:00:00 -0800 Subject: [PATCH] Remove _ prefix on binding methods --- atom/common/api/atom_api_crash_reporter.cc | 6 +++--- lib/common/api/crash-reporter.js | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/atom/common/api/atom_api_crash_reporter.cc b/atom/common/api/atom_api_crash_reporter.cc index aaaf200b32f3..57f880ff1944 100644 --- a/atom/common/api/atom_api_crash_reporter.cc +++ b/atom/common/api/atom_api_crash_reporter.cc @@ -38,11 +38,11 @@ void Initialize(v8::Local exports, v8::Local unused, auto report = base::Unretained(CrashReporter::GetInstance()); dict.SetMethod("start", base::Bind(&CrashReporter::Start, report)); - dict.SetMethod("_getUploadedReports", + dict.SetMethod("getUploadedReports", base::Bind(&CrashReporter::GetUploadedReports, report)); - dict.SetMethod("_setUploadToServer", + dict.SetMethod("setUploadToServer", base::Bind(&CrashReporter::SetUploadToServer, report)); - dict.SetMethod("_getUploadToServer", + dict.SetMethod("getUploadToServer", base::Bind(&CrashReporter::GetUploadToServer, report)); } diff --git a/lib/common/api/crash-reporter.js b/lib/common/api/crash-reporter.js index c5a462cf5110..3579a8c375b6 100644 --- a/lib/common/api/crash-reporter.js +++ b/lib/common/api/crash-reporter.js @@ -104,7 +104,7 @@ class CrashReporter { getUploadToServer () { if (process.type === 'browser') { - return binding._getUploadToServer() + return binding.getUploadToServer() } else { throw new Error('getUploadToServer can only be called from the main process') } @@ -112,7 +112,7 @@ class CrashReporter { setUploadToServer (uploadToServer) { if (process.type === 'browser') { - return binding._setUploadToServer(uploadToServer) + return binding.setUploadToServer(uploadToServer) } else { throw new Error('setUploadToServer can only be called from the main process') }