mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

Add read-only version to planned 2.0 API

Browse source
This commit is contained in:
Kevin Sawicki 2017-01-12 13:49:25 -08:00
parent 726bab0293
commit 323edb9d53
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
atom/common/api/atom_bindings.cc
View file

@ -112,6 +112,7 @@ void AtomBindings::BindTo(v8::Isolate* isolate,
mate::Dictionary versions; mate::Dictionary versions;
if (dict.Get("versions", &versions)) { if (dict.Get("versions", &versions)) {
// TODO(kevinsawicki): Make read-only in 2.0 to match node
versions.Set(ATOM_PROJECT_NAME, ATOM_VERSION_STRING); versions.Set(ATOM_PROJECT_NAME, ATOM_VERSION_STRING);
versions.Set("chrome", CHROME_VERSION_STRING); versions.Set("chrome", CHROME_VERSION_STRING);

4
docs/tutorial/planned-breaking-changes.md
View file

@ -87,6 +87,10 @@ process.versions['atom-shell']
process.versions.electron process.versions.electron
``` ```
* `process.versions.electron` and `process.version.chrome` will be made
read-only properties for consistency with the other `process.versions`
properties set by Node.
## `Tray` ## `Tray`
```js ```js