From 323edb9d5310f736217d533f9b30f462fba60df6 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 12 Jan 2017 13:49:25 -0800 Subject: [PATCH] Add read-only version to planned 2.0 API --- atom/common/api/atom_bindings.cc | 1 + docs/tutorial/planned-breaking-changes.md | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/atom/common/api/atom_bindings.cc b/atom/common/api/atom_bindings.cc index 27b3352f37d..9173a10a382 100644 --- a/atom/common/api/atom_bindings.cc +++ b/atom/common/api/atom_bindings.cc @@ -112,6 +112,7 @@ void AtomBindings::BindTo(v8::Isolate* isolate, mate::Dictionary versions; if (dict.Get("versions", &versions)) { + // TODO(kevinsawicki): Make read-only in 2.0 to match node versions.Set(ATOM_PROJECT_NAME, ATOM_VERSION_STRING); versions.Set("chrome", CHROME_VERSION_STRING); diff --git a/docs/tutorial/planned-breaking-changes.md b/docs/tutorial/planned-breaking-changes.md index 681c66fc452..e2d0e3a939a 100644 --- a/docs/tutorial/planned-breaking-changes.md +++ b/docs/tutorial/planned-breaking-changes.md @@ -87,6 +87,10 @@ process.versions['atom-shell'] process.versions.electron ``` +* `process.versions.electron` and `process.version.chrome` will be made + read-only properties for consistency with the other `process.versions` + properties set by Node. + ## `Tray` ```js