mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: remove unused C string ToV8() gin converter (#44523)

Browse source 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-11-02 13:56:55 -05:00 committed by GitHub
parent faa1910ffe
commit 2e33636033
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_web_contents.cc
View file

@ -1312,7 +1312,7 @@ content::KeyboardEventProcessingResult WebContents::PreHandleKeyboardEvent(
} }
void WebContents::ContentsZoomChange(bool zoom_in) { void WebContents::ContentsZoomChange(bool zoom_in) {
Emit("zoom-changed", zoom_in ? "in" : "out"); Emit("zoom-changed", std::string_view{zoom_in ? "in" : "out"});
} }
Profile* WebContents::GetProfile() { Profile* WebContents::GetProfile() {

8
shell/common/gin_converters/std_converter.h
View file

@ -54,14 +54,6 @@ struct Converter<std::nullptr_t> {
} }
}; };
template <>
struct Converter<const char*> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {
return v8::String::NewFromUtf8(isolate, val, v8::NewStringType::kNormal)
.ToLocalChecked();
}
};
template <> template <>
struct Converter<char[]> { struct Converter<char[]> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) { static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {