From 2e336360334085e046d4619125d4c0ad44d55c42 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Sat, 2 Nov 2024 13:56:55 -0500 Subject: [PATCH] refactor: remove unused C string ToV8() gin converter (#44523) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_web_contents.cc | 2 +- shell/common/gin_converters/std_converter.h | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc index 2252860312dc..93a7e8749744 100644 --- a/shell/browser/api/electron_api_web_contents.cc +++ b/shell/browser/api/electron_api_web_contents.cc @@ -1312,7 +1312,7 @@ content::KeyboardEventProcessingResult WebContents::PreHandleKeyboardEvent( } void WebContents::ContentsZoomChange(bool zoom_in) { - Emit("zoom-changed", zoom_in ? "in" : "out"); + Emit("zoom-changed", std::string_view{zoom_in ? "in" : "out"}); } Profile* WebContents::GetProfile() { diff --git a/shell/common/gin_converters/std_converter.h b/shell/common/gin_converters/std_converter.h index de499cf46715..96ffb828185f 100644 --- a/shell/common/gin_converters/std_converter.h +++ b/shell/common/gin_converters/std_converter.h @@ -54,14 +54,6 @@ struct Converter { } }; -template <> -struct Converter { - static v8::Local ToV8(v8::Isolate* isolate, const char* val) { - return v8::String::NewFromUtf8(isolate, val, v8::NewStringType::kNormal) - .ToLocalChecked(); - } -}; - template <> struct Converter { static v8::Local ToV8(v8::Isolate* isolate, const char* val) {