mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: use pylint-2.7 (#33232)

Browse source 
* chore: use pylint-2.7

* chore: fix pylint errors
This commit is contained in:
David Sanders 2022-03-22 17:17:35 -07:00 committed by GitHub
parent 4633376b28
commit 27ddf19f3c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
script/lint.js
View file

@ -103,7 +103,7 @@ const LINTERS = [{
const rcfile = path.join(DEPOT_TOOLS, 'pylintrc'); const rcfile = path.join(DEPOT_TOOLS, 'pylintrc');
const args = ['--rcfile=' + rcfile, ...filenames]; const args = ['--rcfile=' + rcfile, ...filenames];
const env = Object.assign({ PYTHONPATH: path.join(ELECTRON_ROOT, 'script') }, process.env); const env = Object.assign({ PYTHONPATH: path.join(ELECTRON_ROOT, 'script') }, process.env);
spawnAndCheckExitCode('pylint', args, { env }); spawnAndCheckExitCode('pylint-2.7', args, { env });
} }
}, { }, {
key: 'javascript', key: 'javascript',

1
script/release/uploaders/upload.py
View file

@ -208,6 +208,7 @@ def zero_zip_date_time(fname):
with open(fname, 'r+b') as f: with open(fname, 'r+b') as f:
_zero_zip_date_time(f) _zero_zip_date_time(f)
except Exception: except Exception:
# pylint: disable=W0707
raise NonZipFileError(fname) raise NonZipFileError(fname)

5
script/run-clang-format.py
View file

@ -78,12 +78,14 @@ def make_diff(diff_file, original, reformatted):
class DiffError(Exception): class DiffError(Exception):
def __init__(self, message, errs=None): def __init__(self, message, errs=None):
# pylint: disable=R1725
super(DiffError, self).__init__(message) super(DiffError, self).__init__(message)
self.errs = errs or [] self.errs = errs or []
class UnexpectedError(Exception): class UnexpectedError(Exception):
def __init__(self, message, exc=None): def __init__(self, message, exc=None):
# pylint: disable=R1725
super(UnexpectedError, self).__init__(message) super(UnexpectedError, self).__init__(message)
self.formatted_traceback = traceback.format_exc() self.formatted_traceback = traceback.format_exc()
self.exc = exc self.exc = exc
@ -96,6 +98,7 @@ def run_clang_format_diff_wrapper(args, file_name):
except DiffError: except DiffError:
raise raise
except Exception as e: except Exception as e:
# pylint: disable=W0707
raise UnexpectedError('{}: {}: {}'.format( raise UnexpectedError('{}: {}: {}'.format(
file_name, e.__class__.__name__, e), e) file_name, e.__class__.__name__, e), e)
@ -105,6 +108,7 @@ def run_clang_format_diff(args, file_name):
with io.open(file_name, 'r', encoding='utf-8') as f: with io.open(file_name, 'r', encoding='utf-8') as f:
original = f.readlines() original = f.readlines()
except IOError as exc: except IOError as exc:
# pylint: disable=W0707
raise DiffError(str(exc)) raise DiffError(str(exc))
invocation = [args.clang_format_executable, file_name] invocation = [args.clang_format_executable, file_name]
if args.fix: if args.fix:
@ -117,6 +121,7 @@ def run_clang_format_diff(args, file_name):
universal_newlines=True, universal_newlines=True,
shell=True) shell=True)
except OSError as exc: except OSError as exc:
# pylint: disable=W0707
raise DiffError(str(exc)) raise DiffError(str(exc))
proc_stdout = proc.stdout proc_stdout = proc.stdout
proc_stderr = proc.stderr proc_stderr = proc.stderr