mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: fix crash on image.crop (#33148)

Browse source 
* test: fix crash on image.crop

* Trigger CI
This commit is contained in:
David Sanders 2022-03-22 17:14:49 -07:00 committed by GitHub
parent 8ad1470d08
commit 4633376b28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
spec-main/screen-helpers.ts
View file

@ -41,7 +41,8 @@ const formatHexByte = (val: number): string => {
* Get the hex color at the given pixel coordinate in an image.
*/
export const getPixelColor = (image: Electron.NativeImage, point: Electron.Point): string => {
const pixel = image.crop({ ...point, width: 1, height: 1 });
// image.crop crashes if point is fractional, so round to prevent that crash
const pixel = image.crop({ x: Math.round(point.x), y: Math.round(point.y), width: 1, height: 1 });
// TODO(samuelmaddock): NativeImage.toBitmap() should return the raw pixel
// color, but it sometimes differs. Why is that?
const [b, g, r] = pixel.toBitmap();