build: run GN Check everywhere (#42515)
* build: run GN Check everywhere * build: remove gn check matrix --------- Co-authored-by: Samuel Attard <sam@electronjs.org>
This commit is contained in:
parent
2b259bd69e
commit
1a4d58a9fb
3 changed files with 11 additions and 6 deletions
|
@ -67,6 +67,15 @@ jobs:
|
||||||
generate-symbols: ${{ inputs.generate-symbols }}
|
generate-symbols: ${{ inputs.generate-symbols }}
|
||||||
upload-to-storage: ${{ inputs.upload-to-storage }}
|
upload-to-storage: ${{ inputs.upload-to-storage }}
|
||||||
secrets: inherit
|
secrets: inherit
|
||||||
|
gn-check:
|
||||||
|
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
||||||
|
with:
|
||||||
|
target-platform: ${{ inputs.target-platform }}
|
||||||
|
target-arch: ${{ inputs.target-arch }}
|
||||||
|
check-runs-on: ${{ inputs.build-runs-on }}
|
||||||
|
check-container: ${{ inputs.build-container }}
|
||||||
|
gn-build-type: ${{ inputs.gn-build-type }}
|
||||||
|
secrets: inherit
|
||||||
test:
|
test:
|
||||||
uses: ./.github/workflows/pipeline-segment-electron-test.yml
|
uses: ./.github/workflows/pipeline-segment-electron-test.yml
|
||||||
needs: build
|
needs: build
|
||||||
|
|
|
@ -68,7 +68,6 @@ jobs:
|
||||||
upload-to-storage: ${{ inputs.upload-to-storage }}
|
upload-to-storage: ${{ inputs.upload-to-storage }}
|
||||||
secrets: inherit
|
secrets: inherit
|
||||||
gn-check:
|
gn-check:
|
||||||
if: ${{ inputs.target-platform == 'macos' || inputs.target-arch != 'arm' }}
|
|
||||||
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml
|
||||||
with:
|
with:
|
||||||
target-platform: ${{ inputs.target-platform }}
|
target-platform: ${{ inputs.target-platform }}
|
||||||
|
|
|
@ -31,6 +31,8 @@ concurrency:
|
||||||
cancel-in-progress: true
|
cancel-in-progress: true
|
||||||
|
|
||||||
env:
|
env:
|
||||||
|
AZURE_AKS_CACHE_STORAGE_ACCOUNT: ${{ secrets.AZURE_AKS_CACHE_STORAGE_ACCOUNT }}
|
||||||
|
AZURE_AKS_CACHE_SHARE_NAME: ${{ secrets.AZURE_AKS_CACHE_SHARE_NAME }}
|
||||||
ELECTRON_RBE_JWT: ${{ secrets.ELECTRON_RBE_JWT }}
|
ELECTRON_RBE_JWT: ${{ secrets.ELECTRON_RBE_JWT }}
|
||||||
GN_BUILDFLAG_ARGS: 'enable_precompiled_headers=false'
|
GN_BUILDFLAG_ARGS: 'enable_precompiled_headers=false'
|
||||||
GCLIENT_EXTRA_ARGS: ${{ inputs.target-platform == 'macos' && '--custom-var=checkout_mac=True --custom-var=host_os=mac' || '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True' }}
|
GCLIENT_EXTRA_ARGS: ${{ inputs.target-platform == 'macos' && '--custom-var=checkout_mac=True --custom-var=host_os=mac' || '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True' }}
|
||||||
|
@ -42,12 +44,7 @@ jobs:
|
||||||
# TODO(codebytere): Change this to medium VM
|
# TODO(codebytere): Change this to medium VM
|
||||||
runs-on: ${{ inputs.check-runs-on }}
|
runs-on: ${{ inputs.check-runs-on }}
|
||||||
container: ${{ fromJSON(inputs.check-container) }}
|
container: ${{ fromJSON(inputs.check-container) }}
|
||||||
strategy:
|
|
||||||
fail-fast: false
|
|
||||||
matrix:
|
|
||||||
build-type: ${{ inputs.target-platform == 'macos' && fromJSON('["darwin","mas"]') || fromJSON('["linux"]') }}
|
|
||||||
env:
|
env:
|
||||||
BUILD_TYPE: ${{ matrix.build-type }}
|
|
||||||
TARGET_ARCH: ${{ inputs.target-arch }}
|
TARGET_ARCH: ${{ inputs.target-arch }}
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout Electron
|
- name: Checkout Electron
|
||||||
|
|
Loading…
Reference in a new issue