diff --git a/.github/workflows/pipeline-electron-build-and-test-and-nan.yml b/.github/workflows/pipeline-electron-build-and-test-and-nan.yml index 80a313060005..f17ca4d0969b 100644 --- a/.github/workflows/pipeline-electron-build-and-test-and-nan.yml +++ b/.github/workflows/pipeline-electron-build-and-test-and-nan.yml @@ -67,6 +67,15 @@ jobs: generate-symbols: ${{ inputs.generate-symbols }} upload-to-storage: ${{ inputs.upload-to-storage }} secrets: inherit + gn-check: + uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml + with: + target-platform: ${{ inputs.target-platform }} + target-arch: ${{ inputs.target-arch }} + check-runs-on: ${{ inputs.build-runs-on }} + check-container: ${{ inputs.build-container }} + gn-build-type: ${{ inputs.gn-build-type }} + secrets: inherit test: uses: ./.github/workflows/pipeline-segment-electron-test.yml needs: build diff --git a/.github/workflows/pipeline-electron-build-and-test.yml b/.github/workflows/pipeline-electron-build-and-test.yml index f7b05280fe27..f61fa6a07da4 100644 --- a/.github/workflows/pipeline-electron-build-and-test.yml +++ b/.github/workflows/pipeline-electron-build-and-test.yml @@ -68,7 +68,6 @@ jobs: upload-to-storage: ${{ inputs.upload-to-storage }} secrets: inherit gn-check: - if: ${{ inputs.target-platform == 'macos' || inputs.target-arch != 'arm' }} uses: ./.github/workflows/pipeline-segment-electron-gn-check.yml with: target-platform: ${{ inputs.target-platform }} diff --git a/.github/workflows/pipeline-segment-electron-gn-check.yml b/.github/workflows/pipeline-segment-electron-gn-check.yml index 1264a31f538c..001ef25f3c8d 100644 --- a/.github/workflows/pipeline-segment-electron-gn-check.yml +++ b/.github/workflows/pipeline-segment-electron-gn-check.yml @@ -31,6 +31,8 @@ concurrency: cancel-in-progress: true env: + AZURE_AKS_CACHE_STORAGE_ACCOUNT: ${{ secrets.AZURE_AKS_CACHE_STORAGE_ACCOUNT }} + AZURE_AKS_CACHE_SHARE_NAME: ${{ secrets.AZURE_AKS_CACHE_SHARE_NAME }} ELECTRON_RBE_JWT: ${{ secrets.ELECTRON_RBE_JWT }} GN_BUILDFLAG_ARGS: 'enable_precompiled_headers=false' GCLIENT_EXTRA_ARGS: ${{ inputs.target-platform == 'macos' && '--custom-var=checkout_mac=True --custom-var=host_os=mac' || '--custom-var=checkout_arm=True --custom-var=checkout_arm64=True' }} @@ -42,12 +44,7 @@ jobs: # TODO(codebytere): Change this to medium VM runs-on: ${{ inputs.check-runs-on }} container: ${{ fromJSON(inputs.check-container) }} - strategy: - fail-fast: false - matrix: - build-type: ${{ inputs.target-platform == 'macos' && fromJSON('["darwin","mas"]') || fromJSON('["linux"]') }} env: - BUILD_TYPE: ${{ matrix.build-type }} TARGET_ARCH: ${{ inputs.target-arch }} steps: - name: Checkout Electron