mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix cpp linting issues

Browse source
This commit is contained in:
Samuel Attard 2016-08-16 15:54:30 +10:00
parent ce986590cf
commit 14154e374a
No known key found for this signature in database
GPG key ID: 273DC1869D8F13EF
4 changed files with 24 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
atom/browser/browser.h
View file

@ -76,13 +76,16 @@ class Browser : public WindowListObserver {
void SetAppUserModelID(const base::string16& name); void SetAppUserModelID(const base::string16& name);
// Remove the default protocol handler registry key // Remove the default protocol handler registry key
bool RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); bool RemoveAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args);
// Set as default handler for a protocol. // Set as default handler for a protocol.
bool SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); bool SetAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args);
// Query the current state of default handler for a protocol. // Query the current state of default handler for a protocol.
bool IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); bool IsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args);
// Set/Get the badge count. // Set/Get the badge count.
bool SetBadgeCount(int count); bool SetBadgeCount(int count);

9
atom/browser/browser_linux.cc
View file

@ -35,15 +35,18 @@ void Browser::ClearRecentDocuments() {
void Browser::SetAppUserModelID(const base::string16& name) { void Browser::SetAppUserModelID(const base::string16& name) {
} }
bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
return false; return false;
} }
bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::SetAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
return false; return false;
} }
bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::IsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
return false; return false;
} }

9
atom/browser/browser_mac.mm
View file

@ -46,7 +46,8 @@ void Browser::ClearRecentDocuments() {
[[NSDocumentController sharedDocumentController] clearRecentDocuments:nil]; [[NSDocumentController sharedDocumentController] clearRecentDocuments:nil];
} }
bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
NSString* identifier = [base::mac::MainBundle() bundleIdentifier]; NSString* identifier = [base::mac::MainBundle() bundleIdentifier];
if (!identifier) if (!identifier)
return false; return false;
@ -74,7 +75,8 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::A
return return_code == noErr; return return_code == noErr;
} }
bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::SetAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
if (protocol.empty()) if (protocol.empty())
return false; return false;
@ -89,7 +91,8 @@ bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Argu
return return_code == noErr; return return_code == noErr;
} }
bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::IsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
if (protocol.empty()) if (protocol.empty())
return false; return false;

9
atom/browser/browser_win.cc
View file

@ -162,7 +162,8 @@ std::wstring protocolLaunchPath(std::string protocol, mate::Arguments* args) {
return exe + L"\"%1\""; return exe + L"\"%1\"";
} }
bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
if (protocol.empty()) if (protocol.empty())
return false; return false;
@ -204,7 +205,8 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::A
} }
} }
bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::SetAsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
// HKEY_CLASSES_ROOT // HKEY_CLASSES_ROOT
// $PROTOCOL // $PROTOCOL
// (Default) = "URL:$NAME" // (Default) = "URL:$NAME"
@ -251,7 +253,8 @@ bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Argu
return true; return true;
} }
bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { bool Browser::IsDefaultProtocolClient(const std::string& protocol,
mate::Arguments* args) {
if (protocol.empty()) if (protocol.empty())
return false; return false;