From 14154e374a6034ec09669c73cea224a1322f5d37 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Tue, 16 Aug 2016 15:54:30 +1000 Subject: [PATCH] Fix cpp linting issues --- atom/browser/browser.h | 9 ++++++--- atom/browser/browser_linux.cc | 9 ++++++--- atom/browser/browser_mac.mm | 9 ++++++--- atom/browser/browser_win.cc | 9 ++++++--- 4 files changed, 24 insertions(+), 12 deletions(-) diff --git a/atom/browser/browser.h b/atom/browser/browser.h index bf12c1e40bd4..efaa48437e20 100644 --- a/atom/browser/browser.h +++ b/atom/browser/browser.h @@ -76,13 +76,16 @@ class Browser : public WindowListObserver { void SetAppUserModelID(const base::string16& name); // Remove the default protocol handler registry key - bool RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); + bool RemoveAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args); // Set as default handler for a protocol. - bool SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); + bool SetAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args); // Query the current state of default handler for a protocol. - bool IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args); + bool IsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args); // Set/Get the badge count. bool SetBadgeCount(int count); diff --git a/atom/browser/browser_linux.cc b/atom/browser/browser_linux.cc index 9bd2288d85df..bcd37b170abc 100644 --- a/atom/browser/browser_linux.cc +++ b/atom/browser/browser_linux.cc @@ -35,15 +35,18 @@ void Browser::ClearRecentDocuments() { void Browser::SetAppUserModelID(const base::string16& name) { } -bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { return false; } -bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { return false; } -bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::IsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { return false; } diff --git a/atom/browser/browser_mac.mm b/atom/browser/browser_mac.mm index bebee8945fd4..508682baae1a 100644 --- a/atom/browser/browser_mac.mm +++ b/atom/browser/browser_mac.mm @@ -46,7 +46,8 @@ void Browser::ClearRecentDocuments() { [[NSDocumentController sharedDocumentController] clearRecentDocuments:nil]; } -bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { NSString* identifier = [base::mac::MainBundle() bundleIdentifier]; if (!identifier) return false; @@ -74,7 +75,8 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::A return return_code == noErr; } -bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { if (protocol.empty()) return false; @@ -89,7 +91,8 @@ bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Argu return return_code == noErr; } -bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::IsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { if (protocol.empty()) return false; diff --git a/atom/browser/browser_win.cc b/atom/browser/browser_win.cc index 2dcf0f4fd152..16c6314e8e16 100644 --- a/atom/browser/browser_win.cc +++ b/atom/browser/browser_win.cc @@ -162,7 +162,8 @@ std::wstring protocolLaunchPath(std::string protocol, mate::Arguments* args) { return exe + L"\"%1\""; } -bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { if (protocol.empty()) return false; @@ -204,7 +205,8 @@ bool Browser::RemoveAsDefaultProtocolClient(const std::string& protocol, mate::A } } -bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { // HKEY_CLASSES_ROOT // $PROTOCOL // (Default) = "URL:$NAME" @@ -251,7 +253,8 @@ bool Browser::SetAsDefaultProtocolClient(const std::string& protocol, mate::Argu return true; } -bool Browser::IsDefaultProtocolClient(const std::string& protocol, mate::Arguments* args) { +bool Browser::IsDefaultProtocolClient(const std::string& protocol, + mate::Arguments* args) { if (protocol.empty()) return false;