mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

BrowserWindow.show() should not focus window, fixes #609.

Browse source
This commit is contained in:
Cheng Zhao 2014-09-08 15:28:34 +08:00
parent add4e3c6f5
commit 1199224086
2 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/native_window_views.cc
View file

@ -226,7 +226,7 @@ bool NativeWindowViews::IsFocused() {
} }
void NativeWindowViews::Show() { void NativeWindowViews::Show() {
window_->Show(); window_->ShowInactive();
} }
void NativeWindowViews::Hide() { void NativeWindowViews::Hide() {

5
spec/api-browser-window-spec.coffee
View file

@ -56,6 +56,11 @@ describe 'browser-window module', ->
done() done()
w.loadUrl 'about:blank' w.loadUrl 'about:blank'
describe 'BrowserWindow.show()', ->
it 'should not focus window', ->
w.show()
assert !w.isFocused()
describe 'BrowserWindow.focus()', -> describe 'BrowserWindow.focus()', ->
it 'does not make the window become visible', -> it 'does not make the window become visible', ->
assert.equal w.isVisible(), false assert.equal w.isVisible(), false