From 11992240869b74ff371959c227255a2d3638c818 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Mon, 8 Sep 2014 15:28:34 +0800 Subject: [PATCH] BrowserWindow.show() should not focus window, fixes #609. --- atom/browser/native_window_views.cc | 2 +- spec/api-browser-window-spec.coffee | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/atom/browser/native_window_views.cc b/atom/browser/native_window_views.cc index 3c1cd30c2350..42a9e70dd0f2 100644 --- a/atom/browser/native_window_views.cc +++ b/atom/browser/native_window_views.cc @@ -226,7 +226,7 @@ bool NativeWindowViews::IsFocused() { } void NativeWindowViews::Show() { - window_->Show(); + window_->ShowInactive(); } void NativeWindowViews::Hide() { diff --git a/spec/api-browser-window-spec.coffee b/spec/api-browser-window-spec.coffee index 3b0cb5c7a8cf..6a4a1c494cc5 100644 --- a/spec/api-browser-window-spec.coffee +++ b/spec/api-browser-window-spec.coffee @@ -56,6 +56,11 @@ describe 'browser-window module', -> done() w.loadUrl 'about:blank' + describe 'BrowserWindow.show()', -> + it 'should not focus window', -> + w.show() + assert !w.isFocused() + describe 'BrowserWindow.focus()', -> it 'does not make the window become visible', -> assert.equal w.isVisible(), false