mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Enable a few tests

Browse source
This commit is contained in:
Aleksei Kuzmin 2018-06-18 11:00:59 +02:00 • committed by Samuel Attard
parent 10160b369b
commit 10c5141da0
3 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
spec/api-crash-reporter-spec.js
View file

@ -76,8 +76,7 @@ describe('crashReporter module', () => {
})
})
// TODO(alexeykuzmin): [Ch66] Enable the test.
xit('should send minidump when node processes crash', function (done) {
it('should send minidump when node processes crash', function (done) {
// TODO(alexeykuzmin): Skip the test instead of marking it as passed.
if (process.env.APPVEYOR === 'True') return done()

6
spec/asar-spec.js
View file

@ -766,8 +766,7 @@ describe('asar package', function () {
})
})
// TODO(alexeykuzmin): [Ch66] Fix the tests.
xdescribe('process.env.ELECTRON_NO_ASAR', function () {
describe('process.env.ELECTRON_NO_ASAR', function () {
it('disables asar support in forked processes', function (done) {
const forked = ChildProcess.fork(path.join(__dirname, 'fixtures', 'module', 'no-asar.js'), [], {
env: {
@ -939,8 +938,7 @@ describe('asar package', function () {
assert(stats.isFile())
})
// TODO(alexeykuzmin): [Ch66] Fix the test.
xit('is available in forked scripts', function (done) {
it('is available in forked scripts', function (done) {
var child = ChildProcess.fork(path.join(fixtures, 'module', 'original-fs.js'))
child.on('message', function (msg) {
assert.equal(msg, 'object')

3
spec/chromium-spec.js
View file

@ -296,8 +296,7 @@ describe('chromium feature', () => {
b = window.open(windowUrl, '', 'nodeIntegration=no,show=no')
})
// TODO(alexeykuzmin): [Ch66] Times out. Fix it and enable back.
xit('disables node integration when it is disabled on the parent window for chrome devtools URLs', (done) => {
it('disables node integration when it is disabled on the parent window for chrome devtools URLs', (done) => {
let b
app.once('web-contents-created', (event, contents) => {
contents.once('did-finish-load', () => {