From 10c5141da04872442f010344dc8f8393a8fef8fc Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Mon, 18 Jun 2018 11:00:59 +0200 Subject: [PATCH] Enable a few tests --- spec/api-crash-reporter-spec.js | 3 +-- spec/asar-spec.js | 6 ++---- spec/chromium-spec.js | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/spec/api-crash-reporter-spec.js b/spec/api-crash-reporter-spec.js index 63f387ee01a..dd31b91e124 100644 --- a/spec/api-crash-reporter-spec.js +++ b/spec/api-crash-reporter-spec.js @@ -76,8 +76,7 @@ describe('crashReporter module', () => { }) }) - // TODO(alexeykuzmin): [Ch66] Enable the test. - xit('should send minidump when node processes crash', function (done) { + it('should send minidump when node processes crash', function (done) { // TODO(alexeykuzmin): Skip the test instead of marking it as passed. if (process.env.APPVEYOR === 'True') return done() diff --git a/spec/asar-spec.js b/spec/asar-spec.js index b3ed9912d17..f87554f32e2 100644 --- a/spec/asar-spec.js +++ b/spec/asar-spec.js @@ -766,8 +766,7 @@ describe('asar package', function () { }) }) - // TODO(alexeykuzmin): [Ch66] Fix the tests. - xdescribe('process.env.ELECTRON_NO_ASAR', function () { + describe('process.env.ELECTRON_NO_ASAR', function () { it('disables asar support in forked processes', function (done) { const forked = ChildProcess.fork(path.join(__dirname, 'fixtures', 'module', 'no-asar.js'), [], { env: { @@ -939,8 +938,7 @@ describe('asar package', function () { assert(stats.isFile()) }) - // TODO(alexeykuzmin): [Ch66] Fix the test. - xit('is available in forked scripts', function (done) { + it('is available in forked scripts', function (done) { var child = ChildProcess.fork(path.join(fixtures, 'module', 'original-fs.js')) child.on('message', function (msg) { assert.equal(msg, 'object') diff --git a/spec/chromium-spec.js b/spec/chromium-spec.js index 723f56050b1..05b833fae9a 100644 --- a/spec/chromium-spec.js +++ b/spec/chromium-spec.js @@ -296,8 +296,7 @@ describe('chromium feature', () => { b = window.open(windowUrl, '', 'nodeIntegration=no,show=no') }) - // TODO(alexeykuzmin): [Ch66] Times out. Fix it and enable back. - xit('disables node integration when it is disabled on the parent window for chrome devtools URLs', (done) => { + it('disables node integration when it is disabled on the parent window for chrome devtools URLs', (done) => { let b app.once('web-contents-created', (event, contents) => { contents.once('did-finish-load', () => {