mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: crash in sandbox on linux when getting execPath (#15701)

Browse source
This commit is contained in:
Jeremy Apthorp 2018-11-15 12:59:01 -08:00 • committed by GitHub
parent c8860d006b
commit 0642be296d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/renderer/atom_sandboxed_renderer_client.cc
View file

@ -80,12 +80,6 @@ v8::Local<v8::Value> GetBinding(v8::Isolate* isolate,
return exports;
}
base::FilePath::StringType GetExecPath() {
base::FilePath path;
base::PathService::Get(base::FILE_EXE, &path);
return path.value();
}
v8::Local<v8::Value> CreatePreloadScript(v8::Isolate* isolate,
v8::Local<v8::String> preloadSrc) {
auto script = v8::Script::Compile(preloadSrc);
@ -157,9 +151,7 @@ void AtomSandboxedRendererClient::InitializeBindings(
process.SetMethod("getIOCounters", &AtomBindings::GetIOCounters);
process.Set("argv", base::CommandLine::ForCurrentProcess()->argv());
process.Set("execPath", GetExecPath());
process.SetReadOnly("pid", base::GetCurrentProcId());
process.Set("resourcesPath", NodeBindings::GetHelperResourcesPath());
process.SetReadOnly("sandboxed", true);
process.SetReadOnly("type", "renderer");