electron/shell/browser/ui/file_dialog_gtk.cc

469 lines
16 KiB
C++
Raw Normal View History

// Copyright (c) 2014 GitHub, Inc.
2014-04-25 09:49:37 +00:00
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
#include <gmodule.h>
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
#include <memory>
#include <string>
#include "base/callback.h"
#include "base/files/file_util.h"
2014-08-06 06:49:02 +00:00
#include "base/strings/string_util.h"
#include "shell/browser/javascript_environment.h"
#include "shell/browser/native_window_views.h"
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
#include "shell/browser/ui/file_dialog.h"
#include "shell/browser/ui/gtk_util.h"
#include "shell/browser/unresponsive_suppressor.h"
#include "shell/common/gin_converters/file_path_converter.h"
#include "ui/base/glib/glib_signal.h"
#include "ui/gtk/gtk_util.h"
2020-10-20 18:24:52 +00:00
#if defined(USE_X11)
#include "ui/events/platform/x11/x11_event_source.h"
#endif
#if defined(USE_OZONE) || defined(USE_X11)
#include "ui/base/ui_base_features.h"
#endif
namespace file_dialog {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
static GModule* gtk_module;
chore: bump chromium to 93.0.4530.0 (master) (#29256) * chore: bump chromium in DEPS to 92.0.4512.6 * 2887336: [CaptureHandle][#2] Propagate CaptureHandleConfig in browser process https://chromium-review.googlesource.com/c/chromium/src/+/2887336 * refactor: base::Optional -> absl::optional * chore: fixup patch indices * chore: bump chromium in DEPS to 92.0.4514.0 * 2899417: Make build work when enable_pdf is set to false. https://chromium-review.googlesource.com/c/chromium/src/+/2899417 * 2904731: use BrowserContext instead of Profile in PreconnectManager https://chromium-review.googlesource.com/c/chromium/src/+/2904731 * 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true https://chromium-review.googlesource.com/c/chromium/src/+/2295749 * 2893803: Add a GetWebView to RenderFrame. https://chromium-review.googlesource.com/c/chromium/src/+/2893803 * 2892345: Implement WebContents::ForEachRenderFrameHost https://chromium-review.googlesource.com/c/chromium/src/+/2892345 * chore: fixup patch indices * 2892048: Real instance methods for BrowserContext: remaining 5 methods. https://chromium-review.googlesource.com/c/chromium/src/+/2892048 * 2902821: [mojo] Don't require full header includes for referenced interfaces https://chromium-review.googlesource.com/c/chromium/src/+/2902821 * 2496500: Remove last deprecated extension Event ctor. https://chromium-review.googlesource.com/c/chromium/src/+/2496500 * chore: fixup malformed pepper support patch * chore: bump chromium in DEPS to 92.0.4515.0 * 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc. https://chromium-review.googlesource.com/c/chromium/src/+/2908461 * 2880838: viz: add optional HDRMetadata to TransferableResource https://chromium-review.googlesource.com/c/chromium/src/+/2880838 * chore: fixup patch indices * chore: bump chromium in DEPS to 92.0.4515.5 * chore: update patches * chore: bump chromium in DEPS to 92.0.4515.7 * chore: bump chromium in DEPS to 92.0.4515.9 * chore: bump chromium in DEPS to 93.0.4522.0 * chore: bump chromium in DEPS to 93.0.4523.0 * chore: bump chromium in DEPS to 93.0.4524.0 * chore: update patches * chore: enable_pak_file_integrity_checks was reverted * chore: update patches * refactor: base/optional was replaced with absl::optional Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202 * refactor: replace all usages of base::nullopt with absl::nullopt Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202 * chore: add missing base::Contains include Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202 * refactor: replace all usages of base::make_optional with absl::make_optional Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202 * refactor: replace WorldScriptContext() with GetScriptContextFromWorldId Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213 * chore: clean up left over opening namespace Refs: https://github.com/electron/electron/commit/95bfe6d08f65471394fb3005dbfa177cdf71210a * chore: add missing base::Contains include Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202 * refactor: replace GetCurrentDisplayIterator with the hard checker GetCurrentDisplay This code looks suspicious but if the iterator was invalid before it will also be invalid now. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191 * refactor: headers are now passed directly in extensions client Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906 * refactor: base::DictionaryValue::empty() has been removed Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424 * chore: add missing includes for network URLLoaderFactory Refs: unknown, probably a side effect of header changes * refactor: make convenience wrapper around AppendArg There is no converter FromV8 for base::StringPiece (apparently its not possible). So we now take in an std::string and use the construct for StringPiece to do implicit conversion. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544 * chore: add patch * chore: bump chromium in DEPS to 93.0.4525.0 * chore: update patches * refactor: CanResize has been de-virtualized Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774 * chore: update resource integrity patch * chore: add character encoding idl patch * chore: bump chromium in DEPS to 93.0.4526.0 * chore: update patches * chore: bump chromium in DEPS to 93.0.4527.0 * chore: bump chromium in DEPS to 93.0.4528.0 * chore: update patches * chore: update idl encoding patch * chore: bump chromium in DEPS to 93.0.4529.0 * chore: update patches * chore: bump chromium in DEPS to 93.0.4530.0 * chore: update patches * fix: only SetCanResize after the widget has been initialized * chore: add patch for vr on windows gn gen * spec: fix focus related tests on linux due to delay in focus swap * chore: remove new usages of base::Optional from main Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <sattard@slack-corp.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 08:05:04 +00:00
static absl::optional<bool> supports_gtk_file_chooser_native;
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
using dl_gtk_native_dialog_show_t = void (*)(void*);
using dl_gtk_native_dialog_destroy_t = void (*)(void*);
using dl_gtk_native_dialog_set_modal_t = void (*)(void*, gboolean);
using dl_gtk_native_dialog_run_t = int (*)(void*);
using dl_gtk_native_dialog_hide_t = void (*)(void*);
using dl_gtk_file_chooser_native_new_t = void* (*)(const char*,
GtkWindow*,
GtkFileChooserAction,
const char*,
const char*);
static dl_gtk_native_dialog_show_t dl_gtk_native_dialog_show;
static dl_gtk_native_dialog_destroy_t dl_gtk_native_dialog_destroy;
static dl_gtk_native_dialog_set_modal_t dl_gtk_native_dialog_set_modal;
static dl_gtk_native_dialog_run_t dl_gtk_native_dialog_run;
static dl_gtk_native_dialog_hide_t dl_gtk_native_dialog_hide;
static dl_gtk_file_chooser_native_new_t dl_gtk_file_chooser_native_new;
DialogSettings::DialogSettings() = default;
DialogSettings::DialogSettings(const DialogSettings&) = default;
DialogSettings::~DialogSettings() = default;
namespace {
static const int kPreviewWidth = 256;
static const int kPreviewHeight = 512;
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
void InitGtkFileChooserNativeSupport() {
// Return early if we have already setup the native functions or we have tried
// once before and failed. Avoid running expensive dynamic library operations.
if (supports_gtk_file_chooser_native) {
return;
}
// Mark that we have attempted to initialize support at least once
supports_gtk_file_chooser_native = false;
if (!g_module_supported()) {
return;
}
gtk_module = g_module_open("libgtk-3.so", G_MODULE_BIND_LAZY);
if (!gtk_module) {
return;
}
// Will never be unloaded
g_module_make_resident(gtk_module);
bool found = g_module_symbol(
gtk_module, "gtk_file_chooser_native_new",
reinterpret_cast<void**>(&dl_gtk_file_chooser_native_new));
if (!found) {
return;
}
found = g_module_symbol(
gtk_module, "gtk_native_dialog_set_modal",
reinterpret_cast<void**>(&dl_gtk_native_dialog_set_modal));
if (!found) {
return;
}
found =
g_module_symbol(gtk_module, "gtk_native_dialog_destroy",
reinterpret_cast<void**>(&dl_gtk_native_dialog_destroy));
if (!found) {
return;
}
found = g_module_symbol(gtk_module, "gtk_native_dialog_show",
reinterpret_cast<void**>(&dl_gtk_native_dialog_show));
if (!found) {
return;
}
2014-08-06 06:49:02 +00:00
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
found = g_module_symbol(gtk_module, "gtk_native_dialog_hide",
reinterpret_cast<void**>(&dl_gtk_native_dialog_hide));
if (!found) {
return;
}
found = g_module_symbol(gtk_module, "gtk_native_dialog_run",
reinterpret_cast<void**>(&dl_gtk_native_dialog_run));
if (!found) {
return;
}
supports_gtk_file_chooser_native =
dl_gtk_file_chooser_native_new && dl_gtk_native_dialog_set_modal &&
dl_gtk_native_dialog_destroy && dl_gtk_native_dialog_run &&
dl_gtk_native_dialog_show && dl_gtk_native_dialog_hide;
2014-08-06 06:49:02 +00:00
}
class FileChooserDialog {
public:
2018-02-15 21:20:55 +00:00
FileChooserDialog(GtkFileChooserAction action, const DialogSettings& settings)
: parent_(
static_cast<electron::NativeWindowViews*>(settings.parent_window)),
2017-02-08 01:32:58 +00:00
filters_(settings.filters) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
InitGtkFileChooserNativeSupport();
auto label = settings.button_label;
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
if (*supports_gtk_file_chooser_native) {
dialog_ = GTK_FILE_CHOOSER(dl_gtk_file_chooser_native_new(
settings.title.c_str(), NULL, action,
label.empty() ? nullptr : label.c_str(), nullptr));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
const char* confirm_text = gtk_util::GetOkLabel();
if (!label.empty())
confirm_text = label.c_str();
else if (action == GTK_FILE_CHOOSER_ACTION_SAVE)
confirm_text = gtk_util::GetSaveLabel();
else if (action == GTK_FILE_CHOOSER_ACTION_OPEN)
confirm_text = gtk_util::GetOpenLabel();
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_ = GTK_FILE_CHOOSER(gtk_file_chooser_dialog_new(
settings.title.c_str(), NULL, action, gtk_util::GetCancelLabel(),
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GTK_RESPONSE_CANCEL, confirm_text, GTK_RESPONSE_ACCEPT, NULL));
}
if (parent_) {
parent_->SetEnabled(false);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
if (*supports_gtk_file_chooser_native) {
dl_gtk_native_dialog_set_modal(static_cast<void*>(dialog_), TRUE);
} else {
gtk::SetGtkTransientForAura(GTK_WIDGET(dialog_),
parent_->GetNativeWindow());
gtk_window_set_modal(GTK_WINDOW(dialog_), TRUE);
}
}
2014-03-13 05:20:43 +00:00
if (action == GTK_FILE_CHOOSER_ACTION_SAVE)
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_do_overwrite_confirmation(dialog_, TRUE);
2014-03-13 05:27:01 +00:00
if (action != GTK_FILE_CHOOSER_ACTION_OPEN)
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_create_folders(dialog_, TRUE);
2014-03-13 05:20:43 +00:00
2017-02-08 01:32:58 +00:00
if (!settings.default_path.empty()) {
2021-04-06 06:54:58 +00:00
base::ThreadRestrictions::ScopedAllowIO allow_io;
2017-02-08 01:32:58 +00:00
if (base::DirectoryExists(settings.default_path)) {
2018-02-15 21:20:55 +00:00
gtk_file_chooser_set_current_folder(
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_, settings.default_path.value().c_str());
} else {
if (settings.default_path.IsAbsolute()) {
gtk_file_chooser_set_current_folder(
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_, settings.default_path.DirName().value().c_str());
}
2018-02-15 21:20:55 +00:00
gtk_file_chooser_set_current_name(
GTK_FILE_CHOOSER(dialog_),
2017-02-08 01:32:58 +00:00
settings.default_path.BaseName().value().c_str());
}
2014-03-13 05:10:13 +00:00
}
2014-08-06 06:49:02 +00:00
2017-02-08 01:32:58 +00:00
if (!settings.filters.empty())
AddFilters(settings.filters);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
// GtkFileChooserNative does not support preview widgets through the
// org.freedesktop.portal.FileChooser portal. In the case of running through
// the org.freedesktop.portal.FileChooser portal, anything having to do with
// the update-preview signal or the preview widget will just be ignored.
if (!*supports_gtk_file_chooser_native) {
preview_ = gtk_image_new();
g_signal_connect(dialog_, "update-preview",
G_CALLBACK(OnUpdatePreviewThunk), this);
gtk_file_chooser_set_preview_widget(dialog_, preview_);
}
}
~FileChooserDialog() {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
if (*supports_gtk_file_chooser_native) {
dl_gtk_native_dialog_destroy(static_cast<void*>(dialog_));
} else {
gtk_widget_destroy(GTK_WIDGET(dialog_));
}
if (parent_)
parent_->SetEnabled(true);
}
void SetupOpenProperties(int properties) {
const auto hasProp = [properties](OpenFileDialogProperty prop) {
return gboolean((properties & prop) != 0);
};
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
auto* file_chooser = dialog();
gtk_file_chooser_set_select_multiple(file_chooser,
hasProp(OPEN_DIALOG_MULTI_SELECTIONS));
gtk_file_chooser_set_show_hidden(file_chooser,
hasProp(OPEN_DIALOG_SHOW_HIDDEN_FILES));
}
void SetupSaveProperties(int properties) {
const auto hasProp = [properties](SaveFileDialogProperty prop) {
return gboolean((properties & prop) != 0);
};
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
auto* file_chooser = dialog();
gtk_file_chooser_set_show_hidden(file_chooser,
hasProp(SAVE_DIALOG_SHOW_HIDDEN_FILES));
gtk_file_chooser_set_do_overwrite_confirmation(
file_chooser, hasProp(SAVE_DIALOG_SHOW_OVERWRITE_CONFIRMATION));
}
2014-03-13 05:58:53 +00:00
void RunAsynchronous() {
2018-02-15 21:20:55 +00:00
g_signal_connect(dialog_, "response", G_CALLBACK(OnFileDialogResponseThunk),
this);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
if (*supports_gtk_file_chooser_native) {
dl_gtk_native_dialog_show(static_cast<void*>(dialog_));
} else {
gtk_widget_show_all(GTK_WIDGET(dialog_));
2020-10-20 18:24:52 +00:00
#if defined(USE_X11)
chore: bump chromium to 96.0.4647.0 (main) (#30814) * chore: bump chromium in DEPS to 95.0.4630.0 * 3133701: Fix chrome root store codegen for cross-compile builds. https://chromium-review.googlesource.com/c/chromium/src/+/3133701 * 49125: Include SHA512-256 in EVP_get_digestbyname and EVP_MD_do_all. https://boringssl-review.googlesource.com/c/boringssl/+/49125 * chore: fixup patch indices * 3131662: [Code Health] Remove ListValue::Append(Integer|Boolean) https://chromium-review.googlesource.com/c/chromium/src/+/3131662 * chore: bump chromium in DEPS to 95.0.4631.0 * chore: update patches * chore: bump chromium in DEPS to 95.0.4635.0 * chore: update patches * chore: bump chromium in DEPS to 95.0.4636.0 * chore: bump chromium in DEPS to 95.0.4637.0 * chore: update patches * refactor: move PlatformNotificationService into BrowserContext Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3137256 * refactor: ListValue::GetSize and ListValue::AppendString were removed Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3144540 * chore: bump chromium in DEPS to 95.0.4638.0 * chore: bump chromium in DEPS to 95.0.4638.4 * chore: bump chromium in DEPS to 96.0.4640.0 * chore: bump chromium in DEPS to 96.0.4641.0 * chore: bump chromium in DEPS to 96.0.4642.0 * chore: update patches Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org> * 3134756: Move extensions/browser/value_store to components/value_store. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3134756 * 3150092: [Autofill] Allow aligning Autofill suggestions to the field's center Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3150092 * chore: bump chromium in DEPS to 96.0.4643.0 * chore: update patches * chore: bump chromium in DEPS to 96.0.4644.0 * chore: update patches * chore: bump chromium in DEPS to 96.0.4645.0 * chore: update patches * chore: bump chromium in DEPS to 96.0.4646.0 * chore: bump chromium in DEPS to 96.0.4647.0 * chore: update patches Ref (for chromium): https://chromium-review.googlesource.com/c/chromium/src/+/3165772 * 3162087: Reland "Ensure Branch Target Identification is enabled for executable pages." Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3162087 * chore: update evert_add_inline_and_inline_origin_records_to_symbol_file.patch Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166678 Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166674 * chore: update Allocator construction Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3135195 Change RefCount::kAllowed/Disallowed semantics into BackupRefPtr::kEnabled/Disabled * chore: add UseConfigurablePool to v8::ArrayBuffer::Allocator invocation Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3090845 * chore: do not set network_context_params.context_name Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3155743 Remove name field from mojom::NetworkContext * fix: use ForEachRenderFrameHost to iterate frames. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3163336 New implementation partially cribbed from https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/script_executor.cc;drc=f894f106c6d5fac8e0b75158f622256e0f34f593;l=109 * [Blink Cleanup] Remove WebLocalFrame::RequestExecuteScriptAndReturnValue() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3149699 ExecuteJavaScript's RequestExecuteScript() new params are cribbed from https://chromium-review.googlesource.com/c/chromium/src/+/3149699/4/third_party/blink/renderer/core/frame/web_local_frame_impl.cc * Remove IsDescendantOf API on RenderFrameHost. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3165357 function is trivial to implement, so make a local copy in anon namespace * Rewrite IsDescendantOf check to check GetParentOrOuterDocument. https://chromium-review.googlesource.com/c/chromium/src/+/3160061 * Remove GetFramesInSubtree from RenderFrameHost https://chromium-review.googlesource.com/c/chromium/src/+/3163336 * fix: dump_syms for macOS * chore: update patches * [Code Health] Remove ListValue::AppendString and ListValue::GetSize https://chromium-review.googlesource.com/c/chromium/src/+/3144540 * fix: gn check https://chromium-review.googlesource.com/c/chromium/src/+/3163890 * fix: crash with Isolate::GetHeapCodeAndMetadataStatistics https://chromium-review.googlesource.com/c/v8/v8/+/3175820 * chore: update patches * chore: fix windows build * Add kPrintWithPostScriptType42Fonts feature. https://chromium-review.googlesource.com/c/chromium/src/+/3150776 * chore: update patches * chore: fix tests * ozone/x11: fix VA-API. https://chromium-review.googlesource.com/c/chromium/src/+/3141878 * Revert "ozone/x11: fix VA-API." This reverts commit 23e742acb1032bf4afc1a45e4bed38e42184fd01. * Reland "Make Ozone/X11 default." https://chromium-review.googlesource.com/c/chromium/src/+/3114071 * fixup Reland "Make Ozone/X11 default." * fixup Reland "Make Ozone/X11 default." for clipboard Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: VerteDinde <khammond@slack-corp.com> Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org> Co-authored-by: VerteDinde <keeleymhammond@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2021-10-06 02:21:00 +00:00
// We need to call gtk_window_present after making the widgets visible
// to make sure window gets correctly raised and gets focus.
x11::Time time = ui::X11EventSource::GetInstance()->GetTimestamp();
gtk_window_present_with_time(GTK_WINDOW(dialog_),
static_cast<uint32_t>(time));
2020-10-20 18:24:52 +00:00
#endif
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
}
}
void RunSaveAsynchronous(
gin_helper::Promise<gin_helper::Dictionary> promise) {
save_promise_ =
std::make_unique<gin_helper::Promise<gin_helper::Dictionary>>(
std::move(promise));
2014-03-13 05:58:53 +00:00
RunAsynchronous();
}
void RunOpenAsynchronous(
gin_helper::Promise<gin_helper::Dictionary> promise) {
open_promise_ =
std::make_unique<gin_helper::Promise<gin_helper::Dictionary>>(
std::move(promise));
2014-03-13 05:58:53 +00:00
RunAsynchronous();
}
base::FilePath GetFileName() const {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gchar* filename = gtk_file_chooser_get_filename(dialog_);
const base::FilePath path(filename);
g_free(filename);
return path;
}
2014-03-13 05:58:53 +00:00
std::vector<base::FilePath> GetFileNames() const {
std::vector<base::FilePath> paths;
auto* filenames = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog_));
for (auto* iter = filenames; iter != nullptr; iter = iter->next) {
auto* filename = static_cast<char*>(iter->data);
paths.emplace_back(filename);
g_free(filename);
2014-03-13 05:58:53 +00:00
}
g_slist_free(filenames);
return paths;
}
CHROMEG_CALLBACK_1(FileChooserDialog,
void,
OnFileDialogResponse,
GtkWidget*,
int);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GtkFileChooser* dialog() const { return dialog_; }
private:
2014-08-06 06:49:02 +00:00
void AddFilters(const Filters& filters);
electron::NativeWindowViews* parent_;
electron::UnresponsiveSuppressor unresponsive_suppressor_;
2015-07-07 07:45:13 +00:00
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GtkFileChooser* dialog_;
GtkWidget* preview_;
Filters filters_;
std::unique_ptr<gin_helper::Promise<gin_helper::Dictionary>> save_promise_;
std::unique_ptr<gin_helper::Promise<gin_helper::Dictionary>> open_promise_;
// Callback for when we update the preview for the selection.
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
CHROMEG_CALLBACK_0(FileChooserDialog, void, OnUpdatePreview, GtkFileChooser*);
DISALLOW_COPY_AND_ASSIGN(FileChooserDialog);
};
2014-03-13 05:58:53 +00:00
void FileChooserDialog::OnFileDialogResponse(GtkWidget* widget, int response) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
if (*supports_gtk_file_chooser_native) {
dl_gtk_native_dialog_hide(static_cast<void*>(dialog_));
} else {
gtk_widget_hide(GTK_WIDGET(dialog_));
}
v8::Isolate* isolate = electron::JavascriptEnvironment::GetIsolate();
v8::HandleScope scope(isolate);
if (save_promise_) {
gin_helper::Dictionary dict =
gin::Dictionary::CreateEmpty(save_promise_->isolate());
if (response == GTK_RESPONSE_ACCEPT) {
dict.Set("canceled", false);
dict.Set("filePath", GetFileName());
} else {
dict.Set("canceled", true);
dict.Set("filePath", base::FilePath());
}
save_promise_->Resolve(dict);
} else if (open_promise_) {
gin_helper::Dictionary dict =
gin::Dictionary::CreateEmpty(open_promise_->isolate());
if (response == GTK_RESPONSE_ACCEPT) {
dict.Set("canceled", false);
dict.Set("filePaths", GetFileNames());
} else {
dict.Set("canceled", true);
dict.Set("filePaths", std::vector<base::FilePath>());
}
open_promise_->Resolve(dict);
2014-03-13 05:58:53 +00:00
}
delete this;
}
2014-08-06 06:49:02 +00:00
void FileChooserDialog::AddFilters(const Filters& filters) {
for (const auto& filter : filters) {
2014-08-06 06:49:02 +00:00
GtkFileFilter* gtk_filter = gtk_file_filter_new();
for (const auto& extension : filter.second) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
// guarantee a pure lowercase variant
std::string file_extension = base::ToLowerASCII("*." + extension);
gtk_file_filter_add_pattern(gtk_filter, file_extension.c_str());
// guarantee a pure uppercase variant
file_extension = base::ToUpperASCII("*." + extension);
gtk_file_filter_add_pattern(gtk_filter, file_extension.c_str());
2014-08-06 06:49:02 +00:00
}
gtk_file_filter_set_name(gtk_filter, filter.first.c_str());
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_add_filter(dialog_, gtk_filter);
2014-08-06 06:49:02 +00:00
}
}
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
void FileChooserDialog::OnUpdatePreview(GtkFileChooser* chooser) {
CHECK(!*supports_gtk_file_chooser_native);
gchar* filename = gtk_file_chooser_get_preview_filename(chooser);
if (!filename) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, FALSE);
return;
}
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
// Don't attempt to open anything which isn't a regular file. If a named
// pipe, this may hang. See https://crbug.com/534754.
struct stat stat_buf;
if (stat(filename, &stat_buf) != 0 || !S_ISREG(stat_buf.st_mode)) {
g_free(filename);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, FALSE);
return;
}
// This will preserve the image's aspect ratio.
GdkPixbuf* pixbuf = gdk_pixbuf_new_from_file_at_size(filename, kPreviewWidth,
kPreviewHeight, nullptr);
g_free(filename);
if (pixbuf) {
gtk_image_set_from_pixbuf(GTK_IMAGE(preview_), pixbuf);
g_object_unref(pixbuf);
}
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, pixbuf ? TRUE : FALSE);
}
} // namespace
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
void ShowFileDialog(const FileChooserDialog& dialog) {
if (*supports_gtk_file_chooser_native) {
dl_gtk_native_dialog_show(static_cast<void*>(dialog.dialog()));
} else {
gtk_widget_show_all(GTK_WIDGET(dialog.dialog()));
}
}
int RunFileDialog(const FileChooserDialog& dialog) {
int response = 0;
if (*supports_gtk_file_chooser_native) {
response = dl_gtk_native_dialog_run(static_cast<void*>(dialog.dialog()));
} else {
response = gtk_dialog_run(GTK_DIALOG(dialog.dialog()));
}
return response;
}
bool ShowOpenDialogSync(const DialogSettings& settings,
std::vector<base::FilePath>* paths) {
GtkFileChooserAction action = GTK_FILE_CHOOSER_ACTION_OPEN;
if (settings.properties & OPEN_DIALOG_OPEN_DIRECTORY)
action = GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER;
2017-02-08 01:32:58 +00:00
FileChooserDialog open_dialog(action, settings);
open_dialog.SetupOpenProperties(settings.properties);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
ShowFileDialog(open_dialog);
const int response = RunFileDialog(open_dialog);
if (response == GTK_RESPONSE_ACCEPT) {
*paths = open_dialog.GetFileNames();
return true;
}
return false;
}
2017-02-08 01:32:58 +00:00
void ShowOpenDialog(const DialogSettings& settings,
gin_helper::Promise<gin_helper::Dictionary> promise) {
2014-03-13 05:58:53 +00:00
GtkFileChooserAction action = GTK_FILE_CHOOSER_ACTION_OPEN;
if (settings.properties & OPEN_DIALOG_OPEN_DIRECTORY)
2014-03-13 05:58:53 +00:00
action = GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER;
2017-02-08 01:32:58 +00:00
FileChooserDialog* open_dialog = new FileChooserDialog(action, settings);
open_dialog->SetupOpenProperties(settings.properties);
open_dialog->RunOpenAsynchronous(std::move(promise));
}
bool ShowSaveDialogSync(const DialogSettings& settings, base::FilePath* path) {
2017-02-08 01:32:58 +00:00
FileChooserDialog save_dialog(GTK_FILE_CHOOSER_ACTION_SAVE, settings);
save_dialog.SetupSaveProperties(settings.properties);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
ShowFileDialog(save_dialog);
const int response = RunFileDialog(save_dialog);
if (response == GTK_RESPONSE_ACCEPT) {
*path = save_dialog.GetFileName();
return true;
}
return false;
}
2017-02-08 01:32:58 +00:00
void ShowSaveDialog(const DialogSettings& settings,
gin_helper::Promise<gin_helper::Dictionary> promise) {
2018-02-15 21:20:55 +00:00
FileChooserDialog* save_dialog =
new FileChooserDialog(GTK_FILE_CHOOSER_ACTION_SAVE, settings);
save_dialog->RunSaveAsynchronous(std::move(promise));
}
} // namespace file_dialog