electron/shell/browser/ui/file_dialog_gtk.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

394 lines
13 KiB
C++
Raw Normal View History

// Copyright (c) 2014 GitHub, Inc.
2014-04-25 09:49:37 +00:00
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
#include <memory>
#include <string>
#include "base/callback.h"
#include "base/files/file_util.h"
2014-08-06 06:49:02 +00:00
#include "base/strings/string_util.h"
chore: bump chromium to 99.0.4767.0 (main) (#31986) * chore: bump chromium in DEPS to 98.0.4726.0 * 3292117: Remove unneeded base/compiler_specific.h includes in //chrome. https://chromium-review.googlesource.com/c/chromium/src/+/3292117 * 3289198: Enables calculating line, word and sentence boundaries on the browser https://chromium-review.googlesource.com/c/chromium/src/+/3289198 * 3276176: Remove expired gdi-text-printing flag and associated code. https://chromium-review.googlesource.com/c/chromium/src/+/3276176 * 3240963: content: allow embedder to prevent locking scheme registry https://chromium-review.googlesource.com/c/chromium/src/+/3240963 * 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree https://chromium-review.googlesource.com/c/chromium/src/+/3269899 * chore: fixup patch indices * 3276279: Enable -Wshadow by default for the "chromium code" config. https://chromium-review.googlesource.com/c/chromium/src/+/3276279 * 3279737: appcache: Remove WebPreference/WebSetting https://chromium-review.googlesource.com/c/chromium/src/+/3279737 * 3275564: [api] Advance API deprecation for APIs last marked in v9.6 https://chromium-review.googlesource.com/c/v8/v8/+/3275564 * 3261873: Clean up WebScriptSource constructors https://chromium-review.googlesource.com/c/chromium/src/+/3261873 * 3279346: appcache: Remove ConsoleMessage appcache field https://chromium-review.googlesource.com/c/chromium/src/+/3279346 * 3264212: Move legacy file loading to legacy_test_runner https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212 Both Persistence and UI have been removed from globals, but the issues they seemed to be patching are no longer reproducible from what I can tell, and so we can just delete these and re-evaluate if something surfaces. * 3290415: x11: remove the USE_X11 define. https://chromium-review.googlesource.com/c/chromium/src/+/3290415 * chore: bump Chromium to 98.0.4728.0 * 3179530: Defer system calls in PrintingContext for OOP printing https://chromium-review.googlesource.com/c/chromium/src/+/3179530 * 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn. https://chromium-review.googlesource.com/c/chromium/src/+/3299445 * chore: update patch indices * 3223975: Break PrintJobWorker OOP logic into separate class https://chromium-review.googlesource.com/c/chromium/src/+/3223975 * chore: bump chromium in DEPS to 98.0.4730.0 * 3279001: Remove support for font-family: -webkit-pictograph https://chromium-review.googlesource.com/c/chromium/src/+/3279001 * chore: fixup patch indices * chore: bump chromium in DEPS to 98.0.4732.0 * chore: update patches * chore: bump chromium in DEPS to 98.0.4734.0 * chore: bump chromium in DEPS to 98.0.4736.0 * chore: update patches * chore: update printing patch for miracle ptr * chore: add noexcept to fix clang error * chore: bump chromium in DEPS to 98.0.4738.0 * chore: update patches * chore: bump chromium in DEPS to 98.0.4740.0 * chore: bump chromium in DEPS to 98.0.4742.0 * chore: bump chromium in DEPS to 98.0.4744.0 * chore: bump chromium in DEPS to 98.0.4746.0 * chore: bump chromium in DEPS to 98.0.4748.0 * chore: bump chromium in DEPS to 98.0.4750.0 * chore: update patches * 3293841: Remove File Handling permissions code Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841 * chore: update patches 3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700 * 3289260: [CodeHealth]: Remove uses of Notification Service Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260 * 3301600: Disable scripted print in fenced frames Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600 * chore: add missing thread_restrictions headers * 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132 * fix: add ppapi_sandbox header for linux 3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700 * chore: manually bump chromium in DEPS to 98.0.4757.0 * chore: update patches * 3321044: Remove DictionaryValue::Clear() Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044 * chore: update printing.patch Refs: - 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556 - 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095 * build: add v8-embedder-state headers to GN patch * chore: bump chromium in DEPS to 99.0.4767.0 * chore: update patches * chore: rename CookiePartitionKeychain ...to CookiePartitionKeyCollection * chore: update video consumers * refactor: use newer base::Value API * 3232598: Convert net::DnsOverHttpsServerConfig into a class | https://chromium-review.googlesource.com/c/chromium/src/+/3232598 * 3327865: Remove the default WebContentsUserData ctor. | https://chromium-review.googlesource.com/c/chromium/src/+/3327865 * 3302814: DevTools: Add getPreference binding | https://chromium-review.googlesource.com/c/chromium/src/+/3302814 * 3301474: [tq][runtime] Use build flags for JS context promise hooks | https://chromium-review.googlesource.com/c/v8/v8/+/3301474 * oops 😵‍💫 * 3272411: Reland "base/allocator: Enable PartitionAlloc-Everywhere on macOS" | https://chromium-review.googlesource.com/c/chromium/src/+/3272411 build: turn PartitionAlloc back off on mac for now * fix: WCO method got renamed * 3344749: Revert "Stop using NSRunLoop in renderer process" https://chromium-review.googlesource.com/c/chromium/src/+/3344749 * 3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues. https://chromium-review.googlesource.com/c/chromium/src/+/3288746 * Revert "3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues." This reverts commit 5cc69f102e43ca72ac9ef45063711bcc7d849740. * chore: disable serial device enumerator sequence dcheck * fix: comment out line in DeviceService dtor * fixup! 3279001: Remove support for font-family: -webkit-pictograph * fixup! 3279346: appcache: Remove ConsoleMessage appcache field * chore: update patches after rebase Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> Co-authored-by: VerteDinde <khammond@slack-corp.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2022-01-10 22:31:39 +00:00
#include "base/threading/thread_restrictions.h"
#include "electron/electron_gtk_stubs.h"
#include "shell/browser/javascript_environment.h"
#include "shell/browser/native_window_views.h"
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
#include "shell/browser/ui/file_dialog.h"
#include "shell/browser/ui/gtk_util.h"
#include "shell/common/gin_converters/file_path_converter.h"
#include "ui/base/glib/glib_signal.h"
#include "ui/gtk/gtk_ui.h" // nogncheck
#include "ui/gtk/gtk_util.h" // nogncheck
namespace file_dialog {
DialogSettings::DialogSettings() = default;
DialogSettings::DialogSettings(const DialogSettings&) = default;
DialogSettings::~DialogSettings() = default;
namespace {
static const int kPreviewWidth = 256;
static const int kPreviewHeight = 512;
std::string MakeCaseInsensitivePattern(const std::string& extension) {
// If the extension is the "all files" extension, no change needed.
if (extension == "*")
return extension;
std::string pattern("*.");
for (std::size_t i = 0, n = extension.size(); i < n; i++) {
char ch = extension[i];
if (!base::IsAsciiAlpha(ch)) {
pattern.push_back(ch);
continue;
}
pattern.push_back('[');
pattern.push_back(base::ToLowerASCII(ch));
pattern.push_back(base::ToUpperASCII(ch));
pattern.push_back(']');
}
return pattern;
}
class FileChooserDialog {
public:
2018-02-15 21:20:55 +00:00
FileChooserDialog(GtkFileChooserAction action, const DialogSettings& settings)
2017-02-08 01:32:58 +00:00
: parent_(
static_cast<electron::NativeWindowViews*>(settings.parent_window)),
filters_(settings.filters) {
auto label = settings.button_label;
if (electron::IsElectron_gtkInitialized()) {
dialog_ = GTK_FILE_CHOOSER(gtk_file_chooser_native_new(
settings.title.c_str(), NULL, action,
label.empty() ? nullptr : label.c_str(), nullptr));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
const char* confirm_text = gtk_util::GetOkLabel();
if (!label.empty())
confirm_text = label.c_str();
else if (action == GTK_FILE_CHOOSER_ACTION_SAVE)
confirm_text = gtk_util::GetSaveLabel();
else if (action == GTK_FILE_CHOOSER_ACTION_OPEN)
confirm_text = gtk_util::GetOpenLabel();
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_ = GTK_FILE_CHOOSER(gtk_file_chooser_dialog_new(
settings.title.c_str(), NULL, action, gtk_util::GetCancelLabel(),
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GTK_RESPONSE_CANCEL, confirm_text, GTK_RESPONSE_ACCEPT, NULL));
}
if (parent_) {
parent_->SetEnabled(false);
if (electron::IsElectron_gtkInitialized()) {
gtk_native_dialog_set_modal(GTK_NATIVE_DIALOG(dialog_), TRUE);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
gtk::SetGtkTransientForAura(GTK_WIDGET(dialog_),
parent_->GetNativeWindow());
gtk_window_set_modal(GTK_WINDOW(dialog_), TRUE);
}
}
2014-03-13 05:20:43 +00:00
if (action == GTK_FILE_CHOOSER_ACTION_SAVE)
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_do_overwrite_confirmation(dialog_, TRUE);
2014-03-13 05:27:01 +00:00
if (action != GTK_FILE_CHOOSER_ACTION_OPEN)
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_create_folders(dialog_, TRUE);
2014-03-13 05:20:43 +00:00
2017-02-08 01:32:58 +00:00
if (!settings.default_path.empty()) {
2021-04-06 06:54:58 +00:00
base::ThreadRestrictions::ScopedAllowIO allow_io;
2017-02-08 01:32:58 +00:00
if (base::DirectoryExists(settings.default_path)) {
2018-02-15 21:20:55 +00:00
gtk_file_chooser_set_current_folder(
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_, settings.default_path.value().c_str());
} else {
if (settings.default_path.IsAbsolute()) {
gtk_file_chooser_set_current_folder(
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
dialog_, settings.default_path.DirName().value().c_str());
}
2018-02-15 21:20:55 +00:00
gtk_file_chooser_set_current_name(
GTK_FILE_CHOOSER(dialog_),
2017-02-08 01:32:58 +00:00
settings.default_path.BaseName().value().c_str());
}
2014-03-13 05:10:13 +00:00
}
2014-08-06 06:49:02 +00:00
2017-02-08 01:32:58 +00:00
if (!settings.filters.empty())
AddFilters(settings.filters);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
// GtkFileChooserNative does not support preview widgets through the
// org.freedesktop.portal.FileChooser portal. In the case of running through
// the org.freedesktop.portal.FileChooser portal, anything having to do with
// the update-preview signal or the preview widget will just be ignored.
if (!electron::IsElectron_gtkInitialized()) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
preview_ = gtk_image_new();
g_signal_connect(dialog_, "update-preview",
G_CALLBACK(OnUpdatePreviewThunk), this);
gtk_file_chooser_set_preview_widget(dialog_, preview_);
}
}
~FileChooserDialog() {
if (electron::IsElectron_gtkInitialized()) {
gtk_native_dialog_destroy(GTK_NATIVE_DIALOG(dialog_));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
gtk_widget_destroy(GTK_WIDGET(dialog_));
}
if (parent_)
parent_->SetEnabled(true);
}
// disable copy
FileChooserDialog(const FileChooserDialog&) = delete;
FileChooserDialog& operator=(const FileChooserDialog&) = delete;
void SetupOpenProperties(int properties) {
const auto hasProp = [properties](OpenFileDialogProperty prop) {
return gboolean((properties & prop) != 0);
};
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
auto* file_chooser = dialog();
gtk_file_chooser_set_select_multiple(file_chooser,
hasProp(OPEN_DIALOG_MULTI_SELECTIONS));
gtk_file_chooser_set_show_hidden(file_chooser,
hasProp(OPEN_DIALOG_SHOW_HIDDEN_FILES));
}
void SetupSaveProperties(int properties) {
const auto hasProp = [properties](SaveFileDialogProperty prop) {
return gboolean((properties & prop) != 0);
};
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
auto* file_chooser = dialog();
gtk_file_chooser_set_show_hidden(file_chooser,
hasProp(SAVE_DIALOG_SHOW_HIDDEN_FILES));
gtk_file_chooser_set_do_overwrite_confirmation(
file_chooser, hasProp(SAVE_DIALOG_SHOW_OVERWRITE_CONFIRMATION));
}
2014-03-13 05:58:53 +00:00
void RunAsynchronous() {
2018-02-15 21:20:55 +00:00
g_signal_connect(dialog_, "response", G_CALLBACK(OnFileDialogResponseThunk),
this);
if (electron::IsElectron_gtkInitialized()) {
gtk_native_dialog_show(GTK_NATIVE_DIALOG(dialog_));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
gtk_widget_show_all(GTK_WIDGET(dialog_));
gtk::GtkUi::GetPlatform()->ShowGtkWindow(GTK_WINDOW(dialog_));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
}
}
void RunSaveAsynchronous(
gin_helper::Promise<gin_helper::Dictionary> promise) {
save_promise_ =
std::make_unique<gin_helper::Promise<gin_helper::Dictionary>>(
std::move(promise));
2014-03-13 05:58:53 +00:00
RunAsynchronous();
}
void RunOpenAsynchronous(
gin_helper::Promise<gin_helper::Dictionary> promise) {
open_promise_ =
std::make_unique<gin_helper::Promise<gin_helper::Dictionary>>(
std::move(promise));
2014-03-13 05:58:53 +00:00
RunAsynchronous();
}
base::FilePath GetFileName() const {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gchar* filename = gtk_file_chooser_get_filename(dialog_);
const base::FilePath path(filename);
g_free(filename);
return path;
}
2014-03-13 05:58:53 +00:00
std::vector<base::FilePath> GetFileNames() const {
std::vector<base::FilePath> paths;
auto* filenames = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog_));
for (auto* iter = filenames; iter != nullptr; iter = iter->next) {
auto* filename = static_cast<char*>(iter->data);
paths.emplace_back(filename);
g_free(filename);
2014-03-13 05:58:53 +00:00
}
g_slist_free(filenames);
return paths;
}
CHROMEG_CALLBACK_1(FileChooserDialog,
void,
OnFileDialogResponse,
GtkWidget*,
int);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GtkFileChooser* dialog() const { return dialog_; }
private:
2014-08-06 06:49:02 +00:00
void AddFilters(const Filters& filters);
electron::NativeWindowViews* parent_;
2015-07-07 07:45:13 +00:00
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
GtkFileChooser* dialog_;
GtkWidget* preview_;
Filters filters_;
std::unique_ptr<gin_helper::Promise<gin_helper::Dictionary>> save_promise_;
std::unique_ptr<gin_helper::Promise<gin_helper::Dictionary>> open_promise_;
// Callback for when we update the preview for the selection.
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
CHROMEG_CALLBACK_0(FileChooserDialog, void, OnUpdatePreview, GtkFileChooser*);
};
2014-03-13 05:58:53 +00:00
void FileChooserDialog::OnFileDialogResponse(GtkWidget* widget, int response) {
if (electron::IsElectron_gtkInitialized()) {
gtk_native_dialog_hide(GTK_NATIVE_DIALOG(dialog_));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
gtk_widget_hide(GTK_WIDGET(dialog_));
}
v8::Isolate* isolate = electron::JavascriptEnvironment::GetIsolate();
v8::HandleScope scope(isolate);
if (save_promise_) {
gin_helper::Dictionary dict =
gin::Dictionary::CreateEmpty(save_promise_->isolate());
if (response == GTK_RESPONSE_ACCEPT) {
dict.Set("canceled", false);
dict.Set("filePath", GetFileName());
} else {
dict.Set("canceled", true);
dict.Set("filePath", base::FilePath());
}
save_promise_->Resolve(dict);
} else if (open_promise_) {
gin_helper::Dictionary dict =
gin::Dictionary::CreateEmpty(open_promise_->isolate());
if (response == GTK_RESPONSE_ACCEPT) {
dict.Set("canceled", false);
dict.Set("filePaths", GetFileNames());
} else {
dict.Set("canceled", true);
dict.Set("filePaths", std::vector<base::FilePath>());
}
open_promise_->Resolve(dict);
2014-03-13 05:58:53 +00:00
}
delete this;
}
2014-08-06 06:49:02 +00:00
void FileChooserDialog::AddFilters(const Filters& filters) {
for (const auto& filter : filters) {
2014-08-06 06:49:02 +00:00
GtkFileFilter* gtk_filter = gtk_file_filter_new();
for (const auto& extension : filter.second) {
std::string pattern = MakeCaseInsensitivePattern(extension);
gtk_file_filter_add_pattern(gtk_filter, pattern.c_str());
2014-08-06 06:49:02 +00:00
}
gtk_file_filter_set_name(gtk_filter, filter.first.c_str());
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_add_filter(dialog_, gtk_filter);
2014-08-06 06:49:02 +00:00
}
}
bool CanPreview(const struct stat& st) {
// Only preview regular files; pipes may hang.
// See https://crbug.com/534754.
if (!S_ISREG(st.st_mode)) {
return false;
}
// Don't preview huge files; they may crash.
// https://github.com/electron/electron/issues/31630
// Setting an arbitrary filesize max t at 100 MB here.
constexpr off_t ArbitraryMax = 100000000ULL;
return st.st_size < ArbitraryMax;
}
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
void FileChooserDialog::OnUpdatePreview(GtkFileChooser* chooser) {
CHECK(!electron::IsElectron_gtkInitialized());
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gchar* filename = gtk_file_chooser_get_preview_filename(chooser);
if (!filename) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, FALSE);
return;
}
struct stat sb;
if (stat(filename, &sb) != 0 || !CanPreview(sb)) {
g_free(filename);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, FALSE);
return;
}
// This will preserve the image's aspect ratio.
GdkPixbuf* pixbuf = gdk_pixbuf_new_from_file_at_size(filename, kPreviewWidth,
kPreviewHeight, nullptr);
g_free(filename);
if (pixbuf) {
gtk_image_set_from_pixbuf(GTK_IMAGE(preview_), pixbuf);
g_object_unref(pixbuf);
}
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_file_chooser_set_preview_widget_active(chooser, pixbuf ? TRUE : FALSE);
}
} // namespace
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
void ShowFileDialog(const FileChooserDialog& dialog) {
// gtk_native_dialog_run() will call gtk_native_dialog_show() for us.
if (!electron::IsElectron_gtkInitialized()) {
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
gtk_widget_show_all(GTK_WIDGET(dialog.dialog()));
}
}
int RunFileDialog(const FileChooserDialog& dialog) {
int response = 0;
if (electron::IsElectron_gtkInitialized()) {
response = gtk_native_dialog_run(GTK_NATIVE_DIALOG(dialog.dialog()));
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
} else {
response = gtk_dialog_run(GTK_DIALOG(dialog.dialog()));
}
return response;
}
bool ShowOpenDialogSync(const DialogSettings& settings,
std::vector<base::FilePath>* paths) {
GtkFileChooserAction action = GTK_FILE_CHOOSER_ACTION_OPEN;
if (settings.properties & OPEN_DIALOG_OPEN_DIRECTORY)
action = GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER;
2017-02-08 01:32:58 +00:00
FileChooserDialog open_dialog(action, settings);
open_dialog.SetupOpenProperties(settings.properties);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
ShowFileDialog(open_dialog);
const int response = RunFileDialog(open_dialog);
if (response == GTK_RESPONSE_ACCEPT) {
*paths = open_dialog.GetFileNames();
return true;
}
return false;
}
2017-02-08 01:32:58 +00:00
void ShowOpenDialog(const DialogSettings& settings,
gin_helper::Promise<gin_helper::Dictionary> promise) {
2014-03-13 05:58:53 +00:00
GtkFileChooserAction action = GTK_FILE_CHOOSER_ACTION_OPEN;
if (settings.properties & OPEN_DIALOG_OPEN_DIRECTORY)
2014-03-13 05:58:53 +00:00
action = GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER;
2017-02-08 01:32:58 +00:00
FileChooserDialog* open_dialog = new FileChooserDialog(action, settings);
open_dialog->SetupOpenProperties(settings.properties);
open_dialog->RunOpenAsynchronous(std::move(promise));
}
bool ShowSaveDialogSync(const DialogSettings& settings, base::FilePath* path) {
2017-02-08 01:32:58 +00:00
FileChooserDialog save_dialog(GTK_FILE_CHOOSER_ACTION_SAVE, settings);
save_dialog.SetupSaveProperties(settings.properties);
feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification (#19159) * feat: Use GtkFileChooserNative if available to support XDG portals With this commit, users on KDE/plasma will finally have support in Electron for their native file choosers dialogs. * fix: namespace * fix: labels were reversed * fix: lint issue * fix: clean up some implementation * fix: remove deprecation branch * fix: remove unused header * fix: remove unused gi18n.h include Not sure why this is * fix: add the set_data call into the mirrored SetGtkTransientForAura func * fix: remove gmodule support and use native for the dialog regardless * fix: undo yarn.lock changes * fix: lint * fix: remove x11 unncessary x11 include * fix: lint * fix: remove SetGtkTransientForAura * Revert "fix: remove gmodule support and use native for the dialog regardless" This reverts commit 062db5951e59cf99fcce566ab8ebab7ddc031aeb. * fix: add support in a backwards compatible way Use GModule to dynamically load functions from libgtk in order to support GtkNativeDialog. * fix: lint * docs: update comment * Revert "fix: remove x11 unncessary x11 include" This reverts commit 589cff583add458c25ca5a2202232fdff916c673. * fix: compiler errors * fix: int -> x11::time * fix: move GtkNativeDialog static data to global state * fix: revert yarn.lock change * update: for code review comments * fix: remove functional header * fix: variable name * fix: rename GTK native initalization func * Help out the compiler * Help out the compiler * Help out the compiler * Fix function signature * Remove unused header * Rename optional boolean for GtkFileChooserNative support * Add back in USE_X11 check * Satisfy linter * Resatisfy linter * Fix alignment of if * Fix alignment of arguments * linting... * fix: add back in the i18n hack * fix: lint * Respond to some review comments * fix: lint * Make adding filter agnostic * fix: transform is in place * fix: remove std::transform because not c++17 * Remove unused include * fix: address Cheng's review * fix: Remove unused header
2021-04-01 23:29:27 +00:00
ShowFileDialog(save_dialog);
const int response = RunFileDialog(save_dialog);
if (response == GTK_RESPONSE_ACCEPT) {
*path = save_dialog.GetFileName();
return true;
}
return false;
}
2017-02-08 01:32:58 +00:00
void ShowSaveDialog(const DialogSettings& settings,
gin_helper::Promise<gin_helper::Dictionary> promise) {
2018-02-15 21:20:55 +00:00
FileChooserDialog* save_dialog =
new FileChooserDialog(GTK_FILE_CHOOSER_ACTION_SAVE, settings);
save_dialog->RunSaveAsynchronous(std::move(promise));
}
} // namespace file_dialog