2016-05-06 10:23:18 +00:00
|
|
|
|
# Security, Native Capabilities, and Your Responsibility
|
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
As web developers, we usually enjoy the strong security net of the browser -
|
|
|
|
|
the risks associated with the code we write are relatively small. Our websites
|
|
|
|
|
are granted limited powers in a sandbox, and we trust that our users enjoy a
|
|
|
|
|
browser built by a large team of engineers that is able to quickly respond to
|
|
|
|
|
newly discovered security threats.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2016-05-08 18:21:11 +00:00
|
|
|
|
When working with Electron, it is important to understand that Electron is not
|
|
|
|
|
a web browser. It allows you to build feature-rich desktop applications with
|
|
|
|
|
familiar web technologies, but your code wields much greater power. JavaScript
|
2016-06-01 05:36:45 +00:00
|
|
|
|
can access the filesystem, user shell, and more. This allows you to build
|
2018-01-29 19:19:43 +00:00
|
|
|
|
high quality native applications, but the inherent security risks scale with
|
|
|
|
|
the additional powers granted to your code.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
With that in mind, be aware that displaying arbitrary content from untrusted
|
2016-05-08 18:21:11 +00:00
|
|
|
|
sources poses a severe security risk that Electron is not intended to handle.
|
2016-05-10 08:41:16 +00:00
|
|
|
|
In fact, the most popular Electron apps (Atom, Slack, Visual Studio Code, etc)
|
|
|
|
|
display primarily local content (or trusted, secure remote content without Node
|
|
|
|
|
integration) – if your application executes code from an online source, it is
|
|
|
|
|
your responsibility to ensure that the code is not malicious.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2017-01-30 18:57:53 +00:00
|
|
|
|
## Reporting Security Issues
|
2017-01-30 18:49:17 +00:00
|
|
|
|
|
|
|
|
|
For information on how to properly disclose an Electron vulnerability,
|
|
|
|
|
see [SECURITY.md](https://github.com/electron/electron/tree/master/SECURITY.md)
|
|
|
|
|
|
2016-05-06 10:23:18 +00:00
|
|
|
|
## Chromium Security Issues and Upgrades
|
|
|
|
|
|
2016-05-10 08:41:16 +00:00
|
|
|
|
While Electron strives to support new versions of Chromium as soon as possible,
|
|
|
|
|
developers should be aware that upgrading is a serious undertaking - involving
|
|
|
|
|
hand-editing dozens or even hundreds of files. Given the resources and
|
|
|
|
|
contributions available today, Electron will often not be on the very latest
|
|
|
|
|
version of Chromium, lagging behind by either days or weeks.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2016-05-10 08:41:16 +00:00
|
|
|
|
We feel that our current system of updating the Chromium component strikes an
|
2018-01-29 19:19:43 +00:00
|
|
|
|
appropriate balance between the resources we have available and the needs of
|
|
|
|
|
the majority of applications built on top of the framework. We definitely are
|
2016-05-10 08:41:16 +00:00
|
|
|
|
interested in hearing more about specific use cases from the people that build
|
|
|
|
|
things on top of Electron. Pull requests and contributions supporting this
|
|
|
|
|
effort are always very welcome.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
|
|
|
|
## Ignoring Above Advice
|
2016-09-08 17:39:29 +00:00
|
|
|
|
|
2016-05-10 08:41:16 +00:00
|
|
|
|
A security issue exists whenever you receive code from a remote destination and
|
|
|
|
|
execute it locally. As an example, consider a remote website being displayed
|
2018-02-01 17:58:02 +00:00
|
|
|
|
inside a [`BrowserWindow`][browser-window]. If an attacker somehow manages to
|
2018-01-29 20:34:46 +00:00
|
|
|
|
change said content (either by attacking the source directly, or by sitting
|
|
|
|
|
between your app and the actual destination), they will be able to execute
|
|
|
|
|
native code on the user's machine.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2016-05-10 08:41:16 +00:00
|
|
|
|
> :warning: Under no circumstances should you load and execute remote code with
|
2018-01-29 19:19:43 +00:00
|
|
|
|
Node.js integration enabled. Instead, use only local files (packaged together
|
|
|
|
|
with your application) to execute Node.js code. To display remote content, use
|
2018-06-21 17:06:54 +00:00
|
|
|
|
the [`<webview>`][webview-tag] tag and make sure to disable the `nodeIntegration`.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2018-02-03 14:50:12 +00:00
|
|
|
|
## Electron Security Warnings
|
2016-09-08 17:39:29 +00:00
|
|
|
|
|
2018-02-03 14:50:12 +00:00
|
|
|
|
From Electron 2.0 on, developers will see warnings and recommendations printed
|
2018-02-25 15:11:18 +00:00
|
|
|
|
to the developer console. They only show up when the binary's name is Electron,
|
2018-02-03 14:50:12 +00:00
|
|
|
|
indicating that a developer is currently looking at the console.
|
|
|
|
|
|
|
|
|
|
You can force-enable or force-disable these warnings by setting
|
|
|
|
|
`ELECTRON_ENABLE_SECURITY_WARNINGS` or `ELECTRON_DISABLE_SECURITY_WARNINGS` on
|
|
|
|
|
either `process.env` or the `window` object.
|
|
|
|
|
|
|
|
|
|
## Checklist: Security Recommendations
|
|
|
|
|
|
|
|
|
|
This is not bulletproof, but at the least, you should follow these steps to
|
|
|
|
|
improve the security of your application.
|
2016-05-06 10:23:18 +00:00
|
|
|
|
|
2018-05-02 15:33:07 +00:00
|
|
|
|
1. [Only load secure content](#1-only-load-secure-content)
|
2018-05-03 02:51:37 +00:00
|
|
|
|
2. [Disable the Node.js integration in all renderers that display remote content](#2-disable-nodejs-integration-for-remote-content)
|
|
|
|
|
3. [Enable context isolation in all renderers that display remote content](#3-enable-context-isolation-for-remote-content)
|
|
|
|
|
4. [Use `ses.setPermissionRequestHandler()` in all sessions that load remote content](#4-handle-session-permission-requests-from-remote-content)
|
|
|
|
|
5. [Do not disable `webSecurity`](#5-do-not-disable-websecurity)
|
|
|
|
|
6. [Define a `Content-Security-Policy`](#6-define-a-content-security-policy) and use restrictive rules (i.e. `script-src 'self'`)
|
|
|
|
|
7. [Override and disable `eval`](#7-override-and-disable-eval), which allows strings to be executed as code.
|
|
|
|
|
8. [Do not set `allowRunningInsecureContent` to `true`](#8-do-not-set-allowrunninginsecurecontent-to-true)
|
|
|
|
|
9. [Do not enable experimental features](#9-do-not-enable-experimental-features)
|
2018-05-23 21:01:34 +00:00
|
|
|
|
10. [Do not use `enableBlinkFeatures`](#10-do-not-use-enableblinkfeatures)
|
2018-06-21 17:06:54 +00:00
|
|
|
|
11. [`<webview>`: Do not use `allowpopups`](#11-do-not-use-allowpopups)
|
|
|
|
|
12. [`<webview>`: Verify options and params](#12-verify-webview-options-before-creation)
|
2016-05-10 08:41:16 +00:00
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 1) Only Load Secure Content
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
|
|
|
|
Any resources not included with your application should be loaded using a
|
2018-01-29 20:34:46 +00:00
|
|
|
|
secure protocol like `HTTPS`. In other words, do not use insecure protocols
|
2018-02-13 05:18:27 +00:00
|
|
|
|
like `HTTP`. Similarly, we recommend the use of `WSS` over `WS`, `FTPS` over
|
2018-01-30 00:01:05 +00:00
|
|
|
|
`FTP`, and so on.
|
2018-01-29 00:55:11 +00:00
|
|
|
|
|
2018-01-29 01:25:05 +00:00
|
|
|
|
### Why?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-29 00:55:11 +00:00
|
|
|
|
`HTTPS` has three main benefits:
|
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
1) It authenticates the remote server, ensuring your app connects to the correct
|
|
|
|
|
host instead of an impersonator.
|
2018-01-29 01:25:05 +00:00
|
|
|
|
2) It ensures data integrity, asserting that the data was not modified while in
|
|
|
|
|
transit between your application and the host.
|
2018-01-30 00:01:05 +00:00
|
|
|
|
3) It encrypts the traffic between your user and the destination host, making it
|
|
|
|
|
more difficult to eavesdrop on the information sent between your app and
|
2018-01-29 01:25:05 +00:00
|
|
|
|
the host.
|
|
|
|
|
|
|
|
|
|
### How?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-29 00:55:11 +00:00
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
browserWindow.loadURL('http://my-website.com')
|
|
|
|
|
|
|
|
|
|
// Good
|
|
|
|
|
browserWindow.loadURL('https://my-website.com')
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
```html
|
|
|
|
|
<!-- Bad -->
|
|
|
|
|
<script crossorigin src="http://cdn.com/react.js"></script>
|
|
|
|
|
<link rel="stylesheet" href="http://cdn.com/style.css">
|
|
|
|
|
|
|
|
|
|
<!-- Good -->
|
|
|
|
|
<script crossorigin src="https://cdn.com/react.js"></script>
|
|
|
|
|
<link rel="stylesheet" href="https://cdn.com/style.css">
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 2) Disable Node.js Integration for Remote Content
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
It is paramount that you disable Node.js integration in any renderer
|
2018-02-01 17:58:02 +00:00
|
|
|
|
([`BrowserWindow`][browser-window], [`BrowserView`][browser-view], or
|
2018-06-21 17:06:54 +00:00
|
|
|
|
[`<webview>`][webview-tag]) that loads remote content. The goal is to limit the
|
2018-01-30 00:01:05 +00:00
|
|
|
|
powers you grant to remote content, thus making it dramatically more difficult
|
|
|
|
|
for an attacker to harm your users should they gain the ability to execute
|
|
|
|
|
JavaScript on your website.
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
After this, you can grant additional permissions for specific hosts. For example,
|
|
|
|
|
if you are opening a BrowserWindow pointed at `https://my-website.com/", you can
|
|
|
|
|
give that website exactly the abilities it needs, but no more.
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
|
|
|
|
### Why?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
A cross-site-scripting (XSS) attack is more dangerous if an attacker can jump
|
|
|
|
|
out of the renderer process and execute code on the user's computer.
|
|
|
|
|
Cross-site-scripting attacks are fairly common - and while an issue, their
|
|
|
|
|
power is usually limited to messing with the website that they are executed on.
|
|
|
|
|
Disabling Node.js integration helps prevent an XSS from being escalated into a
|
|
|
|
|
so-called "Remote Code Execution" (RCE) attack.
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
|
|
|
|
### How?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-29 01:25:05 +00:00
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
const mainWindow = new BrowserWindow()
|
|
|
|
|
mainWindow.loadURL('https://my-website.com')
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```js
|
2018-01-29 01:25:05 +00:00
|
|
|
|
// Good
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
|
|
|
|
nodeIntegration: false,
|
|
|
|
|
preload: './preload.js'
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
mainWindow.loadURL('https://my-website.com')
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
```html
|
|
|
|
|
<!-- Bad -->
|
|
|
|
|
<webview nodeIntegration src="page.html"></webview>
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
<!-- Good -->
|
|
|
|
|
<webview src="page.html"></webview>
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
When disabling Node.js integration, you can still expose APIs to your website that
|
2018-01-29 19:19:43 +00:00
|
|
|
|
do consume Node.js modules or features. Preload scripts continue to have access
|
|
|
|
|
to `require` and other Node.js features, allowing developers to expose a custom
|
|
|
|
|
API to remotely loaded content.
|
|
|
|
|
|
|
|
|
|
In the following example preload script, the later loaded website will have
|
|
|
|
|
access to a `window.readConfig()` method, but no Node.js features.
|
2018-01-29 01:25:05 +00:00
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
const { readFileSync } = require('fs')
|
|
|
|
|
|
|
|
|
|
window.readConfig = function () {
|
|
|
|
|
const data = readFileSync('./config.json')
|
2018-01-29 20:36:51 +00:00
|
|
|
|
return data
|
2018-01-29 01:25:05 +00:00
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:19:21 +00:00
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 3) Enable Context Isolation for Remote Content
|
2018-01-29 19:01:22 +00:00
|
|
|
|
|
2018-01-29 19:19:21 +00:00
|
|
|
|
Context isolation is an Electron feature that allows developers to run code
|
|
|
|
|
in preload scripts and in Electron APIs in a dedicated JavaScript context. In
|
|
|
|
|
practice, that means that global objects like `Array.prototype.push` or
|
|
|
|
|
`JSON.parse` cannot be modified by scripts running in the renderer process.
|
|
|
|
|
|
|
|
|
|
Electron uses the same technology as Chromium's [Content Scripts](https://developer.chrome.com/extensions/content_scripts#execution-environment)
|
|
|
|
|
to enable this behavior.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
Context isolation allows each the scripts on running in the renderer to make
|
|
|
|
|
changes to its JavaScript environment without worrying about conflicting with
|
|
|
|
|
the scripts in the Electron API or the preload script.
|
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
While still an experimental Electron feature, context isolation adds an
|
|
|
|
|
additional layer of security. It creates a new JavaScript world for Electron
|
|
|
|
|
APIs and preload scripts.
|
|
|
|
|
|
|
|
|
|
At the same time, preload scripts still have access to the `document` and
|
|
|
|
|
`window` objects. In other words, you're getting a decent return on a likely
|
|
|
|
|
very small investment.
|
2018-01-29 19:19:21 +00:00
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
// Main process
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
|
|
|
|
contextIsolation: true,
|
|
|
|
|
preload: 'preload.js'
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
// Preload script
|
|
|
|
|
|
|
|
|
|
// Set a variable in the page before it loads
|
|
|
|
|
webFrame.executeJavaScript('window.foo = "foo";')
|
|
|
|
|
|
|
|
|
|
// The loaded page will not be able to access this, it is only available
|
|
|
|
|
// in this context
|
|
|
|
|
window.bar = 'bar'
|
|
|
|
|
|
|
|
|
|
document.addEventListener('DOMContentLoaded', () => {
|
|
|
|
|
// Will log out 'undefined' since window.foo is only available in the main
|
|
|
|
|
// context
|
|
|
|
|
console.log(window.foo)
|
|
|
|
|
|
|
|
|
|
// Will log out 'bar' since window.bar is available in this context
|
|
|
|
|
console.log(window.bar)
|
|
|
|
|
})
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 4) Handle Session Permission Requests From Remote Content
|
2018-01-29 19:01:22 +00:00
|
|
|
|
|
|
|
|
|
You may have seen permission requests while using Chrome: They pop up whenever
|
|
|
|
|
the website attempts to use a feature that the user has to manually approve (
|
|
|
|
|
like notifications).
|
|
|
|
|
|
|
|
|
|
The API is based on the [Chromium permissions API](https://developer.chrome.com/extensions/permissions)
|
|
|
|
|
and implements the same types of permissions.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
By default, Electron will automatically approve all permission requests unless
|
|
|
|
|
the developer has manually configured a custom handler. While a solid default,
|
|
|
|
|
security-conscious developers might want to assume the very opposite.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
const { session } = require('electron')
|
|
|
|
|
|
|
|
|
|
session
|
|
|
|
|
.fromPartition('some-partition')
|
|
|
|
|
.setPermissionRequestHandler((webContents, permission, callback) => {
|
|
|
|
|
const url = webContents.getURL()
|
|
|
|
|
|
|
|
|
|
if (permission === 'notifications') {
|
|
|
|
|
// Approves the permissions request
|
|
|
|
|
callback(true)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!url.startsWith('https://my-website.com')) {
|
|
|
|
|
// Denies the permissions request
|
|
|
|
|
return callback(false)
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 5) Do Not Disable WebSecurity
|
|
|
|
|
|
|
|
|
|
_Recommendation is Electron's default_
|
|
|
|
|
|
|
|
|
|
You may have already guessed that disabling the `webSecurity` property on a
|
|
|
|
|
renderer process ([`BrowserWindow`][browser-window],
|
2018-06-21 17:06:54 +00:00
|
|
|
|
[`BrowserView`][browser-view], or [`<webview>`][webview-tag]) disables crucial
|
2018-02-01 17:58:02 +00:00
|
|
|
|
security features.
|
|
|
|
|
|
|
|
|
|
Do not disable `webSecurity` in production applications.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
Disabling `webSecurity` will disable the same-origin policy and set
|
|
|
|
|
`allowRunningInsecureContent` property to `true`. In other words, it allows
|
|
|
|
|
the execution of insecure code from different domains.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
|
|
|
|
webSecurity: false
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
// Good
|
|
|
|
|
const mainWindow = new BrowserWindow()
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
```html
|
|
|
|
|
<!-- Bad -->
|
|
|
|
|
<webview disablewebsecurity src="page.html"></webview>
|
|
|
|
|
|
|
|
|
|
<!-- Good -->
|
|
|
|
|
<webview src="page.html"></webview>
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
## 6) Define a Content Security Policy
|
2018-01-29 19:02:30 +00:00
|
|
|
|
|
|
|
|
|
A Content Security Policy (CSP) is an additional layer of protection against
|
2018-01-30 00:01:05 +00:00
|
|
|
|
cross-site-scripting attacks and data injection attacks. We recommend that they
|
|
|
|
|
be enabled by any website you load inside Electron.
|
2018-01-29 19:02:30 +00:00
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
CSP allows the server serving content to restrict and control the resources
|
2018-01-30 00:01:05 +00:00
|
|
|
|
Electron can load for that given web page. `https://your-page.com` should
|
|
|
|
|
be allowed to load scripts from the origins you defined while scripts from
|
2018-01-29 19:02:30 +00:00
|
|
|
|
`https://evil.attacker.com` should not be allowed to run. Defining a CSP is an
|
|
|
|
|
easy way to improve your applications security.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
Electron respects [the `Content-Security-Policy` HTTP header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy)
|
2018-01-30 00:02:39 +00:00
|
|
|
|
and the respective `<meta>` tag.
|
2018-01-29 19:02:30 +00:00
|
|
|
|
|
|
|
|
|
The following CSP will allow Electron to execute scripts from the current
|
2018-01-30 00:01:05 +00:00
|
|
|
|
website and from `apis.mydomain.com`.
|
2018-01-29 19:02:30 +00:00
|
|
|
|
|
2018-01-29 19:29:15 +00:00
|
|
|
|
```txt
|
2018-01-29 19:02:30 +00:00
|
|
|
|
// Bad
|
|
|
|
|
Content-Security-Policy: '*'
|
|
|
|
|
|
|
|
|
|
// Good
|
|
|
|
|
Content-Security-Policy: script-src 'self' https://apis.mydomain.com
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 7) Override and Disable `eval`
|
2018-01-29 19:02:52 +00:00
|
|
|
|
|
|
|
|
|
`eval()` is a core JavaScript method that allows the execution of JavaScript
|
|
|
|
|
from a string. Disabling it disables your app's ability to evaluate JavaScript
|
|
|
|
|
that is not known in advance.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
The `eval()` method has precisely one mission: To evaluate a series of
|
|
|
|
|
characters as JavaScript and execute it. It is a required method whenever you
|
2018-01-30 00:01:05 +00:00
|
|
|
|
need to evaluate code that is not known ahead of time. While legitimate use
|
2018-05-08 05:16:09 +00:00
|
|
|
|
cases exist, like any other code generators, `eval()` is difficult to harden.
|
2018-01-29 19:02:52 +00:00
|
|
|
|
|
|
|
|
|
Generally speaking, it is easier to completely disable `eval()` than to make
|
|
|
|
|
it bulletproof. Thus, if you do not need it, it is a good idea to disable it.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```js
|
2018-01-30 00:27:41 +00:00
|
|
|
|
// ESLint will warn about any use of eval(), even this one
|
|
|
|
|
// eslint-disable-next-line
|
2018-01-29 20:36:51 +00:00
|
|
|
|
window.eval = global.eval = function () {
|
|
|
|
|
throw new Error(`Sorry, this app does not support window.eval().`)
|
2018-01-29 19:02:52 +00:00
|
|
|
|
}
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 8) Do Not Set `allowRunningInsecureContent` to `true`
|
2018-01-29 19:03:06 +00:00
|
|
|
|
|
2018-01-29 20:34:46 +00:00
|
|
|
|
_Recommendation is Electron's default_
|
|
|
|
|
|
2018-03-27 23:15:29 +00:00
|
|
|
|
By default, Electron will not allow websites loaded over `HTTPS` to load and
|
2018-01-29 19:03:06 +00:00
|
|
|
|
execute scripts, CSS, or plugins from insecure sources (`HTTP`). Setting the
|
|
|
|
|
property `allowRunningInsecureContent` to `true` disables that protection.
|
|
|
|
|
|
|
|
|
|
Loading the initial HTML of a website over `HTTPS` and attempting to load
|
|
|
|
|
subsequent resources via `HTTP` is also known as "mixed content".
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
2018-05-08 05:16:09 +00:00
|
|
|
|
Loading content over `HTTPS` assures the authenticity and integrity
|
2018-01-30 00:01:05 +00:00
|
|
|
|
of the loaded resources while encrypting the traffic itself. See the section on
|
2018-05-02 15:33:07 +00:00
|
|
|
|
[only displaying secure content](#1-only-load-secure-content) for more details.
|
2018-01-29 19:03:06 +00:00
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
|
|
|
|
allowRunningInsecureContent: true
|
|
|
|
|
}
|
|
|
|
|
})
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```
|
2018-01-29 19:03:06 +00:00
|
|
|
|
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```js
|
2018-01-29 19:03:06 +00:00
|
|
|
|
// Good
|
|
|
|
|
const mainWindow = new BrowserWindow({})
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:03:27 +00:00
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 9) Do Not Enable Experimental Features
|
2018-01-29 19:03:27 +00:00
|
|
|
|
|
2018-01-29 20:34:46 +00:00
|
|
|
|
_Recommendation is Electron's default_
|
|
|
|
|
|
2018-01-29 19:03:27 +00:00
|
|
|
|
Advanced users of Electron can enable experimental Chromium features using the
|
|
|
|
|
`experimentalFeatures` and `experimentalCanvasFeatures` properties.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
Experimental features are, as the name suggests, experimental and have not been
|
2018-02-13 05:18:27 +00:00
|
|
|
|
enabled for all Chromium users. Furthermore, their impact on Electron as a whole
|
2018-01-29 19:03:27 +00:00
|
|
|
|
has likely not been tested.
|
|
|
|
|
|
|
|
|
|
Legitimate use cases exist, but unless you know what you are doing, you should
|
|
|
|
|
not enable this property.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
|
|
|
|
experimentalFeatures: true
|
|
|
|
|
}
|
|
|
|
|
})
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```
|
2018-01-29 19:03:27 +00:00
|
|
|
|
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```js
|
2018-01-29 19:03:27 +00:00
|
|
|
|
// Good
|
|
|
|
|
const mainWindow = new BrowserWindow({})
|
|
|
|
|
```
|
|
|
|
|
|
2018-01-29 19:03:38 +00:00
|
|
|
|
|
2018-05-23 21:01:34 +00:00
|
|
|
|
## 10) Do Not Use `enableBlinkFeatures`
|
2018-01-29 20:34:46 +00:00
|
|
|
|
|
|
|
|
|
_Recommendation is Electron's default_
|
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
Blink is the name of the rendering engine behind Chromium. As with
|
2018-05-23 21:01:34 +00:00
|
|
|
|
`experimentalFeatures`, the `enableBlinkFeatures` property allows developers to
|
2018-01-29 19:03:38 +00:00
|
|
|
|
enable features that have been disabled by default.
|
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
Generally speaking, there are likely good reasons if a feature was not enabled
|
|
|
|
|
by default. Legitimate use cases for enabling specific features exist. As a
|
|
|
|
|
developer, you should know exactly why you need to enable a feature, what the
|
|
|
|
|
ramifications are, and how it impacts the security of your application. Under
|
|
|
|
|
no circumstances should you enable features speculatively.
|
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
```js
|
|
|
|
|
// Bad
|
|
|
|
|
const mainWindow = new BrowserWindow({
|
|
|
|
|
webPreferences: {
|
2018-05-23 21:01:34 +00:00
|
|
|
|
enableBlinkFeatures: ['ExecCommandInJavaScript']
|
2018-01-29 19:03:38 +00:00
|
|
|
|
}
|
|
|
|
|
})
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```
|
2018-01-29 19:03:38 +00:00
|
|
|
|
|
2018-01-29 20:36:51 +00:00
|
|
|
|
```js
|
2018-01-29 19:03:38 +00:00
|
|
|
|
// Good
|
|
|
|
|
const mainWindow = new BrowserWindow()
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 11) Do Not Use `allowpopups`
|
2018-01-29 19:04:02 +00:00
|
|
|
|
|
2018-01-29 20:34:46 +00:00
|
|
|
|
_Recommendation is Electron's default_
|
|
|
|
|
|
2018-06-21 17:06:54 +00:00
|
|
|
|
If you are using [`<webview>`][webview-tag], you might need the pages and scripts
|
2018-01-29 20:34:46 +00:00
|
|
|
|
loaded in your `<webview>` tag to open new windows. The `allowpopups` attribute
|
2018-02-20 00:25:02 +00:00
|
|
|
|
enables them to create new [`BrowserWindows`][browser-window] using the
|
2018-06-21 17:06:54 +00:00
|
|
|
|
`window.open()` method. `<webview>` tags are otherwise not allowed to create new
|
2018-01-29 20:34:46 +00:00
|
|
|
|
windows.
|
2018-01-29 19:04:02 +00:00
|
|
|
|
|
|
|
|
|
### Why?
|
|
|
|
|
|
|
|
|
|
If you do not need popups, you are better off not allowing the creation of
|
2018-02-20 00:25:02 +00:00
|
|
|
|
new [`BrowserWindows`][browser-window] by default. This follows the principle
|
2018-01-30 00:01:05 +00:00
|
|
|
|
of minimally required access: Don't let a website create new popups unless
|
|
|
|
|
you know it needs that feature.
|
2018-01-29 19:04:02 +00:00
|
|
|
|
|
|
|
|
|
### How?
|
|
|
|
|
|
|
|
|
|
```html
|
|
|
|
|
<!-- Bad -->
|
|
|
|
|
<webview allowpopups src="page.html"></webview>
|
|
|
|
|
|
|
|
|
|
<!-- Good -->
|
|
|
|
|
<webview src="page.html"></webview>
|
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
|
2018-02-01 17:58:02 +00:00
|
|
|
|
## 12) Verify WebView Options Before Creation
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-01-29 02:19:49 +00:00
|
|
|
|
A WebView created in a renderer process that does not have Node.js integration
|
|
|
|
|
enabled will not be able to enable integration itself. However, a WebView will
|
|
|
|
|
always create an independent renderer process with its own `webPreferences`.
|
|
|
|
|
|
2018-06-21 17:06:54 +00:00
|
|
|
|
It is a good idea to control the creation of new [`<webview>`][webview-tag] tags
|
|
|
|
|
from the main process and to verify that their webPreferences do not disable
|
2018-01-29 20:34:46 +00:00
|
|
|
|
security features.
|
2018-01-29 02:19:49 +00:00
|
|
|
|
|
|
|
|
|
### Why?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-06-21 17:06:54 +00:00
|
|
|
|
Since `<webview>` live in the DOM, they can be created by a script running on your
|
2018-01-30 00:01:05 +00:00
|
|
|
|
website even if Node.js integration is otherwise disabled.
|
2018-01-29 02:19:49 +00:00
|
|
|
|
|
|
|
|
|
Electron enables developers to disable various security features that control
|
2018-01-29 19:19:43 +00:00
|
|
|
|
a renderer process. In most cases, developers do not need to disable any of
|
|
|
|
|
those features - and you should therefore not allow different configurations
|
2018-06-21 17:06:54 +00:00
|
|
|
|
for newly created [`<webview>`][webview-tag] tags.
|
2018-01-29 02:19:49 +00:00
|
|
|
|
|
|
|
|
|
### How?
|
2018-01-29 19:19:43 +00:00
|
|
|
|
|
2018-06-21 17:06:54 +00:00
|
|
|
|
Before a [`<webview>`][webview-tag] tag is attached, Electron will fire the
|
2018-01-29 02:19:49 +00:00
|
|
|
|
`will-attach-webview` event on the hosting `webContents`. Use the event to
|
2018-06-21 17:06:54 +00:00
|
|
|
|
prevent the creation of webviews with possibly insecure options.
|
2018-01-29 02:19:49 +00:00
|
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
app.on('web-contents-created', (event, contents) => {
|
|
|
|
|
contents.on('will-attach-webview', (event, webPreferences, params) => {
|
|
|
|
|
// Strip away preload scripts if unused or verify their location is legitimate
|
|
|
|
|
delete webPreferences.preload
|
|
|
|
|
delete webPreferences.preloadURL
|
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
// Disable Node.js integration
|
2018-01-29 02:19:49 +00:00
|
|
|
|
webPreferences.nodeIntegration = false
|
|
|
|
|
|
|
|
|
|
// Verify URL being loaded
|
|
|
|
|
if (!params.src.startsWith('https://yourapp.com/')) {
|
|
|
|
|
event.preventDefault()
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
})
|
|
|
|
|
```
|
|
|
|
|
|
2016-05-10 08:41:16 +00:00
|
|
|
|
Again, this list merely minimizes the risk, it does not remove it. If your goal
|
|
|
|
|
is to display a website, a browser will be a more secure option.
|
2018-01-29 20:34:46 +00:00
|
|
|
|
|
2018-01-30 00:01:05 +00:00
|
|
|
|
[browser-window]: ../api/browser-window.md
|
|
|
|
|
[browser-view]: ../api/browser-view.md
|
2018-06-21 17:06:54 +00:00
|
|
|
|
[webview-tag]: ../api/webview-tag.md
|