Livar
073daaf450
Merge branch 'rel/1.0.0' into localization
2017-01-18 10:03:18 -08:00
Livar Cunha
f765a02865
Fix compile break.
2017-01-17 13:44:31 -08:00
Livar Cunha
2161364116
Adding a test for a project that has a package dependency whose name is also the name of a folder in the repo.
...
Moved the test to dotnet-migrate.Test and modified the code that find possible P2P dependencies to actually check if the folder holds a project.
2017-01-17 13:14:18 -08:00
Livar
9095743ff7
Merge pull request #5356 from piotrpMSFT/piotrpMSFT/issues/5345
...
Fixes #5345
2017-01-16 17:12:46 -08:00
Livar
557999a5bd
Merge pull request #5352 from livarcocc/skip_project_references
...
Skipping project dependencies check when the skip-project-references flag is passed
2017-01-16 16:20:39 -08:00
Piotr Puszkiewicz
82dcdada50
Fixes #5345
2017-01-16 16:13:58 -08:00
Livar Cunha
e1f355065d
Moving the project dependencies construction to after we check for the skip project reference check, so that we really don't look for P2P projects when the flag is passed.
2017-01-16 15:16:31 -08:00
Livar Cunha
b8da3b9a87
Updating the versions of xunit 2.2.0-beta5-build3474 and xunit runner to 2.2.0-beta5-build1225.
2017-01-16 13:08:40 -08:00
Zbyněk Sailer
8dbab0f79a
LOC CHECKIN | dotnet/cli | 20170116
2017-01-16 14:52:18 +01:00
Livar Cunha
8c2e7c9f01
Merge branch 'rel/1.0.0-rc3' into merge_rc3
...
* rel/1.0.0-rc3:
Fixing an issue where packages with a filter but no match were not being migrated as is, instead they were being dropped.
Add support for migrating Microsoft.AspNetCore.Mvc.ViewCompilation
Switching to using a csv as the source of our lts packages. Also, this is a more comprehensive list.
Adding a few more packages that were not in the manifest and moving some tests around.
Migrating packages to LTS (1.0.3) versions if they have a smaller version than the LTS one.
Adding ranges to the source mappings so that we can specify the origin should match this range and migrate to that version. We use this to handle LTS/FTS migration and will use that for the LTS uplift.
Migration: do not inject built in compile includes that the SDK does
Update msbuild to 15.1.0-preview-000522-02
Migration: Do not add RIDs for Library projects (#5279 )
Use a separate env variable to control uploading the lzma archive. We only want OSX to publish the archive, because turns out that windows published archives are not used by unix based oses.
Fix the download of the LZMA archive on dev machines and in Jenkins CI.
2017-01-13 14:08:31 -08:00
Livar Cunha
18a3dd60b5
Fixing an issue where packages with a filter but no match were not being migrated as is, instead they were being dropped.
2017-01-12 18:23:35 -08:00
Krzysztof Wicher
5fea7c3ae6
Remove try catches choking all exceptions ( #5206 )
...
* remove some try catches choking all exceptions
* rename ExceptionExtension to ReportAsWarning, show full stack instead of just message
* dotnet-migrate try catch clean-up
* fix migration test failures
2017-01-12 15:42:36 -08:00
Livar
a9c5f4e90a
Merge pull request #5293 from dotnet/dev/jgoshi/issue5253
...
Migration: do not inject built in compile includes that the SDK does
2017-01-12 15:00:03 -08:00
Pranav K
80c435e6a1
Add support for migrating Microsoft.AspNetCore.Mvc.ViewCompilation
2017-01-12 13:49:28 -08:00
Livar Cunha
deb50a3cc7
Switching to using a csv as the source of our lts packages. Also, this is a more comprehensive list.
2017-01-12 11:38:05 -08:00
Livar Cunha
12abcf7208
Adding a few more packages that were not in the manifest and moving some tests around.
2017-01-12 11:38:05 -08:00
Livar Cunha
a0aa8150de
Migrating packages to LTS (1.0.3) versions if they have a smaller version than the LTS one.
2017-01-12 11:38:05 -08:00
Livar Cunha
89fba856e8
Adding ranges to the source mappings so that we can specify the origin should match this range and migrate to that version. We use this to handle LTS/FTS migration and will use that for the LTS uplift.
2017-01-12 11:38:05 -08:00
Justin Goshi
71da7f6a45
Migration: do not inject built in compile includes that the SDK does
2017-01-12 11:22:41 -08:00
Justin Goshi
03be0e56d4
Migration: Do not add RIDs for Library projects ( #5279 )
...
* WIP
* Do not add runtime identifiers for libraries
* Reusing an existing test project
* Fix up tests
2017-01-11 17:05:12 -08:00
Livar Cunha
e71c58c156
Fixing nuget API calls and fixing the nuget test package directory creation, so that nuget can restore using it.
2017-01-10 10:43:05 -08:00
Livar Cunha
3220b14248
Updating the branding of the CLI to 1.0.0-rc3
2017-01-09 13:59:03 -08:00
Harsh Jain
0222e8e850
merged to resolve conflicts
2017-01-07 20:40:50 +05:30
Livar
5bdbe354b2
Merge pull request #5226 from livarcocc/migrate_full_framework
...
Migration will now pick win7-x86 as the RuntimeIdentifier to be used by Full Framework TFMs
2017-01-06 14:48:35 -08:00
Livar
f0d6b20dd7
Merge branch 'rel/1.0.0' into localization
2017-01-06 12:30:58 -08:00
Harsh Jain
effee47d38
Version update for test platform.
2017-01-07 01:04:00 +05:30
Livar
dbdbde5bcc
Merge pull request #5229 from livarcocc/another_xlf_update
...
Another update to the xlf files.
2017-01-06 10:20:08 -08:00
Zbyněk Sailer
bf7a0845b7
LOC CHECKIN | dotnet/cli | 20170106
2017-01-06 19:07:21 +01:00
Livar Cunha
4bf55e3c38
Another update to the xlf files.
2017-01-05 23:01:58 -08:00
Livar Cunha
7e5f18b584
Fixing full framework tests.
2017-01-05 22:55:43 -08:00
Livar Cunha
b41eb43883
Updating our projects and test assets to work with the latest SDK.
2017-01-05 19:44:52 -08:00
Livar Cunha
abe7641f03
Migration will now pick win7-x86 as the RuntimeIdentifier to be used by Full Framework TFMs when no RIDs exist in the source PJ. This will allow build/publish etc to continue working in csproj without extra RIDs parameters in the command line.
2017-01-05 16:52:02 -08:00
Piotr Puszkiewicz
d14698f1f6
Bump MSBuild Version to 15.1.0-preview-000503-01 ( #5199 )
...
* Bump MSBuild Version to 15.1.0-preview-000503-01
* tool_csc->tool_roslyn
* pull some properties up to dir.props
* Move Roslyn to "Roslyn" subdirectory
* Fix relative paths in RunCsc.*
* Add removal of csc & vbc from deps.json
* Revert roslyn to 2.0.0-rc3-61212-03
* netcoreapp -> 1.0.3
2017-01-05 14:56:11 -08:00
Livar
8effe48566
Merge pull request #5212 from livarcocc/update_sdk_with_globbing
...
Updating the SDK to an SDK that includes globing for source and resources
2017-01-05 13:49:32 -08:00
Livar Cunha
3b69588db2
Picking up the latest SDK and adding back some named parameters to MigrateBuildOptionsRule for clarity.
...
Updating the tool project to use BuiltProjectOutputGroupOutput instead of content because of SDK issue https://github.com/dotnet/sdk/issues/588
2017-01-05 12:31:49 -08:00
Livar Cunha
3a4e23e373
Updating the SDK to an SDK that includes globing for source and resources implicitly.
2017-01-05 12:31:48 -08:00
Livar Cunha
69e963669f
Adding Release to the sdk defined constants so that we don't emit it during migration anymore.
2017-01-05 11:46:02 -08:00
Livar Cunha
a4dcff9ea8
Addressing code review comments.
2017-01-04 12:25:48 -08:00
Livar Cunha
47eafb9ef4
Removing the PackageTargetFallback condition on TFM when there is only a single TFM
2017-01-03 20:36:51 -08:00
Livar Cunha
e9561b3679
Removing the IsCrossTargetBuild from migrated scripts when there is only a single TFM
2017-01-03 17:15:39 -08:00
Livar
06d33f01ce
Merge pull request #5178 from livarcocc/update_tools_msbuild3
...
Updating the migrated tools version to 1.0.0-msbuild3-final.
2016-12-30 13:16:29 -08:00
Krzysztof Wicher
961905a301
Merge pull request #5158 from krwq/i5070
...
Fix #5071 : Eliminate some cross project dependencies in tests and fix local builds on windows
2016-12-28 23:26:51 -08:00
Livar Cunha
fa675cb5e5
Updating the migrated tools version to 1.0.0-msbuild3-final.
2016-12-28 21:26:31 -08:00
Livar Cunha
ad88058266
Stopped doing hoisting of transitive project dependencies and references. We also don't validate if a dependency exist, since migration strictly speaking does not need it. We move the project.json and the csproj will fail to build just like the project.json would.
2016-12-28 14:48:38 -08:00
Krzysztof Wicher
e9dc08eafa
make localizablestrings internal again
2016-12-27 14:53:45 -08:00
Krzysztof Wicher
35bc8e1cc1
remove cross project reference from dotnet-add-p2p tests
2016-12-27 14:53:44 -08:00
Krzysztof Wicher
5095981ec3
fix line endings related errors in dotnet-add-p2p tests
2016-12-27 14:53:44 -08:00
v-mdriml
5580b40181
Loc HB XLF files
2016-12-23 17:16:52 +01:00
Livar
b4ef34bc38
Merge pull request #5104 from livarcocc/update_sdks
...
Updating the projects files in the repo to use the SDK attribute.
2016-12-21 15:34:33 -08:00
Jon Sequeira
3b0a2f5d20
Merge pull request #5106 from jonsequitur/make-migration-backup-folder-peer-of-project
...
make migration backup folder a sibling of the project root
2016-12-21 12:12:11 -08:00
Livar
10a1695d6c
Merge pull request #5090 from livarcocc/migrate_app_config
...
Emitting a None item for App.config if one exists side-by-side to the project.json
2016-12-20 16:43:24 -08:00
jonsequitur
9b28fbecd6
R: rename EnsureDirectory to EnsureDirectoryExists and similar
2016-12-20 16:03:00 -08:00
Livar Cunha
fadacc0aac
Updating the projects files in the repo to use the SDK attribute.
2016-12-20 15:52:50 -08:00
Jon Sequeira
35e3625d4b
Merge branch 'rel/1.0.0' into make-migration-backup-folder-peer-of-project
2016-12-20 15:24:33 -08:00
Justin Goshi
89f0b05958
Improve sln migration tests ( #5066 )
...
* WIP Improve sln migration tests
* Simple migration test
* Improve the test
* WIP update test assets
* Update test
* Test a bug fix
* Add another migrate sln test
* Fix FilePath related tests
* Finish the migrate sln tests
* Fix tests
* Fix another path issue
2016-12-20 13:04:01 -10:00
Livar Cunha
4bda166b2f
Emitting a None item for App.config if one exists side-by-side to the project.json.
2016-12-20 14:42:31 -08:00
jonsequitur
620e573f95
make migration backup folder a sibling of the project root
2016-12-20 14:35:52 -08:00
Livar
134e9af798
Merge pull request #5078 from livarcocc/preserve_rids_from_pj
...
Only adding rids for full framework TFMs if the project.json does not have runtimes
2016-12-19 16:20:12 -08:00
Livar
2aa166b5d0
Merge pull request #5069 from livarcocc/version_attributes
...
Making version an attribute for packagereference and dotnetclitoolreference
2016-12-19 09:48:00 -08:00
Livar Cunha
b2ce6c794a
Only adding rids for full framework TFMs if the project.json does not already have Runtimes in its Runtimes section.
2016-12-18 18:45:35 -08:00
Livar Cunha
44147f0efa
Updating xlf files to reflect the modification of the test help message, of the dotnet help update and the additions of CommandLine, Migration, Sln.Internal, msbuild command and Cli.Utils.
2016-12-17 10:55:12 -08:00
Livar Cunha
52b45d0c49
Fixing tests and a couple of issues in the code due to Localization.
2016-12-16 23:59:58 -08:00
Piotr Puszkiewicz
fddabd4a51
https://github.com/dotnet/cli/issues/5071
2016-12-16 22:45:48 -08:00
Piotr Puszkiewicz
469abc2d96
Yet more migration
2016-12-16 22:45:47 -08:00
Piotr Puszkiewicz
91061c2296
more migration loc
2016-12-16 22:45:47 -08:00
Piotr Puszkiewicz
5cfed1a787
Localize Migration
2016-12-16 22:45:47 -08:00
Livar Cunha
e1c0bbe0f7
Making version an attribute for packagereference and dotnetclitoolreference.
2016-12-16 19:13:37 -08:00
Livar
a9ca6d8c5b
Merge pull request #5062 from livarcocc/clean_empty_targets_migration
...
Added a clean empty targets method to CleanOutputProjectRule
2016-12-16 18:07:37 -08:00
Livar Cunha
d6d6fc612b
Added a unit test for cleaning empty targets.
...
Added a clean empty targets method to CleanOutputProjectRule that removes any targets without content inside of them from the csproj.
2016-12-16 13:31:42 -08:00
Livar Cunha
e710958b79
Adding a Exclude @(EmbeddedResource) during migration so that we don't get duplicate resources when building migrated apps.
2016-12-15 11:17:20 -08:00
Livar Cunha
56dd76bdb0
Adding Update under Content for BuildOptions as well, but limiting this change only to Web Apps at the moment, because regular SDK does not have Content Include=**/* in place yet.
2016-12-13 16:45:40 -08:00
Livar Cunha
a22f4be938
Adding a UpdateContextTransform that generates items with the Update attribute set instead of Include. Also, removed the Exists condition for published content, because now that we are using Update, that check is not needed. I left the option to set a condition on the metadata though.
2016-12-13 16:45:39 -08:00
Livar Cunha
84682562bf
Adding a condition to Content CopyToPublishDirectory to validate that the file exists before trying to copy it to output, to keep the same functionality as it existed in PJ. In MSBuild world, without this condition, CopyToPublishDirectory will fail.
2016-12-13 16:45:39 -08:00
Justin Goshi
2b7e9b6524
Clean up sln reader/writer ( #5005 )
2016-12-13 06:45:00 -10:00
Livar
bd590f51e6
Emitting PackageId whenever we emit AssemblyName. We need to do this to preserve the behavior from PJ where the package id matched the containing PJ folder name. In MSBuild, PackageId will match AssemblyName, unless it is explicitly specified. ( #4990 )
2016-12-09 16:10:16 -08:00
Piotr Puszkiewicz
70c8ecbf16
Merge branch 'rel/1.0.0' into migrate_pj_without_frameworks
2016-12-09 00:30:36 -08:00
Livar
1fd99f1588
Merge rel/1.0.0-preview4 back into rel/1.0.0 ( #4974 )
...
* Updating the preview4 channel to rel-1.0.0-preview4
* Add more xlf files for new strings
* bundle fsharp sdk, only Sdk directory is required
* align f# console proj
* align f# lib template
* align f# mstest template
* align f# xunit template
* align f# web template
* fix mstest package version, aligned to c#
* remove unused directories from bundled sdks
* Adding a SdkNugetVersion property when invoking dotnet pack on test packages so that test packages can reference exact packages. We need that because of https://github.com/NuGet/Home/issues/4063 . Without it, pack creates the nuspec with a version like 1.0.0-version-, instead of 1.0.0-version-<version_used_in_build>, which leads to problems when restoring the tool. Like, it ends up restoring to the closest version of the package (oldest), instead of the latest.
* Update web template for Web SDK 154 (#4948 )
* Update WebSDK version
* Update web template to get rid of globs
https://github.com/aspnet/Templates/pull/735
* MSBuild to 15.1.458 (#4950 )
* Adding MigrateWebSdkRule to the DefaultMigrationRuleSet (#4963 )
* Adding MigrateWebSdkRule to the DefaultMigrationRuleSet and adding a E2E test to cover it.
* Do not migrate compile and EmbeddedResources for web application, because those are included in the Web Sdk already.
* Addressing code review comments
2016-12-09 00:30:02 -08:00
Livar Cunha
bb1bceb8bb
When we had a project.json without frameworks, we were failing to show the appropriate error message because when we were generating the error message itself we tried to access the project context (which requires a framework in the PJ). This fix makes the ProjectContext optional to add the migration error.
2016-12-08 19:53:35 -08:00
Justin Goshi
0831316321
Allow migration of sln files ( #4949 )
...
* WIP Migrate sln files
* WIP add reference to redist
* Adding tests and fixing a few bugs
* Fix some tests
* Remove use of DeepClone
* Fix test build errors
* Fix more tests
2016-12-07 11:49:15 -10:00
Livar Cunha
9d96bf8c20
Adding GenerateRuntimeConfigurationFiles when migrating a test project.
2016-12-05 18:23:34 -08:00
Livar Cunha
de9ae38375
Updating the branding of rel/1.0.0 to preview5.
2016-12-05 14:47:16 -08:00
Piotr Puszkiewicz
d6cab4af58
use Sdks attribute in dotnet new
templates ( #4916 )
...
* Move dotnet-new templates to Sdk attribute
* Update to MSBuild 15.1.0-preview-000454-01
To pick up a fix for Microsoft/msbuild#1431 .
* Fix template newlines
* Fix casing on Microsoft.Net.Sdk
* Move migration test csproj's to Sdk attribute
* Disable parallel sdk restore
Each SDK restore operation will try to manipulate the same assets.json file since the dependency name&version are injected into a common csproj file. This can cause runtime failures when two NuGets try to restore the project at once.
* Make casing of SDK 'NET' and not 'Net'
* Remove redundatn imports
* Fix test string
* Additional race
* Replacing the SDK with the Web.Sdk when it is a Web project.
* Fixing the test by writting the csproj before running the migration rule.
2016-12-04 22:31:58 -08:00
Livar Cunha
7583bcb2fd
Skipping dotnet publish-iis when migrating scripts as it is now part of the web.sdk
2016-12-02 10:41:25 -08:00
Piotr Puszkiewicz
da82bdb05d
Centralize Microsoft.Net.SDK Version ( #4890 )
...
* Centralize Microsoft.Net.Sdk package version
Note: Templates were omitted as their version needs to be static.
* Unifying additional missmatched versions
* prefercliruntime
whitespace threw off ReplaceAll
* Additional missed globs
* Revert SDK version for performance tests
* PR Feedback
* Roll back VSTestXunitDesktopAndNetCore.csproj SDK version
2016-12-02 09:34:03 -08:00
Piotr Puszkiewicz
f18967e39a
Update CLI's MSBuild Version to 15.1.0-preview-000451-02 ( #4889 )
...
* Centralize definition of MSBuild Version in CLI
* MSBuild --> 15.1.0-preview-000451-02
2016-12-01 20:10:42 -08:00
Martin Andreas Ullrich
4af30914c9
Show meaningful error when failing to migrate invalid scripts ( #4842 )
2016-11-30 20:36:13 -08:00
Krzysztof Wicher
5d1deeeea1
test project - almost finished - not all review changes included
2016-11-22 14:46:32 -08:00
dasMulli
acb4d64c07
Migration: Handle different variations of specifying assembly attributes.
2016-11-18 18:05:00 +01:00
Livar
9847196c95
Merge pull request #4737 from livarcocc/migrate_authors
...
Adding Authors migration.
2016-11-16 09:29:13 -08:00
Livar
11f871b715
Merge pull request #4733 from livarcocc/migrate_adds_rids_for_desktop
...
Emitting runtime identifiers if the source project has any full framework TFMs
2016-11-16 09:29:01 -08:00
Justin Goshi
be61afcfa5
Remove unused project.json and .xproj files ( #4735 )
...
* Remove unused project.json and .xproj files
* Update the test msi script
2016-11-15 16:12:19 -10:00
Livar Cunha
c364f27346
Adding Authors migration.
2016-11-15 16:36:04 -08:00
Livar Cunha
9513428013
Emitting runtime identifiers if the source project has any full framework TFMs.
2016-11-15 14:07:35 -08:00
Krzysztof Wicher
43df9a170d
Fix 4655: Migrate errors are not getting put in formatted output ( #4718 )
...
* Fix 4655: Migrate errors are not getting put in formatted output
* Move test asset to NonRestoredTestProjects
* use group test asset manager: NonRestoredTestProjects
2016-11-15 09:39:58 -08:00
Livar Cunha
df755b5554
Removing dotnet-test-mstest when migrating because that package is no longer needed.
2016-11-11 10:52:33 -08:00
Livar
43dfa6b8ba
Updating script migration to use the correct BeforeTargets. ( #4680 )
2016-11-10 18:24:35 -08:00
Livar
9869b82412
Merge pull request #4662 from livarcocc/remove_dotnet_test_xunit_migration
...
Removing dotnet-test-xunit when migration from project.json to csproj
2016-11-09 11:11:17 -08:00
Livar Cunha
7f549314ff
Removing dotnet-test-xunit when migration from project.json to csproj, as that package is no longer needed.
2016-11-09 09:52:52 -08:00
Livar
312559ccdc
Merge pull request #4636 from Faizan2304/xunitTemplateFix
...
Update version of xunit adapter in test assets and xunit template
2016-11-08 14:42:47 -08:00
Faizan Ahmad
cc450ed8ce
Update the version for migration project
2016-11-08 23:05:43 +05:30