mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #4662 from livarcocc/remove_dotnet_test_xunit_migration

Browse source 
Removing dotnet-test-xunit when migration from project.json to csproj
This commit is contained in:
Livar 2016-11-09 11:11:17 -08:00 committed by GitHub
commit 9869b82412
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Microsoft.DotNet.ProjectJsonMigration/PackageConstants.cs
View file

@ -23,6 +23,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration
public const string MstestTestFrameworkName = "MSTest.TestFramework";
public const string NetStandardPackageName = "NETStandard.Library";
public const string NetStandardPackageVersion = "1.6.0";
public const string DotnetTestXunit = "dotnet-test-xunit";
public static readonly IDictionary<string, PackageDependencyInfo> ProjectDependencyPackages =
new Dictionary<string, PackageDependencyInfo> {
@ -50,6 +51,7 @@ namespace Microsoft.DotNet.ProjectJsonMigration
{ MstestTestFrameworkName, new PackageDependencyInfo {
Name = MstestTestFrameworkName,
Version = ConstantPackageVersions.MstestTestFrameworkVersion } },
{ DotnetTestXunit, null },
};
public static readonly IDictionary<string, PackageDependencyInfo> ProjectToolPackages =

5
test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateAspNetTools.cs → test/Microsoft.DotNet.ProjectJsonMigration.Tests/Rules/GivenThatIWantToMigrateTools.cs
View file

@ -9,7 +9,7 @@ using System;
namespace Microsoft.DotNet.ProjectJsonMigration.Tests
{
public class GivenThatIWantToMigrateAspNetTools : PackageDependenciesTestBase
public class GivenThatIWantToMigrateTools : PackageDependenciesTestBase
{
[Theory]
[InlineData("Microsoft.EntityFrameworkCore.Tools", "Microsoft.EntityFrameworkCore.Tools", ConstantPackageVersions.AspNetToolsVersion)]
@ -33,7 +33,8 @@ namespace Microsoft.DotNet.ProjectJsonMigration.Tests
[InlineData("Microsoft.AspNetCore.Razor.Tools")]
[InlineData("Microsoft.AspNetCore.Razor.Design")]
[InlineData("Microsoft.VisualStudio.Web.CodeGeneration.Tools")]
public void It_does_not_migrate_asp_project_tool_dependency(string dependencyName)
[InlineData("dotnet-test-xunit")]
public void It_does_not_migrate_project_tool_dependency_that_is_no_longer_needed(string dependencyName)
{
var mockProj = RunPackageDependenciesRuleOnPj(@"
{