mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add comments explaining why these targets are disabled

Browse source 
Clean up the run-build script
This commit is contained in:
Marc Paine 2023-11-09 13:26:53 -08:00
parent 577b7aab27
commit ca5f6b0077
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
run-build.ps1
View file

@ -24,10 +24,7 @@ if ($PgoInstrument) {
} }
if ($Sign) { if ($Sign) {
$Parameters = "$Parameters -sign /p:SignCoreSdk=true" $Parameters = "$Parameters -sign"
# Workaround https://github.com/dotnet/arcade/issues/1776
$WarnAsError = $false
} }
if ($Pack) { if ($Pack) {

1
src/redist/targets/Crossgen.targets
View file

@ -1,5 +1,6 @@
<Project> <Project>
<!-- Crossgen is currently not supported on the s390x, ppc64le architecture as using mono instead of CoreCLR. --> <!-- Crossgen is currently not supported on the s390x, ppc64le architecture as using mono instead of CoreCLR. -->
<!-- Disable the cross-gen step in the local dev build, only do when -pack is specified to speed up dev builds -->
<Target Name="CrossgenLayout" <Target Name="CrossgenLayout"
Condition="'$(DISABLE_CROSSGEN)' == '' AND '$(Architecture)' != 's390x' AND '$(Architecture)' != 'ppc64le' AND '$(PackInstaller)' == 'true'" Condition="'$(DISABLE_CROSSGEN)' == '' AND '$(Architecture)' != 's390x' AND '$(Architecture)' != 'ppc64le' AND '$(PackInstaller)' == 'true'"
DependsOnTargets="SetSdkBrandingInfo"> DependsOnTargets="SetSdkBrandingInfo">

1
src/redist/targets/GenerateArchives.targets
View file

@ -1,4 +1,5 @@
<Project> <Project>
<!-- Disable the GenerateArchives step in the local dev build, only do when -pack is specified to speed up dev builds -->
<Target Name="GenerateArchives" <Target Name="GenerateArchives"
Condition="'$(PackInstaller)' == 'true'" Condition="'$(PackInstaller)' == 'true'"
DependsOnTargets="GenerateLayout;GetCurrentRuntimeInformation" DependsOnTargets="GenerateLayout;GetCurrentRuntimeInformation"