From ca5f6b00776d14705579f1c9a5a3f9ef48f7a4e6 Mon Sep 17 00:00:00 2001
From: Marc Paine <marcpop@microsoft.com>
Date: Thu, 9 Nov 2023 13:26:53 -0800
Subject: [PATCH] Add comments explaining why these targets are disabled Clean
 up the run-build script

---
 run-build.ps1                               | 5 +----
 src/redist/targets/Crossgen.targets         | 1 +
 src/redist/targets/GenerateArchives.targets | 1 +
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/run-build.ps1 b/run-build.ps1
index 4286a0a3f..7b98f2ee5 100644
--- a/run-build.ps1
+++ b/run-build.ps1
@@ -24,10 +24,7 @@ if ($PgoInstrument) {
 }
 
 if ($Sign) {
-  $Parameters = "$Parameters -sign /p:SignCoreSdk=true"
-
-  # Workaround https://github.com/dotnet/arcade/issues/1776
-  $WarnAsError = $false
+  $Parameters = "$Parameters -sign"
 }
 
 if ($Pack) {
diff --git a/src/redist/targets/Crossgen.targets b/src/redist/targets/Crossgen.targets
index b07e9abb3..e55047af6 100644
--- a/src/redist/targets/Crossgen.targets
+++ b/src/redist/targets/Crossgen.targets
@@ -1,5 +1,6 @@
 <Project>
   <!-- Crossgen is currently not supported on the s390x, ppc64le architecture as using mono instead of CoreCLR. -->
+  <!-- Disable the cross-gen step in the local dev build, only do when -pack is specified to speed up dev builds -->
   <Target Name="CrossgenLayout"
           Condition="'$(DISABLE_CROSSGEN)' == '' AND '$(Architecture)' != 's390x' AND '$(Architecture)' != 'ppc64le' AND '$(PackInstaller)' == 'true'"
           DependsOnTargets="SetSdkBrandingInfo">
diff --git a/src/redist/targets/GenerateArchives.targets b/src/redist/targets/GenerateArchives.targets
index d19a60e8f..b34065a10 100644
--- a/src/redist/targets/GenerateArchives.targets
+++ b/src/redist/targets/GenerateArchives.targets
@@ -1,4 +1,5 @@
 <Project>
+    <!-- Disable the GenerateArchives step in the local dev build, only do when -pack is specified to speed up dev builds -->
   <Target Name="GenerateArchives"
           Condition="'$(PackInstaller)' == 'true'"
           DependsOnTargets="GenerateLayout;GetCurrentRuntimeInformation"