mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Adding "RequiresSpecificFrameworkFact("netcoreapp1.0")" to the 'ItRunsABackwardsVersionedTool' CLI test.

Browse source
This commit is contained in:
John Beisner 2017-04-14 13:31:12 -07:00
parent f56306cc62
commit c51221d2f1
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
TestAssets/TestProjects/TestAppWithCLIToolReferences/TestAppWithCLIToolReferences.csproj
View file

@ -4,8 +4,6 @@
<PropertyGroup> <PropertyGroup>
<OutputType>Exe</OutputType> <OutputType>Exe</OutputType>
<TargetFramework>netcoreapp1.1</TargetFramework> <TargetFramework>netcoreapp1.1</TargetFramework>
<RuntimeFrameworkVersion>$(CLI_SharedFrameworkVersion)</RuntimeFrameworkVersion>
<DotnetCliToolTargetFramework>netcoreapp1.1</DotnetCliToolTargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

9
test/dotnet-back-compat.Tests/GivenThatWeWantToBeBackwardsCompatibleWith1xProjects.cs
View file

@ -78,9 +78,8 @@ namespace Microsoft.DotNet.Cli.Build.Tests
.Should().Pass(); .Should().Pass();
} }
[Theory] [RequiresSpecificFrameworkFact("netcoreapp1.0")] // https://github.com/dotnet/cli/issues/6087
[InlineData("netcoreapp1.0")] public void ItRunsABackwardsVersionedTool()
public void ItRunsABackwardsVersionedTool(string target)
{ {
var testInstance = TestAssets.Get("TestAppWithCLIToolReferences") var testInstance = TestAssets.Get("TestAppWithCLIToolReferences")
.CreateInstance() .CreateInstance()
@ -91,11 +90,11 @@ namespace Microsoft.DotNet.Cli.Build.Tests
new DotnetCommand(DotnetUnderTest.WithBackwardsCompatibleRuntimes) new DotnetCommand(DotnetUnderTest.WithBackwardsCompatibleRuntimes)
.WithWorkingDirectory(testInstance.Root) .WithWorkingDirectory(testInstance.Root)
.ExecuteWithCapturedOutput("outputsframeworkversion-" + target) .ExecuteWithCapturedOutput("outputsframeworkversion-netcoreapp1.0")
.Should() .Should()
.Pass() .Pass()
.And .And
.HaveStdOutContaining(target); .HaveStdOutContaining("netcoreapp1.0");
} }
void ChangeProjectTargetFramework(FileInfo projectFile, string target) void ChangeProjectTargetFramework(FileInfo projectFile, string target)