From c51221d2f17b3b390d0fd587fed98df684ebcfe6 Mon Sep 17 00:00:00 2001 From: John Beisner Date: Fri, 14 Apr 2017 13:31:12 -0700 Subject: [PATCH] Adding "RequiresSpecificFrameworkFact("netcoreapp1.0")" to the 'ItRunsABackwardsVersionedTool' CLI test. --- .../TestAppWithCLIToolReferences.csproj | 2 -- ...venThatWeWantToBeBackwardsCompatibleWith1xProjects.cs | 9 ++++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/TestAssets/TestProjects/TestAppWithCLIToolReferences/TestAppWithCLIToolReferences.csproj b/TestAssets/TestProjects/TestAppWithCLIToolReferences/TestAppWithCLIToolReferences.csproj index c684ab90b..6dd25f7f6 100644 --- a/TestAssets/TestProjects/TestAppWithCLIToolReferences/TestAppWithCLIToolReferences.csproj +++ b/TestAssets/TestProjects/TestAppWithCLIToolReferences/TestAppWithCLIToolReferences.csproj @@ -4,8 +4,6 @@ Exe netcoreapp1.1 - $(CLI_SharedFrameworkVersion) - netcoreapp1.1 diff --git a/test/dotnet-back-compat.Tests/GivenThatWeWantToBeBackwardsCompatibleWith1xProjects.cs b/test/dotnet-back-compat.Tests/GivenThatWeWantToBeBackwardsCompatibleWith1xProjects.cs index 5b6ff3ebf..63050ca1d 100644 --- a/test/dotnet-back-compat.Tests/GivenThatWeWantToBeBackwardsCompatibleWith1xProjects.cs +++ b/test/dotnet-back-compat.Tests/GivenThatWeWantToBeBackwardsCompatibleWith1xProjects.cs @@ -78,9 +78,8 @@ namespace Microsoft.DotNet.Cli.Build.Tests .Should().Pass(); } - [Theory] - [InlineData("netcoreapp1.0")] - public void ItRunsABackwardsVersionedTool(string target) + [RequiresSpecificFrameworkFact("netcoreapp1.0")] // https://github.com/dotnet/cli/issues/6087 + public void ItRunsABackwardsVersionedTool() { var testInstance = TestAssets.Get("TestAppWithCLIToolReferences") .CreateInstance() @@ -91,11 +90,11 @@ namespace Microsoft.DotNet.Cli.Build.Tests new DotnetCommand(DotnetUnderTest.WithBackwardsCompatibleRuntimes) .WithWorkingDirectory(testInstance.Root) - .ExecuteWithCapturedOutput("outputsframeworkversion-" + target) + .ExecuteWithCapturedOutput("outputsframeworkversion-netcoreapp1.0") .Should() .Pass() .And - .HaveStdOutContaining(target); + .HaveStdOutContaining("netcoreapp1.0"); } void ChangeProjectTargetFramework(FileInfo projectFile, string target)