mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disable implicit version tests (#10123), fix 3.0 implicit version

Browse source
This commit is contained in:
Daniel Plaisted 2018-10-08 18:29:15 -07:00
parent bcfd18f155
commit 69d4d21ee5
3 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

10
build/MSBuildExtensions.targets
View file

@ -76,7 +76,7 @@
DefaultVersion="2.1.0" DefaultVersion="2.1.0"
LatestVersion="2.1.5" /> LatestVersion="2.1.5" />
<ImplicitPackageVariable Include="Microsoft.NETCore.App" <ImplicitPackageVariable Include="Microsoft.NETCore.App"
TargetFrameworkVersion="2.2" TargetFrameworkVersion="3.0"
DefaultVersion="$(_NETCoreAppPackageVersion)" DefaultVersion="$(_NETCoreAppPackageVersion)"
LatestVersion="$(_NETCoreAppPackageVersion)" /> LatestVersion="$(_NETCoreAppPackageVersion)" />
@ -88,14 +88,6 @@
TargetFrameworkVersion="2.1" TargetFrameworkVersion="2.1"
DefaultVersion="2.1.1" DefaultVersion="2.1.1"
LatestVersion="2.1.5"/> LatestVersion="2.1.5"/>
<ImplicitPackageVariable Include="Microsoft.AspNetCore.App"
TargetFrameworkVersion="2.2"
DefaultVersion="$(_AspNetCoreAppPackageVersion)"
LatestVersion="$(_AspNetCoreAppPackageVersion)"/>
<ImplicitPackageVariable Include="Microsoft.AspNetCore.All"
TargetFrameworkVersion="2.2"
DefaultVersion="$(_AspNetCoreAllPackageVersion)"
LatestVersion="$(_AspNetCoreAllPackageVersion)"/>
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>

4
test/EndToEnd/GivenFrameworkDependentApps.cs
View file

@ -22,14 +22,14 @@ namespace EndToEnd
ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.NETCorePackageName, minorVersion); ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.NETCorePackageName, minorVersion);
} }
[Theory] [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")]
[ClassData(typeof(SupportedAspNetCoreVersions))] [ClassData(typeof(SupportedAspNetCoreVersions))]
public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreApp(string minorVersion) public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreApp(string minorVersion)
{ {
ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.AspNetCoreAppPackageName, minorVersion); ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.AspNetCoreAppPackageName, minorVersion);
} }
[Theory] [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")]
[ClassData(typeof(SupportedAspNetCoreVersions))] [ClassData(typeof(SupportedAspNetCoreVersions))]
public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreAll(string minorVersion) public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreAll(string minorVersion)
{ {

6
test/EndToEnd/GivenSelfContainedAppsRollForward.cs
View file

@ -20,7 +20,7 @@ namespace EndToEnd
public const string AspNetCoreAppPackageName = "Microsoft.AspNetCore.App"; public const string AspNetCoreAppPackageName = "Microsoft.AspNetCore.App";
public const string AspNetCoreAllPackageName = "Microsoft.AspNetCore.All"; public const string AspNetCoreAllPackageName = "Microsoft.AspNetCore.All";
[Theory] [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")]
// MemberData is used instead of InlineData here so we can access it in another test to // MemberData is used instead of InlineData here so we can access it in another test to
// verify that we are covering the latest release of .NET Core // verify that we are covering the latest release of .NET Core
[ClassData(typeof(SupportedNetCoreAppVersions))] [ClassData(typeof(SupportedNetCoreAppVersions))]
@ -29,14 +29,14 @@ namespace EndToEnd
ItRollsForwardToTheLatestVersion(NETCorePackageName, minorVersion); ItRollsForwardToTheLatestVersion(NETCorePackageName, minorVersion);
} }
[Theory] [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")]
[ClassData(typeof(SupportedAspNetCoreVersions))] [ClassData(typeof(SupportedAspNetCoreVersions))]
public void ItRollsForwardToTheLatestAspNetCoreAppVersion(string minorVersion) public void ItRollsForwardToTheLatestAspNetCoreAppVersion(string minorVersion)
{ {
ItRollsForwardToTheLatestVersion(AspNetCoreAppPackageName, minorVersion); ItRollsForwardToTheLatestVersion(AspNetCoreAppPackageName, minorVersion);
} }
[Theory] [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")]
[ClassData(typeof(SupportedAspNetCoreVersions))] [ClassData(typeof(SupportedAspNetCoreVersions))]
public void ItRollsForwardToTheLatestAspNetCoreAllVersion(string minorVersion) public void ItRollsForwardToTheLatestAspNetCoreAllVersion(string minorVersion)
{ {