From 69d4d21ee57d9cfa4e19b5be55ce61350dbf0f36 Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Mon, 8 Oct 2018 18:29:15 -0700 Subject: [PATCH] Disable implicit version tests (#10123), fix 3.0 implicit version --- build/MSBuildExtensions.targets | 10 +--------- test/EndToEnd/GivenFrameworkDependentApps.cs | 4 ++-- test/EndToEnd/GivenSelfContainedAppsRollForward.cs | 6 +++--- 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/build/MSBuildExtensions.targets b/build/MSBuildExtensions.targets index d6d13695d..1a2e75e2f 100644 --- a/build/MSBuildExtensions.targets +++ b/build/MSBuildExtensions.targets @@ -76,7 +76,7 @@ DefaultVersion="2.1.0" LatestVersion="2.1.5" /> @@ -88,14 +88,6 @@ TargetFrameworkVersion="2.1" DefaultVersion="2.1.1" LatestVersion="2.1.5"/> - - diff --git a/test/EndToEnd/GivenFrameworkDependentApps.cs b/test/EndToEnd/GivenFrameworkDependentApps.cs index 44b8b7ad1..03e8ee735 100644 --- a/test/EndToEnd/GivenFrameworkDependentApps.cs +++ b/test/EndToEnd/GivenFrameworkDependentApps.cs @@ -22,14 +22,14 @@ namespace EndToEnd ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.NETCorePackageName, minorVersion); } - [Theory] + [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")] [ClassData(typeof(SupportedAspNetCoreVersions))] public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreApp(string minorVersion) { ItDoesNotRollForwardToTheLatestVersion(GivenSelfContainedAppsRollForward.AspNetCoreAppPackageName, minorVersion); } - [Theory] + [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")] [ClassData(typeof(SupportedAspNetCoreVersions))] public void ItDoesNotRollForwardToTheLatestVersionOfAspNetCoreAll(string minorVersion) { diff --git a/test/EndToEnd/GivenSelfContainedAppsRollForward.cs b/test/EndToEnd/GivenSelfContainedAppsRollForward.cs index 846431527..081d711e0 100644 --- a/test/EndToEnd/GivenSelfContainedAppsRollForward.cs +++ b/test/EndToEnd/GivenSelfContainedAppsRollForward.cs @@ -20,7 +20,7 @@ namespace EndToEnd public const string AspNetCoreAppPackageName = "Microsoft.AspNetCore.App"; public const string AspNetCoreAllPackageName = "Microsoft.AspNetCore.All"; - [Theory] + [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")] // MemberData is used instead of InlineData here so we can access it in another test to // verify that we are covering the latest release of .NET Core [ClassData(typeof(SupportedNetCoreAppVersions))] @@ -29,14 +29,14 @@ namespace EndToEnd ItRollsForwardToTheLatestVersion(NETCorePackageName, minorVersion); } - [Theory] + [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")] [ClassData(typeof(SupportedAspNetCoreVersions))] public void ItRollsForwardToTheLatestAspNetCoreAppVersion(string minorVersion) { ItRollsForwardToTheLatestVersion(AspNetCoreAppPackageName, minorVersion); } - [Theory] + [Theory(Skip = "https://github.com/dotnet/cli/issues/10123")] [ClassData(typeof(SupportedAspNetCoreVersions))] public void ItRollsForwardToTheLatestAspNetCoreAllVersion(string minorVersion) {