CI to automate build of zotero tarball for zotero aport
https://gitlab.alpinelinux.org/alpine/aports/-/tree/master/testing/zotero
ff38ff5b9d
Well this was a wild one to debug.
Creator fields were only initialized for autocomplete due to a series of
>10-year-old bugs:
1) In `showEditor()`, `Zotero.ItemFields.isAutocompleteField(fieldName)`
was called for creator fields, which would pass, e.g.,
`creator-0-lastName`.
2) In `isAutocompleteField()`, `ItemFields.getName()` would normalize
`creator-0-lastName` to `false`, since it's not a valid field.
3) `isAutocompleteField()` listed `place` as a base field despite its
not having any mapped fields, so when `getTypeFieldsFromBase()` was
called on it, the return value would be `false`, which would be added
to the list of autocomplete fields, which would mean that the
normalized field of `false` from `creator-0-lastName` would match,
which would mean that `isAutocompleteField('creator-0-lastName')`
would always return true...as long as `place` never gained a mapped
field.
Except `isAutocompleteField()` wasn't supposed to be the test for
initializing autocomplete for creator fields anyway -- `fieldName ==
'creator'` was. But `fieldName` is something like `creator-0-lastName`,
not `creator`, which meant that that test always failed, which meant
that if `place` did gain a mapped field, both tests would fail, which
would cause the creator field not to be initialized for autocomplete,
which would cause it to break as soon as you started to type into it.
This fixes that.
|
||
|---|---|---|
| .github | ||
| chrome | ||
| components | ||
| defaults/preferences | ||
| note-editor@7f246a30eb | ||
| pdf-reader@c430c98431 | ||
| pdf-worker@ab37454b0f | ||
| resource | ||
| scripts | ||
| scss | ||
| styles@139d52a0f1 | ||
| test | ||
| translators@fc2a1caf28 | ||
| .babelrc | ||
| .eslintignore | ||
| .eslintrc | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| chrome.manifest | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| install.rdf | ||
| package-lock.json | ||
| package.json | ||
| README.md | ||
| update.rdf | ||
Zotero
Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.
Please post feature requests or bug reports to the Zotero Forums. If you're having trouble with Zotero, see Getting Help.
For more information on how to use this source code, see the Zotero wiki.