mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
zotero/test/tests
History
Dan Stillman 6942506eba Rework object type checking in items list 
a532cfb475 added `isCollection()`, `isSearch()`, and `isItem()` methods
to data objects to handle collections and searches in the trash, with
`isItem()` checking whether `._ObjectType` was `Item`. That left out
feed items (`._ObjectType` == `FeedItem`), and when c384fef867 made
`getSelectedItems()` return only items, it used `isItem()`, so feed
items were excluded, which broke feed-item toggling between read and
unread [1] and possibly some other things.

The simple fix would be to make `isItem` match feed items as well (which
could potentially fix other bugs related to feed items), but there was
actually no need to add new methods (which can get confused with
`CollectionTreeRow` methods) when we can just check the object type with
`obj instanceof Zotero.Item`, which gets the benefit of inheritance and
matches `Zotero.FeedItem` instances as well.

[1] https://forums.zotero.org/discussion/115571/cannot-change-the-status-of-title-in-subscribtion
2024-06-28 02:09:49 -04:00
..
data Missing file for 639b4b5623 2024-06-15 00:45:28 -04:00
.eslintrc Add separate .eslintrc for tests 2019-09-16 01:28:52 -04:00
advancedSearchTest.js Add missing await in advanced-search test 2024-02-01 00:55:02 -05:00
annotationsTest.js Add collectionID option to EditorInstance.createNoteFromAnnotations() 2022-09-12 15:54:03 -04:00
attachmentsTest.js Trim spaces from values in getFileBaseNameFromItem (#3711) 2024-02-19 04:43:19 -05:00
bibliographyTest.js Fix test for opening the Cite prefpane when clicking Manage Styles… 2023-04-15 03:35:17 -04:00
browserDownloadTest.js Use local HTTP server for Zotero.BrowserDownload test 2024-06-15 00:40:03 -04:00
cachedTypesTest.js Fix primary item types not appearing in More menu when not in MRU list 2021-03-29 01:41:37 -04:00
citeprocRsBridgeTest.js Fix broken tests in 000599b 2022-02-21 14:06:20 +02:00
citeTest.js Reset Zotero.locale to 'en-US' after cite test 2022-08-11 03:57:20 -04:00
collectionsTest.js Fix collections in trash showing up in menus 2024-06-22 16:33:11 -04:00
collectionTest.js Fix collections in trash showing up in menus 2024-06-22 16:33:11 -04:00
collectionTreeRowTest.js Include proper test for b373291c02 for #2771 2022-08-19 12:05:30 -04:00
collectionTreeTest.js Fix failing test from 173f4c491e 2024-06-24 03:01:57 -04:00
concurrentCallerTest.js Try to prevent ConcurrentCaller from failing CI (#4097) 2024-05-07 19:38:44 -04:00
creatorsTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
dataDirectoryTest.js Clear Zotero.skipLoading after data directory tests 2023-05-25 05:45:53 -04:00
dataObjectsTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
dataObjectTest.js Disallow unowned group annotation edits, but allow deletions 2022-01-31 06:48:05 -05:00
dataObjectUtilitiesTest.js Don't repeatedly upload relations 2022-08-22 01:15:21 -04:00
dateTest.js Update utilities submodule and date-parsing tests 2022-08-11 02:36:04 -04:00
dbTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
debugTest.js Test debug output logging again 2023-05-24 20:59:29 +03:00
dictionariesTest.js fx-compat: Fix dictionaries tests 2022-06-19 04:16:53 -04:00
duplicatesTest.js Merge attachments and update notes (#2336) 2022-03-09 17:26:26 -05:00
feedItemsTest.js fx-compat: Fix feed test using Array.map() 2022-06-19 15:09:23 -04:00
feedItemTest.js Update utilities submodule and date-parsing tests 2022-08-11 02:36:04 -04:00
feedReaderTest.js Feeds: De-prioritize prism:copyright 2024-05-23 14:16:38 -04:00
feedsTest.js Feed import: Don't fail on OPML entry with no title or text 2022-08-11 02:28:03 -04:00
feedTest.js Don't reset isRead when feed item metadata changes (#2215) 2021-11-05 23:16:12 -04:00
fileHandlersTest.js Update reader and pdf-worker submodules and partially disable one test 2024-05-28 17:18:56 +03:00
fileInterfaceTest.js Tests: Use select() instead of selectCollection()/selectSearch() 2024-06-24 04:40:12 -04:00
fileTest.js Fix file:// URI handling in getBinaryContentsAsync() 2023-11-10 15:58:53 -05:00
folderImportTest.js Temporarily disable folder import #2862 2023-03-23 14:16:51 +01:00
fulltextTest.js Adjust fulltext test 2024-05-28 17:32:03 +03:00
groupsTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
groupTest.js Tweak test syntax that breaks with current version of chai-as-promised 2017-06-01 11:36:18 -04:00
HiddenBrowserTest.js HiddenBrowser: Test download blocking 2024-05-07 11:17:30 -04:00
httpTest.js fx-compat: Run translation and SingleFile in [hidden] browser 2023-04-14 11:44:44 -04:00
hyphenationTest.js Fix segfault when hyphenating text in main process (#3388) 2023-09-14 02:48:50 -04:00
importExportTest.js fx-compat: Fix XMLSerializer calls 2023-05-22 01:34:41 -04:00
integrationTest.js Link Mendeley citations in documents to imported items. Closes #2622 2022-11-29 16:27:19 +02:00
intlTest.js Refactor l10n code. Remove use of react-intl. (#2975) 2023-02-10 10:26:49 +02:00
itemFieldsTest.js Fix Zotero.ItemFields.getBaseIDFromTypeAndField() 2015-05-27 05:01:48 -04:00
itemPaneTest.js Rework object type checking in items list 2024-06-28 02:09:49 -04:00
itemsTest.js Clarify comment for numDistinctFileAttachmentsForLabel() test 2024-05-19 00:54:13 -04:00
itemTest.js Strip line and paragraph separators in filenames 2024-04-28 07:51:25 -04:00
itemTreeTest.js Add recursiveCollections test for items in deleted subcollections 2024-06-27 05:10:59 -04:00
librariesTest.js Implement library.isGroup property, which was never properly implemented 2021-07-07 01:43:22 -04:00
libraryTest.js XUL -> JS tree megacommit 2021-08-21 06:58:12 -04:00
libraryTreeTest.js Tests: Don't auto-select collections and searches after creation 2024-06-24 02:45:20 -04:00
lookupTest.js Tests: Don't auto-select collections and searches after creation 2024-06-24 02:45:20 -04:00
mendeleyImportTest.js Mendeley importer: Fix issue with empty tags (#3018) 2023-04-06 17:10:13 +02:00
mimeTest.js Add EPUB format to Zotero.MIME 2023-08-07 16:07:52 -04:00
noteeditorTest.js Remove tags-box tests in note editor tests 2024-01-24 23:32:20 -05:00
notifierTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
openurlTest.js Use best first creator for OpenURL author, not just first position 2016-07-11 06:30:55 -04:00
pdfReaderTest.js Disable PDF reader tests 2023-08-07 16:27:23 -04:00
preferences_advancedTest.js Test debug output logging again 2023-05-24 20:59:29 +03:00
preferences_syncTest.js Clear sync error and start sync after logging in in prefs (#2802) 2022-10-16 15:47:54 -04:00
profileTest.js Point other profiles to new data dir after migration (+ code reorg) 2016-11-27 00:17:56 -05:00
protocolHandlerTest.js Close window after protocol handler tests 2019-08-03 02:48:01 -04:00
proxyTest.js Import URL from XPCOM code instead of relying on window for Proxy code 2022-11-22 15:58:49 +02:00
quickCopyTest.js Markdown note export (#2214) 2021-12-15 06:10:58 -05:00
recognizeDocumentTest.js Tests: Don't auto-select collections and searches after creation 2024-06-24 02:45:20 -04:00
relatedboxTest.js Sort related items by title 2024-06-26 01:02:07 -04:00
relationsTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
RemoteTranslateTest.js Displays a browser window to clear captcha when saving attachments. (#3526) 2023-12-27 04:43:50 -05:00
retractionsTest.js CI: Re-enable retractions tests 2024-04-11 06:09:12 -04:00
schemaTest.js Better way of skipping migration of Place and Date from Extra 2023-04-01 04:52:30 -04:00
searchTest.js trash functionality for collections and searches (#3307) 2024-06-17 23:14:21 -04:00
server_connectorIntegrationTest.js Add tests for HTTP integration endpoints 2024-06-17 12:45:28 +03:00
server_connectorTest.js Tests: Remove some unnecessary waitForItemsLoad() calls 2024-06-24 02:45:20 -04:00
server_integrationTest.js Add tests for HTTP integration endpoints 2024-06-17 12:45:28 +03:00
server_localAPITest.js Local API: Return 404 for unknown group library 2024-06-19 00:40:13 -04:00
serverTest.js Fix server not handling empty body in multi-part request 2020-10-12 15:06:11 -06:00
storageLocalTest.js fx-compat: Update conflict resolution merge window (#3090) 2023-04-29 03:13:53 -04:00
storageRequestTest.js Avoid a warning from a storageRequest test from the item not existing 2017-05-23 02:12:00 -04:00
styleTest.js Improve test for event-title substitution 2022-08-11 03:57:25 -04:00
supportTest.js Massively speed up tests 2021-06-24 06:10:40 -04:00
syncAPIClientTest.js Send Zotero-Schema-Version header with API requests 2021-03-02 17:36:05 -05:00
syncedSettingsTest.js Fixes feed sync bugs after conflicts. (#1074) 2016-08-16 03:03:42 -04:00
syncEngineTest.js Fix test failure calling item.toResponseJSON() with no library set 2024-06-12 05:50:36 -04:00
syncEventListenersTest.js Trigger auto-sync after item deletion 2021-05-14 03:49:26 -04:00
syncFullTextEngineTest.js Update full-text sync tests after 2ecfff6681 2017-10-20 05:23:13 -04:00
syncLocalTest.js fx-compat: Update conflict resolution merge window (#3090) 2023-04-29 03:13:53 -04:00
syncRunnerTest.js fx-compat: long tag fixer (#2649) 2023-03-16 21:20:11 -04:00
tagsboxTest.js fix tagsbox enter glitch (#4160) 2024-05-23 00:16:36 -04:00
tagSelectorTest.js Tests: Don't auto-select collections and searches after creation 2024-06-24 02:45:20 -04:00
tagsTest.js fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
translateTest.js fx115: Update lots of OS.File/OS.Path uses 2024-03-30 00:58:54 -04:00
translatorsTest.js Remove accidental .only() in test from fdcd4e51c5 2021-07-12 15:25:17 -04:00
uriTest.js Add Zotero.URI.getURIItemLibraryKeyFromDB() 2017-05-19 12:11:21 -04:00
utilities_internalTest.js Fix Utilities.Internal.md5Async() on missing files and empty strings 2024-05-08 01:16:37 -04:00
utilitiesSubmoduleTest.js Update utilities, move tests, add to CI (#2584) 2022-04-30 04:55:11 -04:00
webdavTest.js fx115: Update lots of OS.File/OS.Path uses 2024-03-30 00:58:54 -04:00
zfsTest.js fx115: Update lots of OS.File/OS.Path uses 2024-03-30 00:58:54 -04:00
zoteroPaneTest.js Fix bug in #_setHighlightedRowsCallback() test 2024-06-24 04:42:59 -04:00
zoteroTest.js Include "Zotero/[version]" in file sync requests 2021-12-27 15:54:12 -05:00