ef82becf00
We follow a different merge procedure for each attachment type: - For PDF attachments, compare by MD5. If no match, get the top 50 words in the attachment's text and hash those, then check again for a match. Update references to item keys in notes and annotations. - For web (snapshot / link) attachments, compare by title and URL. Prefer a title + URL match but accept a title-only match. - For other attachment types, keep all attachments from all items being merged. Also: - Move most merge tests from Duplicates to Items#merge(). It just doesn't make sense to worry about the UI in these.
85 lines
2.3 KiB
JavaScript
85 lines
2.3 KiB
JavaScript
"use strict";
|
|
|
|
describe("Duplicate Items", function () {
|
|
var win, zp, cv;
|
|
|
|
before(function* () {
|
|
yield resetDB({
|
|
thisArg: this,
|
|
skipBundledFiles: true
|
|
});
|
|
|
|
Zotero.Prefs.clear('duplicateLibraries');
|
|
win = yield loadZoteroPane();
|
|
zp = win.ZoteroPane;
|
|
cv = zp.collectionsView;
|
|
});
|
|
beforeEach(function* () {
|
|
return selectLibrary(win);
|
|
})
|
|
after(function () {
|
|
win.close();
|
|
});
|
|
|
|
async function merge(itemID) {
|
|
var userLibraryID = Zotero.Libraries.userLibraryID;
|
|
|
|
var selected = await cv.selectByID('D' + userLibraryID);
|
|
assert.ok(selected);
|
|
await waitForItemsLoad(win);
|
|
|
|
// Select the first item, which should select both
|
|
var iv = zp.itemsView;
|
|
var row = iv.getRowIndexByID(itemID);
|
|
var promise = iv.waitForSelect();
|
|
clickOnItemsRow(win, iv, row);
|
|
await promise;
|
|
|
|
// Click merge button
|
|
var button = win.document.getElementById('zotero-duplicates-merge-button');
|
|
button.click();
|
|
|
|
await waitForNotifierEvent('refresh', 'trash');
|
|
}
|
|
|
|
describe("Merging", function () {
|
|
it("should merge two items in duplicates view", function* () {
|
|
var item1 = yield createDataObject('item', { setTitle: true });
|
|
var item2 = item1.clone();
|
|
yield item2.saveTx();
|
|
var uri2 = Zotero.URI.getItemURI(item2);
|
|
|
|
yield merge(item1.id);
|
|
|
|
// Items should be gone
|
|
var iv = zp.itemsView;
|
|
assert.isFalse(iv.getRowIndexByID(item1.id));
|
|
assert.isFalse(iv.getRowIndexByID(item2.id));
|
|
assert.isTrue(item2.deleted);
|
|
var rels = item1.getRelations();
|
|
var pred = Zotero.Relations.replacedItemPredicate;
|
|
assert.property(rels, pred);
|
|
assert.equal(rels[pred], uri2);
|
|
});
|
|
|
|
it("should combine collections from all items", function* () {
|
|
var collection1 = yield createDataObject('collection');
|
|
var collection2 = yield createDataObject('collection');
|
|
|
|
var item1 = yield createDataObject('item', { setTitle: true, collections: [collection1.id] });
|
|
var item2 = item1.clone();
|
|
item2.setCollections([collection2.id]);
|
|
yield item2.saveTx();
|
|
|
|
yield merge(item1.id);
|
|
|
|
// Items should be gone
|
|
var iv = zp.itemsView;
|
|
assert.isFalse(iv.getRowIndexByID(item1.id));
|
|
assert.isFalse(iv.getRowIndexByID(item2.id));
|
|
assert.isTrue(item2.deleted);
|
|
assert.isTrue(collection1.hasItem(item1.id));
|
|
assert.isTrue(collection2.hasItem(item1.id));
|
|
});
|
|
});
|
|
});
|