mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
12465 commits 9 branches 364 tags 290 MiB
Commit graph

8592 commits

Author SHA1 Message Date
Adomas Venčkauskas
a4eafd0307 Fix wrong given name disambiguation after editing author for citeproc-js 
Closes #2870
 2022-10-25 14:55:16 +03:00
Dan Stillman
8a15e5abe0 Don't localize "Markdown" in Quick Copy settings 2022-10-24 19:53:42 -04:00
Dan Stillman
159c112257 Add Zotero.Utilities.Internal.stringWithColon() for localized colons 
Generally just a colon, but, e.g., French adds a space before it. We'll
want to replace uses of `punctuation.colon` with this.
 2022-10-24 19:49:10 -04:00
Dan Stillman
c4876fd5ae Adjust layout of Quick Copy note format options 
Also:

- Hide format options until translators are loaded (since otherwise
  the checkboxes don't have labels and the layout is messed up)
- Remove unnecessary "zotero-" prefix from the new elements
 2022-10-22 16:41:48 -04:00
Dan Stillman
7fcc1d35a4 Reset note Quick Copy pref on upgrade if set to Markdown + Rich Text 
The default JSON pref value used spaces, but changing the drop-down
resulted in a version without spaces, so simply changing the default to
include the new link options wouldn't change all existing installs and
the "Include App Links" checkbox wouldn't show as enabled for Markdown.
This adds a pref migration step to reset the pref to the new default if
it's set to Markdown + Rich Text, regardless of whitespace differences.
 2022-10-22 16:41:48 -04:00
Martynas Bagdonas
d0d3ed731d Add "Include Zotero Links" option for note export and QuickCopy 
Fixes #2349
 2022-10-22 16:41:48 -04:00
Dan Stillman
f2bfaeb7a9 Fix error message for invalid field in Item.setField() 
The error message was showing a field instead of an item type.

https://forums.zotero.org/discussion/100598/error-1533410729-impossible-to-correct-date-field-in-items-added-with-zotero-conector-ver-6-0-15
 2022-10-22 05:28:02 -04:00
Adomas Ven
2fa67bae64
Adds support for merging adjacent citations (#2875) 2022-10-21 03:17:35 -04:00
Dan Stillman
2b9e9c174f Don't match all attachments with annotations for "not" search conditions 
Fixes #2867
 2022-10-17 23:59:29 -04:00
Dan Stillman
aa0ef7012c PDF reader: Hide "Rotate Page 180°" menu option for now 
Rotating will speed up with Zotero 7, so maybe we can do without this.
 2022-10-17 23:59:07 -04:00
Dan Stillman
73306ee5fb PDF reader: Add "Page" to rotate menu options for clarity 2022-10-17 23:58:52 -04:00
Martynas Bagdonas
d8d6054927 Add rotation options to Edit menu to rotate the current PDF page 2022-10-17 12:26:47 +03:00
Martynas Bagdonas
55095ba354 Reduce loaded tabs limit if the system has 8 GB or less memory 2022-10-14 11:13:02 +03:00
Dan Stillman
3582405f55 Default to UTF-8 when indexing text file without detected charset 
https://forums.zotero.org/discussion/94637/indexing-of-markdown-plain-text-attachments-with-md-extension
 2022-10-12 05:01:10 -04:00
Abe Jellinek
618e71b5f1 Fix last editpane tab being misaligned vertically (#2864) 2022-10-11 10:49:30 -04:00
Martynas Bagdonas
af436d34a8 Add pdf-reader annotation creation test 2022-10-10 16:53:42 +03:00
Dan Stillman
e45becce2a Tweak text in LABD auto-relinking dialogs (#2374, #2092) 2022-10-08 02:29:39 -04:00
Abe Jellinek
fb4f7b7932 Automatically relink attachments from LABD (#2374) 
Fixes #2092
 2022-10-08 02:29:31 -04:00
Dan Stillman
fd8aa4433c Change connector server response to "Zotero is running" 
People are confused by "Zotero Connector Server is Available". I'm not
sure if this will be any better, but not mentioning the connector might
help -- that seems to be part of the problem.

We could display a longer message with a link to
https://www.zotero.org/support/kb/connector_zotero_unavailable, but this
is the /ping page that gets hit constantly, so it seems like we should
keep it short (though probably it doesn't make a difference).
 2022-10-07 01:31:59 -04:00
Martynas Bagdonas
29dd0cf5dc Don't allow to rotate or delete pages for read-only PDF 2022-10-06 18:00:32 +03:00
Martynas Bagdonas
28329aa785 Fix annotation image saving to cache for read-only annotations 2022-10-06 17:32:51 +03:00
Martynas Bagdonas
c5d418fc16 Fix annotation saving regression 2022-10-06 16:43:58 +03:00
Martynas Bagdonas
e9c6c76e79 Properly handle errors when trying to open too large (>2GB-1) PDF file 2022-10-06 10:57:04 +03:00
Martynas Bagdonas
b7cc1d549b Fix pref observer handler unregistering 2022-10-05 14:09:39 +03:00
Martynas Bagdonas
b594ad0b0a Allow importing annotations in group libraries 2022-10-04 14:22:54 +03:00
Martynas Bagdonas
4dd1851140 Don't allow pdf-reader to set annotation author name 
Fixes the issue when your own created annotation becomes grayish and indicates that it was modified by another user.
 2022-10-04 13:59:16 +03:00
Martynas Bagdonas
006dd20d5b Re-render annotation images when rotating a page 
Fixes #2824
 2022-10-03 17:03:32 +03:00
Adomas Venčkauskas
55afe7c08d Fix item list row text not read when using non-contiguous kb selection 
Closes #2830
 2022-10-03 15:20:38 +03:00
Dan Stillman
9fadfac7ee Add 15 and 16 as note font size options in menu 
https://forums.zotero.org/discussion/100079/notebook-fonts
 2022-10-03 06:43:28 -04:00
Martynas Bagdonas
38ae3a2600 Remove PDF view rotation options 2022-10-03 13:14:37 +03:00
Dan Stillman
99084084d4 Remove default OpenURL gateway 
https://www.worldcat.org/registry/gateway is no longer supported -- see
https://forums.zotero.org/discussion/comment/418373/#Comment_418373 for
details

If no resolver is selected, show an error on "Library Lookup" with a
button to open the prefs.
 2022-09-30 16:08:12 -04:00
Dan Stillman
64047f181a Remove stray "aaa" in "Split Horizontally" in PDF window 
From 12b1897478
 2022-09-30 15:33:00 -04:00
Dan Stillman
12b1897478 Swap "Split Vertically" and "Split Horizontally" in PDF reader 2022-09-30 04:22:48 -04:00
Martynas Bagdonas
4fdf43ed92 Prevent error when creating a note from annotations that have ink 2022-09-30 09:44:27 +03:00
Martynas Bagdonas
9691fcafc2 Import external annotations before trying to add a note from annotations 2022-09-30 09:40:35 +03:00
Martynas Bagdonas
6aad0cbb9c
Add split view for PDF reader (#2832) 2022-09-29 13:25:58 +03:00
Dan Stillman
677499865a Update translators and CSL locales 2022-09-28 04:50:28 -04:00
Dan Stillman
2271913e49 Add Number as items list column option 
https://forums.zotero.org/discussion/99844/add-columns-to-desktop-app-report-number
 2022-09-22 01:48:15 -04:00
Dan Stillman
f179f0a54f Additional tweaks for creator button keyboard access (#2826) 
- Open creator type menu on ArrowUp as well
- Fix outline on Windows/Linux
- Don't show focus ring on hover, since we already show a background
 2022-09-21 23:16:53 -04:00
Tom Najdek
ea09aac616 Make creator buttons accessible via keyboard #999 2022-09-21 23:16:53 -04:00
Martynas Bagdonas
0d09618865 Fix focusContextPane error when pressing tab in standalone PDF window 
Fixes #2823
 2022-09-15 11:59:03 +03:00
Dan Stillman
b96fcd41b1 Update translate submodule 2022-09-15 01:06:47 -04:00
Martynas Bagdonas
c13d17b5e6 Fix PDF reader sometimes showing UTC time and sometimes local 2022-09-13 16:38:17 +03:00
Martynas Bagdonas
eb255c5868 Convert Mendeley colors to equivalent Zotero colors on PDF open 
Fixes #2820
 2022-09-13 14:35:16 +03:00
Tom Najdek
88217492f9
Map annotation colors colors on import #2819 (#2822) 2022-09-12 19:57:24 -04:00
Martynas Bagdonas
64897455f4 Adjust PDF reader and context pane UI based on font size pref 
Fixes #2809
 2022-09-09 18:03:20 +03:00
Abe Jellinek
5015b0e4cc Hide "Find Available PDF" for feed items (#2807) 2022-09-07 10:07:43 -04:00
Martynas Bagdonas
a2d378448a Add context menu options to copy/save image from pdf-reader/note-editor 
Fixes #2664
 2022-09-06 16:35:14 +03:00
Dan Stillman
66fccec6b4 Add "Create Note from Annotations" option to items list context menu 
To allow creation of a standalone note with annotations from all the
selected top-level items and/or attachments. Annotations will be sorted
by the order of the items in the items list.

"Add Note from Annotations" remains when a single regular item or one or
more attachments under a single regular item are selected.
 2022-09-05 10:37:07 -04:00
Dan Stillman
894309d061 Add collectionID option to EditorInstance.createNoteFromAnnotations() 
For adding a standalone note to the current collection
 2022-09-05 10:37:07 -04:00
Dan Stillman
b24c7577ec Rename Zotero.Items::keepParents() to keepTopLevel() 
So that it works for more than two levels of items

Also fix a bug where the parent item could be returned more than once if
multiple child items were selected.
 2022-09-05 10:37:07 -04:00
Dan Stillman
ca4ced1e9f Add Zotero.Item::topLevelItem and Zotero.Items.getTopLevel(items) 2022-09-05 10:37:07 -04:00
Martynas Bagdonas
6646be66d0 EditorInstance.createNoteFromAnnotations(): Handle multiple attachments 2022-09-05 10:37:07 -04:00
Martynas Bagdonas
f893206dfd Allow inserting images over context menu 
Fixes #2759
 2022-09-01 11:49:30 +03:00
Dan Stillman
91ae576074 Fix HTTP.request() 5xx handling with errorDelayMax=0 
This was causing delay-less infinite loops for OPTIONS requests to Box,
which are returning 502 errors.
 2022-08-29 23:44:55 +02:00
Abe Jellinek
c255104ada duplicateAndConvertSelectedItem: Don't copy abstracts (#2799) 2022-08-29 16:27:26 -04:00
Dan Stillman
79246196ac Use items-list sort order for report from collection or saved search 
https://forums.zotero.org/discussion/99284/exporting-a-report-sorted-by-first-date

Regression from HTML tree
 2022-08-25 00:47:57 -04:00
Adomas Venčkauskas
262e1964ae Fix SingleFile snapshot saving stalling in Firefox Connector 
Update SingleFile submodule
 2022-08-24 11:48:02 +03:00
Dan Stillman
f4dfea6849 Don't repeatedly upload relations 
Fixes #2772
 2022-08-22 01:12:31 -04:00
Tom Najdek
35a1bb20cb Make citavi annotations importer more resilient 2022-08-19 11:20:24 -04:00
Tom Najdek
8c80ea431e Fix importing Citavi annotations in some cases 2022-08-19 11:20:24 -04:00
Dan Stillman
b373291c02 Fixed filed items with annotations appearing in Unfiled Items 
Fixes #2771

Regression from 20c6fe67
 2022-08-19 00:15:55 -04:00
Abe Jellinek
3391f3bc99
Empty Trash: Visually remove deleted items, refresh icon (#2606) 
There were a few problems causing the incorrect behavior:
1. Rows were being removed only if they had no non-deleted children, which
   wasn't the right check. We want to remove all rows with no *deleted*
   children.
2. Children of the removed rows weren't being removed with them.
3. We weren't invalidating the tree (which _removeRows() doesn't do).

Also:

* Erase trashed annotation after getAnnotations() test

Because ItemTree#notify() doesn't yet correctly handle refresh events on
parent items that are themselves children (three-level nesting: item ->
attachment -> annotation), this test was causing a failure in
itemTreeTest.js.
 2022-08-18 21:14:34 -04:00
Martynas Bagdonas
6ca854a018 Fix navigation to annotation when opening an unloaded PDF reader tab 
Regression from 142e3b09
 2022-08-18 10:21:37 +03:00
Martynas Bagdonas
fa32eb6790 Fix regression for broken "Snow in Page" 
Fixes #2764
Regression from 7ec54fd
 2022-08-18 10:21:37 +03:00
Abe Jellinek
96c4427d6c Scaffold: Non-async detectWeb and async scrape by default 
We don't usually want an async detectWeb, since HTTP requests should only be
used there in very exceptional cases. We do usually want an async scrape (and we
were already - mistakenly - awaiting it).
 2022-08-17 16:34:19 -04:00
Dan Stillman
20c6fe6737 Match parent attachments for annotation tags 
Expose annotation tags in tag selector and match parent attachments when
filtering/searching

This also fixes searching for annotation text or comments when using
Everything quick search.

This is temporary until we display annotations in the items list
directly.
 2022-08-16 22:56:39 -04:00
Dan Stillman
85b0c9dbad Fix importing of standalone attachments without URLs 
And allow `importSnapshotFromFile()` without `parentItemID` or
`libraryID`, which is more consistent with other attachment functions

Follow-up to 318e4852e9

https://forums.zotero.org/discussion/comment/414802/#Comment_414802
 2022-08-14 05:06:27 -04:00
Dan Stillman
318e4852e9 Fix importing of standalone attachments 
Maybe has been broken for years?

https://forums.zotero.org/discussion/99020/warning-data-loss-when-exporting-collections
 2022-08-13 16:23:00 -04:00
Dan Stillman
3dc3359cff Don't relate book sections to each other when creating from book 
Fixes #2757
 2022-08-13 05:45:23 -04:00
Dan Stillman
b505c630d3 Fix copying of standalone attachments between libraries 
Regression in f684984b07 (maybe a race condition)
 2022-08-13 02:00:41 -04:00
Abe Jellinek
d4a7de2e8d
Add Book -> Book Section and Book Section -> Book to context menu (#2755) 2022-08-11 16:40:27 -04:00
Adomas Venčkauskas
864fd03c87 Prevent singlefile config from overwriting the Zotero.SingleFile namespace 2022-08-11 13:44:48 +03:00
Adomas Venčkauskas
d3cb7c86d9 Update SingleFile config for current version 
They got updated upstream and the backwards-compat code
does not run for the way we execute singlefile

See https://github.com/gildas-lormeau/SingleFile/issues/1021
Addresses https://github.com/zotero/zotero-connectors/issues/398
 2022-08-11 13:43:39 +03:00
Martynas Bagdonas
e4e3c72036 Fix PDF reader selector popup that was never opening 2022-08-11 12:18:32 +03:00
Martynas Bagdonas
0857cefb0c Fix regression preventing opening PDF reader window when the tab is open 2022-08-11 12:18:32 +03:00
Dan Stillman
9b7b4fe134 Improve test for event-title substitution 
And add comments

Follow-up to 20d0f103f
 2022-08-10 01:34:57 -04:00
Dan Stillman
20d0f103fd Automatically substitute event-title for event in styles 
Stopgap until styles are updated in citation-style-language/styles#6151
 2022-08-10 01:01:48 -04:00
Abe Jellinek
87455d28c3 Item box: Fix fieldMode resetting after editor hidden twice 
hideEditor() called switchCreatorMode() too early, setting the fieldMode
attribute on the soon-to-be-discarded textbox instead of the label
replacing it. Then, showing the editor a second time would carry over an
empty fieldMode attribute from the label to the new textbox. Hiding that
editor would update the creator in the item to fieldMode = 0 and trigger
a save.

Moving the switchCreatorMode() call does the trick, and the flex
settings changes still work fine when made there.
 2022-08-08 10:56:56 -04:00
Abe Jellinek
2048319541
Advanced Search: Make sure items are loaded (#2743) 2022-08-06 15:00:33 -04:00
Dan Stillman
d03b0a716d Don't preselect Act for multiple sources in classic citation dialog 
"Multiple Sources…" wasn't properly handled by 629892b0b8

https://forums.zotero.org/discussion/98877/act-instead-of-page
https://twitter.com/drezvera99/status/1554521940684984320
 2022-08-06 02:29:26 -04:00
Abe Jellinek
bb2b37a73a Item box: Prevent tabbing to hidden fields 
This one's probably been around for a while! Reproduce by creating an
item with a fieldMode = 1 creator, tabbing past the creator, and then
shift-tabbing back to it. Your cursor will end up in the invisible first
name field and further shift-tabs can't move it past.

Cherry-picked from fx102: 080ada78ee
 2022-08-05 16:31:09 -04:00
Martynas Bagdonas
7ec54fdaa9 Select existing unloaded tab instead of opening a new one 
Fixes #2740
 2022-08-05 18:22:30 +03:00
Martynas Bagdonas
5a659b070d Allow to scroll tabs with mouse wheel 
Fixes #2724
 2022-07-29 13:06:33 +03:00
Abe Jellinek
ad96323881
Duplicates Merge: Preserve embedded annotations (#2728) 2022-07-29 05:06:44 -04:00
Adomas Venčkauskas
fc0f6157d0 Do not load-timeout on browser PDF download during content load 
Closes #2726
 2022-07-26 13:49:23 +03:00
Martynas Bagdonas
6733f2edca Freeze note schema version to 8 
We can do it because it was only used to create a note from annotations.

No need to update schema version in Zotero client, unless using new
features when creating a note from annotations.
 2022-07-25 18:04:00 +03:00
Martynas Bagdonas
e1997620a4 Fix regression that prevents showing the last selected tab on startup 
Fixes #2723
 2022-07-25 11:51:05 +03:00
Martynas Bagdonas
0785b3a086 Fix regression that prevents showing new notes in contextPane notes list 2022-07-21 13:27:32 +03:00
Adomas Venčkauskas
ba5cb7d5c6 Fixes some assets not being saved with SingleFile snapshots 
Part of zotero/zotero-connectors#394

When saving an item (e.g. on arxiv) with a site translator, the
translator may add a custom snapshot attachment URL which does not match
the translation URL (the URL in the browser where translation was
initiated) in which case Zotero handles snapshot saving. Zotero loads
the page in a background browser. By default images are not loaded in
this browser. SingleFile due to CORS restrictions has to refetch all
resources that are not from the same domain or subdomain, but uses
pre-loaded resources (images) from the same domain. Before this change
any images that were from the same domain as the saved website were not
saved in the snapshot. This commit fixes that.
 2022-07-20 14:28:56 +03:00
Adomas Venčkauskas
d822da4c06 Changes for updated SingleFile submodule 2022-07-20 14:28:56 +03:00
Dan Stillman
6921268dc0 Localize "Export PDF…" menu option 
Fixes #2710
 2022-07-20 01:04:00 -04:00
Dan Stillman
5c61815f36 Update translate submodule 2022-07-18 19:43:18 -04:00
Dan Stillman
b5ca5aed3a Update submodules 2022-07-18 19:14:24 -04:00
Dan Stillman
9d0cd005f8 Increase Mendeley API timeout to 60 seconds 
To see if we can fix the 30-second timeout here:

https://forums.zotero.org/discussion/comment/412750/#Comment_412750
 2022-07-18 08:29:45 -04:00
Dan Stillman
98d6f40e4a Add warning in toolbar for 'dev' channel builds 2022-07-16 04:19:42 -04:00
Martynas Bagdonas
2cad5b00d1 Use Quick Copy (Markdown) for direct plain-text copying from note-editor 
Fixes #2505
 2022-07-15 15:06:19 +03:00
Abe Jellinek
95239db0fd Prevent deleting My Publications 
Previously showed a blank confirmation dialog and logged an error.
 2022-07-13 16:23:50 -04:00
Martynas Bagdonas
4c063e7b6e Prevent delayed context pane expansion and pdf-reader rerender/resize when switching from library tab 2022-07-12 18:00:21 +03:00
Martynas Bagdonas
07f1517712 Don't include quotes when {{highlight}} is placed in a blockquote 
Fixes #2697
 2022-07-12 12:12:21 +03:00