Commit graph

5007 commits

Author SHA1 Message Date
Aurimas Vinckevicius
9ee67ca291 Disable ZSA ping from bookmarklet in non-IE browsers
This means that bookmarklet will only save to server.
2014-12-09 13:12:05 -06:00
Dan Stillman
e3d7101923 Update version 2014-12-02 00:26:41 -05:00
Dan Stillman
d894fdb1d4 Fix citation list generation via right-click and quick copy
Broken by 523724185

Not sure if cslEngine.opt.class is a safe way to get the class. @fbennett?
2014-12-01 17:12:07 -05:00
Dan Stillman
0fd0da2903 Fix "getItemAtRow(...) is undefined" error for some item modifications
Since 67c63a29
2014-12-01 16:51:11 -05:00
Simon Kornblith
01c80610b4 Maybe fix for Firefox 31
Still need to test more comprehensively
2014-12-01 03:17:03 -05:00
Simon Kornblith
0cd183613f Fix for Firefox 34
Passing sandboxes between translators became difficult. This change
loads all translators in the same sandbox, using the same ugly hack as
in the connectors to get us close enough to being able to load
translators into separate scopes for things to work.

Conflicts:
	chrome/content/zotero/xpcom/translation/translate.js
2014-12-01 02:48:53 -05:00
Dan Stillman
524a71cfe8 Fix sync error with missing base directory set
Fixes #376
2014-12-01 02:32:44 -05:00
Dan Stillman
43c03c6aca Update another version 2014-12-01 02:18:04 -05:00
Dan Stillman
d7d542a79c Update version, submodules, and repotime 2014-12-01 02:17:09 -05:00
Dan Stillman
67c63a2968 Remove child items from view when removing parent
https://forums.zotero.org/discussion/42218/
2014-11-28 16:37:40 -05:00
Dan Stillman
55068a0059 Use the whole firstCreator string in sortCreatorAsString mode
And in the default mode, use the whole string up through 'and' or 'et al.'
before falling back to full creator sorting, which could speed things up
slightly.
2014-11-26 20:12:07 -05:00
Aurimas Vinckevicius
bd87bd3f56 Normalize all user and translator input to NFC
This includes storing values into DB and performing searches. Note that export/display of existing data is not normalized. We can try to capture all access points to the database and normalize on output, but that seems like a lot of unnecessary normalization happening all the time. Would probably be best to just normalize existing data.
2014-11-23 13:55:01 -06:00
Aurimas Vinckevicius
ff28b24389 Don't use let inside translate.js. Breaks connectors 2014-11-20 08:42:27 -06:00
Dan Stillman
6e43942385 Fix UI issues with Cyrillic mime types, hopefully 2014-11-17 23:20:11 -05:00
Dan Stillman
828bcd9a11 Merge pull request #577 from fbennett/csl-once-on-drag
Instantate CSL processor once on drag, changing output mode on the fly
2014-11-13 17:15:55 -05:00
Dan Stillman
7ac1ba5242 Fix file sync error with Hola extension enabled
With Hola enabled, uploads were failing with NS_BASE_STREAM CLOSED -- it
seems to do something that causes the stream to be read more than once.
Adding REOPEN_ON_REWIND fixes this.
2014-11-12 20:09:39 -05:00
Simon Kornblith
9017aa69db Fix typo 2014-11-12 14:45:15 -05:00
Dan Stillman
cefab23888 Add tooltip to Zotero toolbar button 2014-11-10 18:06:17 -05:00
Frank Bennett
523724185c Instantate CSL processor once on drag, changing output mode on the fly 2014-11-09 06:46:37 +09:00
Dan Stillman
5bfc1e4199 Fix comment - force-delete on Win/Linux is Shift, not Ctrl 2014-10-28 13:45:55 -04:00
Aurimas Vinckevicius
3b4c502ca9 [RecognizePDF] Attempt to search by ISBN even if we found a DOI
(but only if DOI search failed)
2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
15722e5022 Allow calling Zotero.Translate.*.translate without setting translator first.
This simply means that detection code will be run first.
Attempting this with Export translators will fail, because trying to detect a translator does not make sense in this case.
2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
151e95075a Allow dependent styles to override parent style locale
Re https://forums.zotero.org/discussion/36595/defaultlocale-of-dependent-doesnt-override-that-of-its-parent/
2014-10-23 13:00:36 -05:00
Dan Stillman
a737f2c2aa Treat 260-character paths as too long on Windows
I understood the path limit to mean >260, but a user is seeing the error
with a 260-character path [1], so let's try this.

[1] https://forums.zotero.org/discussion/41410
2014-10-21 13:03:52 -04:00
Dan Stillman
226928f1e9 Debugging for "types[i] is undefined" error 2014-10-21 00:45:48 -04:00
Dan Stillman
6c814e2fa2 Update version 2014-10-14 22:55:07 -04:00
Simon Kornblith
4984e87ade Reinstate __exposedProps__
This is ignored in Firefox 33, but seemingly still necessary in
Firefox 32
2014-10-14 22:44:04 -04:00
Dan Stillman
12619273b5 Update submodules and repotime 2014-10-14 03:26:15 -04:00
Dan Stillman
aab3276276 Use old-style searchbox in Yosemite pre-Fx34
Yosemite introduces a new search textbox shape, but Firefox still uses
the old focus ring shape until 34, so we fake the old searchbox shape
for earlier versions.
2014-10-14 02:22:44 -04:00
Simon Kornblith
1f41253256 Update citeproc-js to 1.0.543 2014-10-13 23:25:24 -04:00
Dan Stillman
94060e113f Remove debugging for download overlay issue 2014-10-10 19:23:52 -04:00
Dan Stillman
39b01b80e0 Additional debugging for download overlay issue 2014-10-10 19:18:09 -04:00
Simon Kornblith
d3a69be997 Fix translation under Firefox 33
Our strategy: put arguments into a property of the function, and then
get them out unwrapped. This avoids security checks on arguments passed
to the function.
2014-10-10 18:31:10 -04:00
Dan Stillman
fc0f541ad8 Additional debugging for saving from download overlay 2014-10-10 18:03:13 -04:00
Dan Stillman
8359db1426 Better debugging for saving from download overlay 2014-10-10 17:36:49 -04:00
Dan Stillman
9c9b8b835d Fix crash when dragging items to collections from advanced search window
(Dragging to the items list is still disabled.)
2014-10-10 16:01:09 -04:00
Dan Stillman
e34c0db060 Make 'https' the default in WebDAV prefs drop-down 2014-10-08 13:49:41 -04:00
Dan Stillman
eba296a45f Closes #554, Sync settings pane should point to new TOS 2014-10-08 13:11:30 -04:00
Dan Stillman
497939bb28 Fix "Open Account Settings" button in quota dialog in Standalone
(Untested, but this should work.)
2014-10-08 13:04:56 -04:00
Dan Stillman
71bd1a7f99 Fix state check errors (middle-pane restart messages) during syncing
The state check errors were caused by 4812ab6f, which was a fix for
"Q.async(...)(...) is undefined" errors caused by ad8b81f4c, which was a
fix for "too much recursion" errors related to Task.spawn() on Windows
with JIT enabled.
2014-10-05 12:03:50 -04:00
Dan Stillman
72bb8acfd1 Fix previous commit 2014-10-03 16:06:01 -04:00
Dan Stillman
0f2e24dc5c Log state check errors (and other logError calls) to debug output 2014-10-03 16:05:14 -04:00
Dan Stillman
cb707a55c8 Fix breakage from 10ba5e31d 2014-09-20 16:34:36 -04:00
Dan Stillman
b0550273ae Update another version 2014-09-19 20:43:50 -04:00
Dan Stillman
f09871a1ee Convert additional for..in loops to for loops in getDisplayTitle() 2014-09-19 20:39:23 -04:00
Dan Stillman
10ba5e31d6 Fix error from letter items with more than 10 recipients
https://forums.zotero.org/discussion/40218/
2014-09-19 20:37:59 -04:00
Dan Stillman
ce6cba7974 Don't log stack trace for getString() failure unless unexpected 2014-09-19 15:52:53 -04:00
Dan Stillman
fd31e41e2f Add localization todos 2014-09-18 17:41:46 -04:00
Dan Stillman
57ec10dfd4 Remove unnecessary var 2014-09-18 17:35:25 -04:00
Dan Stillman
48955c8983 Check ext length explicitly in createShortened when checking path length 2014-09-18 17:34:10 -04:00
Dan Stillman
2a986c8635 Don't match extension in createShortened() for dot-files (.hidden) 2014-09-18 17:23:57 -04:00
Dan Stillman
5a8de7054c Ignore case when extracting extension in Zotero.File.createShortened() 2014-09-18 16:54:05 -04:00
Dan Stillman
f5b5617885 Improve long-filename handling during syncing
This will hopefully fix some remaining issues with long filenames during
syncing, particularly on Linux with encrypted filenames (which have a
filename length of 143).

(This may have reintroduced some edge case bugs, so it needs some
testing.)
2014-09-18 16:23:49 -04:00
Dan Stillman
4464e8ed9e Additional debugging for formatStringFromName error 2014-09-16 15:46:13 -04:00
Dan Stillman
61d7bd852b Debugging for strange Zotero.getString() error 2014-09-11 21:07:19 -04:00
Simon Kornblith
55f86f4295 Fix error handling for saveItems 2014-09-05 00:28:34 -04:00
Dan Stillman
9cd7423dd7 Change cert error message URL to https:// 2014-09-02 23:28:20 -04:00
Simon Kornblith
431185cc3a Merge pull request #531 from aurimasv/high-contrast
Use Mozilla's colors for itembox and tagbox background
2014-09-01 23:30:35 -04:00
Simon Kornblith
57da88ac3d Fix == use 2014-09-01 23:19:12 -04:00
Simon Kornblith
9146fb03d9 Merge pull request #536 from adam3smith/coinsfix
test for presence of author's firstName before using it
2014-09-01 23:18:39 -04:00
adam3smith
17c0f44e66 fix indenting 2014-09-01 19:25:10 -05:00
Simon Kornblith
9c3ec6f0be Fix DataCite under Fx 32 2014-09-01 20:00:31 -04:00
Simon Kornblith
79ed7e503e Fix MODS under Fx 32 2014-09-01 19:29:45 -04:00
Simon Kornblith
a09ff9c9ec Don't unwrap objects passed to chrome
Unwrapping objects also waives the Xray wrappers for contained objects,
which we need.
2014-09-01 18:42:24 -04:00
adam3smith
f973897d76 test for presence of author's firstName before using it 2014-09-01 14:31:51 -05:00
Simon Kornblith
5857368131 Update citeproc-js to 1.0.539 2014-09-01 15:04:52 -04:00
Dan Stillman
14a5643f38 Update submodules, repotime, versions 2014-09-01 14:56:01 -04:00
Simon Kornblith
ee35f7df41 Small fix to copyObject 2014-09-01 12:26:36 -04:00
Aurimas Vinckevicius
dc5ccffe43 Use Mozilla's colors for itembox and tagbox background
This way, the colors play nicely with Windows themes (e.g. high contrast)
Re https://forums.zotero.org/discussion/38870/make-zotero-fully-recognize-windowsff-high-contrast-themes/ and https://twitter.com/stuffilike2know/status/504167872567189504
2014-08-26 03:11:24 -05:00
Simon Kornblith
9219100901 Another Fx 32 translation fix 2014-07-23 18:05:56 -04:00
Aurimas Vinckevicius
638d29972c Don't ignore initial punctuation when sorting
Also, change sorting sensitivity to "base"
Closes #514
2014-07-23 00:18:48 -05:00
Dan Stillman
15108eea3f Fix intermittent source file deletion when dragging files in on Windows
(at least, if this is caused by what I think it was caused by)

https://forums.zotero.org/discussion/38486/
2014-07-20 15:56:55 -04:00
Dan Stillman
3b5bd45433 Further Windows drag-and-drop comment rewriting 2014-07-20 13:16:56 -04:00
Dan Stillman
717a440156 Clarify comment for Windows drag-and-drop mess 2014-07-20 02:50:00 -04:00
Dan Stillman
b8f69d6281 Fix Quick Copy drag to Chrome textareas on Windows
Possibly to other places as well (but not Notepad, which doesn't work
from Firefox or Chrome either)

Unfortunately this requires going back to 'copy' cursor feedback when
dragging, even when Shift is used. We can only choose one on Windows (as
far as I can tell), and we were previously using the unadorned 'move'.
2014-07-20 02:16:25 -04:00
Dan Stillman
7d74344b7d Restore highlighting of collection row during drag on Windows 2014-07-20 02:16:20 -04:00
Dan Stillman
813f55d024 Natural sorting of numbers ("1" < "2" < "10")
This needs testing to see if it has any other unwanted effects.

Closes Trac ticket 1031
2014-07-08 09:47:03 -04:00
Simon Kornblith
87a0df43d8 Fix some more Fx 32 issues
Ref https://forums.zotero.org/discussion/37885/
2014-07-06 14:07:00 -04:00
Simon Kornblith
d9720f18a9 Update to citeproc-js 1.0.536 2014-07-06 08:50:13 -04:00
Dan Stillman
532ebc5239 Fix for startup error w/weird locale language tags ("de-CH@currency=EUR")
https://forums.zotero.org/discussion/37901

And just return a noop sorter on failure instead of breaking
2014-06-27 09:36:11 -04:00
Dan Stillman
4a677240d3 Don't use Intl until Fx30, since it's missing in Iceweasel 29
And nsICollation isn't broken on OS X until 30
2014-06-27 01:12:25 -04:00
Dan Stillman
d66a6f6680 Ignore punctuation when sorting
This sorts "St. A" before "St B". I don't know if we want this.
2014-06-25 12:24:31 -04:00
Dan Stillman
979e62714c Fix startup errors in some non-English locales in Fx30 on OS X
nsICollation broke for some locales. (Testing requires changing the
language setting in Language & Region and then restarting the computer.
The change seems to not fully go into effect until then, even though the
UI changes.) This is fixed in Nightly, but we can work around it by
using the new Intl.Collator.
2014-06-25 12:22:04 -04:00
Florian Martin-Bariteau
dbe7640f18 Allow QuickSearch to search for civil law cases 2014-06-24 22:55:56 -04:00
Dan Stillman
be49010783 Use 11 instead of 6 on invalid note font size
Also don't validate font size until after pref field is blurred, to allow
numbers to be typed in properly
2014-06-23 23:36:36 -04:00
Simon Kornblith
bcc7a4ae86 Missing word in comment from 8cb081a4e1 2014-06-23 22:56:08 -04:00
Simon Kornblith
8cb081a4e1 Disable argument unwrapping on Fx < 32
This apparently breaks on Fx 24
2014-06-23 22:55:02 -04:00
Simon Kornblith
dd5160cc73 Partially revert 76e8ea835f
Apparently this doesn't work on Firefox 24. Sigh.
2014-06-23 22:29:32 -04:00
Dan Stillman
f45b219792 Fix inline collection editing when clicking to another collection
https://forums.zotero.org/discussion/37739
2014-06-21 13:37:55 -04:00
Simon Kornblith
41e50ef669 Fix check from fc91deb69e 2014-06-21 13:27:49 -04:00
Simon Kornblith
fc91deb69e Fix more Firefox 32 issues 2014-06-21 13:25:33 -04:00
Simon Kornblith
76e8ea835f Slightly cleaner fix for #504 2014-06-21 13:16:39 -04:00
Simon Kornblith
a71f3bbdd8 Fix #504
Determine whether to copy objects by their constructor names, since the
prototypes do not necessarily match
2014-06-21 12:51:41 -04:00
Dan Stillman
4812ab6f93 Fixes (cosmetic) "Q.async(...)(...) is undefined" sync error
Yield immediately so that a generator is always passed to Q.async()
2014-06-20 03:47:04 -04:00
Dan Stillman
09e53d85d5 Revert "Revert "Use Q instead of Task.spawn to run processUpdatedXML()""
This reverts commit 4334260865.
2014-06-20 03:47:01 -04:00
Dan Stillman
4334260865 Revert "Use Q instead of Task.spawn to run processUpdatedXML()"
Fixes "Q.async(...)(...) is undefined" sync error

This reverts commit ad8b81f4c7 (which
tried to fix Fx32+ compatibility).
2014-06-20 03:17:03 -04:00
Simon Kornblith
3a8c77e983 Fix search translation bug from 7950d3a7e2 2014-06-19 21:31:17 -04:00
Simon Kornblith
37f4e61ef2 Remove debug line 2014-06-19 20:11:46 -04:00
Simon Kornblith
7950d3a7e2 Attempt to fix #502, translation broken on Firefox 32 2014-06-19 20:07:31 -04:00
Simon Kornblith
f6dfeee210 Remove more uses of charsetDTD 2014-06-19 19:03:58 -04:00