Commit graph

13689 commits

Author SHA1 Message Date
Abe Jellinek
1d662b9fef Preferences: Fix and improve search 2024-01-24 23:32:18 -05:00
Abe Jellinek
6e651271e8 Use two decimal points in default fontSize pref 2024-01-24 23:32:18 -05:00
Abe Jellinek
fbbe9625fc Focus new tag when popup is opened 2024-01-24 23:32:18 -05:00
Abe Jellinek
6948252e32 Prevent collapsing / hide twisty in tags popup 2024-01-24 23:32:18 -05:00
Abe Jellinek
8e3abd8706 Add padding to reader tags popup
And move styles to SCSS.
2024-01-24 23:32:18 -05:00
Abe Jellinek
482e436203 Import SCSS in reader windows
Fixes unstyled tags popup.
2024-01-24 23:32:18 -05:00
Abe Jellinek
b24d7d8f44 Fix tags box tests 2024-01-24 23:32:18 -05:00
Abe Jellinek
b391b6ca21 Tags box: Fix tag being saved every time autocomplete popup hides 2024-01-24 23:32:18 -05:00
Dan Stillman
f2bf40a314 Don't default existing users to Compact 2024-01-24 23:32:18 -05:00
Abe Jellinek
fbd8db3c8e Fix New Collection test 2024-01-24 23:32:17 -05:00
Abe Jellinek
99b0411857 Return created collection from newCollection()
Regression from fd0664bfb06409118ecaff73e064ab9c3103d823
2024-01-24 23:32:17 -05:00
Abe Jellinek
301058cf9d Fix notes pane tests 2024-01-24 23:32:17 -05:00
Abe Jellinek
57a1214eaa Remove reader pointerdown listener on close
Avoids a memory leak.
2024-01-24 23:32:17 -05:00
Abe Jellinek
2624770cea Remove debug from collapsible-section 2024-01-24 23:32:17 -05:00
Abe Jellinek
49fe2b98d9 Restore tag autocomplete popup
Regression from 275ea6f because of a duplicate element ID. Now we only create
one popup, even if there are multiple tags-boxes.
2024-01-24 23:32:17 -05:00
Abe Jellinek
ac2a4d0ee3 Preferences: Don't show horizontal scrollbar 2024-01-24 23:32:17 -05:00
windingwind
e1f026b037 Fix attachment row gap 2024-01-24 23:32:17 -05:00
windingwind
b2ce3d4a5c Fix sidenav button default status 2024-01-24 23:32:17 -05:00
windingwind
365e97ba1e Fix quick search does not re-run when changing mode 2024-01-24 23:32:17 -05:00
Dan Stillman
3e489b5f00 Update reader submodule 2024-01-24 23:32:17 -05:00
Dan Stillman
0c089efd8a More attachment box fixes
- Only try to show preview or check file existence for file attachments
- Use fileExists() for file check
- Show Accessed for linked-URL attachments
2024-01-24 23:32:17 -05:00
windingwind
61a5704dd4 Fix attachment box bugs 2024-01-24 23:32:17 -05:00
Dan Stillman
b34d0d2acc Fix regression in Zotero.FullText.canReindex() 2024-01-24 23:32:16 -05:00
Dan Stillman
3b9afcc500 Add Zotero.FullText.canIndex()
Currently identical to canReindex(), but in theory attachments aren't
supposed to be reindexable if they're already fully indexed
2024-01-24 23:32:16 -05:00
Bogdan Abaev
3338b4b285 new item focus handling tweaks
- properly re-focus previously focused item type menu in itemBox
- fix strange behavior of re-emerging item type menu popup caused by
itemBox.focusFirstField
- force the focus-ring to be around the itemType menu
2024-01-24 23:32:16 -05:00
Bogdan Abaev
b6d5a52417 additional focus management for popups
When a menupopup is opened, the active element does not change, so
their focus-ring will be hidden until the menupopup closes for it to be
less distracting.

When a panel popup is opened, the focus will be moved inside
of the panel, so we keep track of whichever element was previously
focused, and re-focus it when the panel goes away.

Minor reorganization of focus-ring mixin to use variables instead
of parameters to make hiding of focus-ring easier.
2024-01-24 23:32:16 -05:00
Dan Stillman
1427e3e324 Open item pane if closed on New Item 2024-01-24 23:32:16 -05:00
Bogdan Abaev
8e4fd75f1d passing newItem tests 2024-01-24 23:32:16 -05:00
windingwind
3073137d39 Fix title bar height on Linux 2024-01-24 23:32:16 -05:00
Bogdan Abaev
99ab42a674 Prevent trash row from receiving focus on Enter in filter box
Prevent trash/duplicated/unfiled/etc. rows from getting focused on Enter
if it is the currently selected collection row that technically
passes the filter and Enter is pressed.
2024-01-24 23:32:16 -05:00
Bogdan Abaev
2c97a7a03e avoid blinking of focused collection row on escape
Make sure that on escape, the focus is moved to collectionTree strictly
once all filtered rows are rendered. Minor refactoring to achieve
it, since setFilter is async.
2024-01-24 23:32:16 -05:00
Bogdan Abaev
0f0badea27 restore collection scroll position after filter
Before filtering starts, save the selected row, scroll position, and
which rows were collapsed before filering, and restore them once the
filtering is over if a row was focused during filtering.
2024-01-24 23:32:16 -05:00
Dan Stillman
6cb50c3ca4 First item row should not be gray 2024-01-24 23:32:16 -05:00
Dan Stillman
e6dc493b27 Update note-editor and reader submodules 2024-01-24 23:32:15 -05:00
yexingsha
c5346d08b9 fixed some spacing in item pane 2024-01-24 23:32:15 -05:00
yexingsha
6e7c80d97b changed all font-weight: bold/590 to 600 2024-01-24 23:32:15 -05:00
yexingsha
a81f0884ed fix focus ring color 2024-01-24 23:32:15 -05:00
Abe Jellinek
ee5106939c Potentially fix Linux popup positioning issue 2024-01-24 23:32:15 -05:00
windingwind
f039124312 Use html label in info table 2024-01-24 23:32:15 -05:00
windingwind
d00fc7ca22 Fix attachment box info table layout 2024-01-24 23:32:15 -05:00
windingwind
3603254d35 Fix attachment row rendering bug with web attachment 2024-01-24 23:32:15 -05:00
windingwind
607f9814a0 Fix uncaught errors on item.save() coming from attachmentBox 2024-01-24 23:32:15 -05:00
Dan Stillman
034dd40eea Update note-editor submodule 2024-01-24 23:32:15 -05:00
windingwind
6af4605bd0 Implement attachment preview
- Implement attachment preview
- Implement attachment-box redesign
- Make filename editable
- Use new reindex icon
- Update attachment note layout
- Fix reader.js eslint errors
- Add fallback attachment icon and use redesign
- Use attachment preview for regular items
- Fix pinned pane not exists error
- Double click preview to open to page
- Fix itemPane pin bug
- Preload preview iframe
- Fix item pane scroll
- Add media preview support
- Fix item pane scroll bar on macos
- Fix reader sidebar with standalone attachment
- Fix attributeChangedCallback
- Add attachmentBox _updateAttachmentIDs
- Make attachment notes readonly and simplify note window script
- Implement convert attachment note to new note
- Support preview dragging
- Annotations box redesign
- Support custom buttons in the collapsible-section
- Add preview toggle button
- Fix collapsible section attribute listener
- Make attachment box notify sync to fix errors in test
2024-01-24 23:32:15 -05:00
windingwind
2a5d713f98 Move drag handler into utilities_internal 2024-01-24 23:32:14 -05:00
Abe Jellinek
9a0a15abbe Don't show string "PLACEHOLDER" in menu while localization runs
Ideally we should cache these/not recreate the menuitems every time, or
something like that, so that localization pop-in doesn't happen at all. But a
brief flash of an empty menuitem is better than a brief flash of placeholder
text.
2024-01-24 23:32:14 -05:00
Abe Jellinek
f44cc548f9 Locate menu: Get selected item(s) from current tab 2024-01-24 23:32:14 -05:00
windingwind
424afb9af6 Fix splitter style 2024-01-24 23:32:14 -05:00
yexingsha
13acfe8c05 fixed spacing in tag-selector-filter 2024-01-24 23:32:14 -05:00
yexingsha
cf241447ab fixed some spacing in collectionTree and itemTree 2024-01-24 23:32:14 -05:00