Commit graph

10834 commits

Author SHA1 Message Date
Bogdan Abaev
e69ce9b86c avoid ztabindex overlap when new creator is added
Increated the ztabindex offset for non-creator rows, so that when a new
creator is added but not saved yet, there is no two elements with
the same ztabindex which would break tab-based navigation

Fixes: #3666
2024-02-06 12:44:29 -05:00
Bogdan Abaev
15d5dcaaee itemBox creator names fixes
- Instead of setting default name as the value of the field when a
creator name is empty, set the default names as a placeholder so that
it shows up only when the field is empty.
- Have the creator options show up before the creator is saved so that
the mode can be switches before saving the creator.
- Re-do of capitalizeCreatorName to not break when one of the names is focused.

Fixes: #3610
2024-02-06 12:44:29 -05:00
abaevbog
3a2cd70684
update tab when collection row is updated (#3673)
When saved search, collection or feed is renamed, update the zotero-pane
tab so that it has the new title.

Fixes: #3664
2024-02-06 02:23:09 -05:00
Abe Jellinek
de89e82e75 Make Tags/Related sections functional in note windows
Fixes #3581
2024-02-05 17:11:42 -05:00
Dan Stillman
f29f87ad5b Fix missing "Edit Saved Search" label
Regression from f8108aca45

https://forums.zotero.org/discussion/111486/zotero-7-beta-edit-saved-search-from-right-click-on-a-saved-search-collection
2024-02-04 06:22:50 -05:00
Abe Jellinek
6486c509ad Fix customElements.js error when editing saved search
Fixes #3672
2024-02-02 15:32:55 -05:00
windingwind
3acef799f5
Fix custom elements import (#3639)
Fixes #3600
2024-02-02 04:02:08 -05:00
abaevbog
a74c86d948
collection search tooltiptext and placeholder cleanup (#3632)
Fluent tooltiptext for collection search button and placeholder
for collection search input
2024-02-02 03:58:27 -05:00
abaevbog
4a3a80b4f8
editable-text min/max-lines attributes (#3649)
- min/max-lines attribute on editable-text determines how tall the field
can/has to be
- if max-lines is not specified (or is below 1), the textarea will expand
as much as needed without overflow
- removed hardcoded height and variables from css, substituted them with
usage of these attributes for consistency
- No fields have any max-lines at this point, so all fields will expand as
needed
2024-02-02 03:53:23 -05:00
Abe Jellinek
c10dabcbba Ignore editable-text blurs caused by window becoming inactive
Fixes #3588
2024-02-02 03:39:55 -05:00
Abe Jellinek
6b1940cebb Add generic menu for all unfocused editable-texts 2024-02-02 03:39:55 -05:00
Abe Jellinek
af79e9c405 Ignore base-mapped fields more robustly 2024-02-02 03:39:55 -05:00
Abe Jellinek
b8c1b7c139 Fix DOI View Online/Copy as URL regression
Was opening/copying the bare DOI, not the URL.
2024-02-02 03:39:55 -05:00
Abe Jellinek
fa6e6f9458 Make existing edit context menus more context-aware
- Don't show the default text editing context menu when right-clicking
  an unfocused editable-text
- In item box/header context menus, only show Copy and Paste (plus
  field-specific transform options) when unfocused

Fixes #3619
2024-02-02 03:39:35 -05:00
abaevbog
9823b1199a
no extra arrows from scrollable components on win (#3634)
Somehow `scrollbar-width: thin` removes unnecessary arrows from
editable-text textarea and itemPane on windows

Addresses: #3633
2024-02-02 03:05:59 -05:00
Tom Najdek
41ccbc90a0
Fix missing variable value in import wizard localization. Fix #3471 2024-02-01 15:41:23 +01:00
Tom Najdek
6efbf4c2ec
Fix tab content misaligned in RTL mode. Fix #3658 2024-02-01 15:41:23 +01:00
abaevbog
8bcf1d446a
url/doi/options icon does not occupy space unless hovered (#3631)
url/doi/options do not occupy space unless the row is focused or hovered.
This does not apply to options icons after multiline fields because
it would shrink textarea on hover and shift text in an awkward way.

Fixes: #3612
2024-02-01 04:27:32 -05:00
Martynas Bagdonas
8a9df4a1b3 Move context pane toggle into reader toolbar
Related #3648
2024-02-01 14:49:59 +08:00
Dan Stillman
ebd3d7a988 Fix wrong tab being selected after Reopen Closed Tab
Fixes #3651
2024-02-01 00:55:02 -05:00
Tom Najdek
493c3add8a
Fix a memory leak in file renaming preferences pane (#3654) 2024-02-01 00:44:22 -05:00
Dan Stillman
f8108aca45 Move "Rename Collection" and "Edit Saved Search" to Fluent
Without ellipses

And remove unused "Edit Feed…", which is in zotero.dtd too
2024-02-01 00:42:14 -05:00
Abe Jellinek
a4c09ed701 Trigger inline editing from Rename Collection... 2024-02-01 00:42:14 -05:00
Abe Jellinek
ab5def98a7 Move item type menu CSS override to SCSS 2024-01-31 14:48:59 -05:00
Abe Jellinek
0e251b4975 Scaffold: Fix tests losing defer: true on update 2024-01-31 14:30:34 -05:00
Abe Jellinek
7944253bed Scaffold: Update HiddenBrowser to use object-oriented API
Fixes updating tests.
2024-01-31 14:27:21 -05:00
Abe Jellinek
3f348e3340 Use actual placeholder attribute for editable-texts
As far as I can tell, the Abstract field was the only editable-text
using a placeholder set by Fluent.

https://github.com/zotero/zotero/pull/3632#issuecomment-1919619813
2024-01-31 13:06:57 -05:00
Abe Jellinek
a4c75df182 Don't allow pinning Item Notes and All Notes
Fixes #3626
2024-01-31 12:52:56 -05:00
Abe Jellinek
a23b5310e6 Fix nonfunctional Advanced Search menu item in dialogs 2024-01-30 11:43:56 -05:00
windingwind
1375de4ba2
Fix quick format background (#3638) 2024-01-30 01:58:50 -05:00
Martynas Bagdonas
a12c032ab9 Fix not updating reader "Add to Note" button regression 2024-01-30 09:30:28 +08:00
Martynas Bagdonas
9edfcba9a9 Hide item notes list section in context pane for parentless attachments 2024-01-29 16:06:52 +08:00
abaevbog
e68b9b80ad
opened tabs menu visibility improvements (#3620)
- Added tooltip to display the entire title of the tab on hover
- Ellipsize the text of the tab title to display as much of the last
word as possible

Fixes: #3609
2024-01-29 02:40:09 -05:00
Tom Najdek
41294e0ff7
Fix a bug where first column is clipped if it has fixed or static width (#3605)
Also:

* Fix issues with notes and attachment columns
* Tweak first-column attachment column alignment
2024-01-29 02:37:46 -05:00
Dan Stillman
418ec5cfc0 Move "Print" to zotero.ftl
Follow-up to d606644a78
2024-01-29 02:31:55 -05:00
Martynas Bagdonas
630eccf72f Fix context pane note back button regression
Fixes #3616
2024-01-29 15:18:37 +08:00
Martynas Bagdonas
3a3a81b0ed Add missing "Use Dark Mode for Content" to reader window menu
Fixes #3592
2024-01-29 15:18:37 +08:00
Martynas Bagdonas
d606644a78 Localize "Print" and "Save As" in reader tab/window File menu 2024-01-29 15:18:37 +08:00
Martynas Bagdonas
5eb0ed109b Fix broken Fluent localization in reader window menu 2024-01-29 15:18:37 +08:00
Dan Stillman
0045cd1b7a Fix search bar in classic citation dialog and Related Items dialog
Fixes #3599
2024-01-29 02:13:05 -05:00
Adomas Venčkauskas
452ee3a55b Fix citation dialog open documents not working when a standalone pdf is open
Closes #3621
2024-01-29 09:11:12 +02:00
Dan Stillman
8275970df9 Use newer red in Z SVG 2024-01-28 01:58:33 -05:00
Abe Jellinek
7f993167b4 Fix regression that broke Date field tooltip
Field inputs are XUL in Z6, HTML in pre-redesign Z7, and XUL again in
post-redesign Z7. We switched to the title attribute for HTML but didn't
switch back to tooltipText when going back to XUL.
2024-01-26 13:40:16 -05:00
Abe Jellinek
00ca99ae86 Item box: Fix Short Title rendering as multiline
Also, rerender editable-text when noWrap changes.
2024-01-26 13:38:29 -05:00
Dan Stillman
1cc5c1ce2e Disable automatic safe mode for now
Until we can figure out why some shutdowns are counting as crashes

https://github.com/zotero/zotero/issues/3196
2024-01-26 07:35:09 -05:00
windingwind
c21c5632c2
Fix attachment row annotation button bug (#3577) 2024-01-26 00:51:27 -05:00
Dan Stillman
9151fb3558 Force white background in quick-format dialog for now
To avoid unpleasantness in dark mode
2024-01-25 00:20:50 -05:00
Dan Stillman
f7fe38b94b Prevent overriding of quick-format selection background color for now 2024-01-25 00:08:35 -05:00
windingwind
63c532398b Fix sidenav default buttons display bug 2024-01-24 23:32:24 -05:00
windingwind
665f812bd1 Fix sidenav button visibilities update bugs 2024-01-24 23:32:24 -05:00