Commit graph

116 commits

Author SHA1 Message Date
abaevbog
c14896a640
vpat 44: scaffold keyboard tab selection focus (#4069)
Do not move focus from the tab onto the editor/input
during keyboard navigation to not change context per
https://www.w3.org/WAI/WCAG21/Understanding/on-input.

Focus will still shift if tab selection changed on mouse click.

Also:

- added focus ring to tabs. Additional mouseup handling
to prevent the focus ring from briefly appearing on click.
- on Escape from within the editor, focus the current
tab.
- on shift-tab from the beginning of the editor,
tab out of the editor to previous element.
2024-10-10 17:08:32 -04:00
Abe Jellinek
237a2e5b86 Scaffold: Fix test statuses not persisting 2024-10-09 14:15:34 -04:00
Abe Jellinek
f22f87537c Scaffold: Get PATH from login shell for ESLint on macOS
And:
- Use eslint instead of teslint
- Remove debug logging, since we're running this constantly now
- Kill ESLint at the end, although it should exit on its own
2024-10-09 13:43:01 -04:00
Abe Jellinek
528ee8adac Scaffold: Fix evaluation of translator ending in single-line comment 2024-10-09 10:17:42 -04:00
Abe Jellinek
40dd345280
Scaffold: Run ESLint continuously, not just after save (#4738)
Includes API changes in Zotero.Translators in order to support
in-memory translator serialization.

Type changes in docstrings are corrections, not actual changes.
2024-10-09 01:46:10 -04:00
Abe Jellinek
54cee37703 Scaffold: Cleanup 2024-10-08 15:26:02 -04:00
Abe Jellinek
1caeb1ef08 Scaffold: Fix richlistbox misalignment 2024-10-08 14:53:30 -04:00
Abe Jellinek
9d9d98b907 Scaffold: Fix silent do* failure when code has syntax error
Apparently _error() does get called!

detect* methods were already logging syntax errors as expected.
TranslationChild handles errors in detect* and do* identically. Odd.
2024-10-08 14:43:58 -04:00
abaevbog
d462330347
vpat 8: make window buttons not focusable (#4070)
Minimize, maximize, close, etc. window buttons are generally
not accessible for focus. They can get focused on mac with
voiceover enabled which can be confusing.

Added aria-hidden attribute to prevent voiceover from
placing the cursor on them.
2024-10-04 00:02:16 -04:00
Bogdan Abaev
8de5eb360d vpat 43: add label to scaffold translator output (#4018)
In a new scaffold.ftl file.

Vpat 43 also indicates that the read-only state of the text field
does not get announced - it is a VoiceOver-specific issue on
Firefox, so it is not addressed here as it should be fixed
globally.
2024-09-03 07:35:24 -04:00
windingwind
69b4789c17
Unify richlistitem styling rules (#4511)
Unify richlistitem styling rules

- Fix richlistitem unwanted focus ring on Linux
fix: #4510
- Simplify richlistbox styling rules and do not follow Mozilla code
- Use --default-focusring-width for v-table
2024-08-09 15:57:56 +03:00
windingwind
e4f75c36e1
Fix scaffold window UI (#4339)
fix: #4258
2024-07-09 04:02:52 -04:00
Abe Jellinek
1bf0fd7d57 Scaffold: Manage blank lines before test cases automatically 2024-05-15 12:42:00 -04:00
abaevbog
1e990f3ca0
vpat 42: link url label to input in scaffold (#4017) 2024-05-15 06:58:52 -04:00
Abe Jellinek
634e27c621 Scaffold: Don't use cookie sandbox by default
Instead, just set an empty cookie sandbox when running tests without
"Remember cookies" enabled. The cookie sandbox doesn't remember cookies
set in JS, which breaks some sites in the Scaffold browser.

https://forums.zotero.org/discussion/114239/z7-beta77-scaffold-bugs-report
2024-05-07 15:11:03 -04:00
Abe Jellinek
19ab6b6643 Scaffold: Fix duplicate text in test status label 2024-05-07 14:30:56 -04:00
Abe Jellinek
387210e139 Scaffold: Fix Open URL 2024-05-07 14:28:50 -04:00
Abe Jellinek
655575eb77 Monaco / Scaffold: Use LF line endings on all platforms
https://forums.zotero.org/discussion/114239/z7-beta77-scaffold-bugs-report
2024-05-07 12:10:57 -04:00
Abe Jellinek
d815476a14 fx115: Scaffold: Fix Tests listbox sizing
- Remove splitter for now - no longer works with flex, so we'll need to
  rethink it
- Borrow selectItemsDialog richlistbox sizing fix via mixin
2024-04-22 15:02:30 -04:00
Abe Jellinek
fde33e7100 fx115: Scaffold: Center Open window (ex-sheet) 2024-04-22 15:02:30 -04:00
Abe Jellinek
5d760c9304 fx115: Scaffold: Fix window sizing 2024-04-22 15:02:30 -04:00
windingwind
3e30ae1797
Fix dialog window titlebar on macOS (#4011)
After #4010
2024-04-19 07:32:50 -04:00
Abe Jellinek
c031e1fbbd Scaffold: Disable sticky headers in Tests editor 2024-04-12 13:21:17 -07:00
Abe Jellinek
b029e561f3 fx115: Scaffold: Restore flex ratio in Tests tab 2024-04-12 13:18:52 -07:00
Abe Jellinek
6ebb15778b
fx115: Fix Scaffold richlistboxes and load dialog sizing (#3968) 2024-04-11 22:53:59 -04:00
Abe Jellinek
4e912b84c0 fx-compat: Copy over fx115 Window menu changes (#3899) 2024-03-30 01:02:09 -04:00
Abe Jellinek
1b646fb6e2 fx-compat: Fix up Scaffold a bit
- Output pane no longer gets huge after load
- URL box grows
- Metadata grid fills available space (but still needs work re overflow)
- row-resize cursor on Tests splitter
2024-03-30 01:02:09 -04:00
windingwind
e51739e1d4 fx115: fix layout on Windows 2024-03-30 00:58:58 -04:00
windingwind
41acf4c737 Implement ItemPane custom section API
Unify properties as getter in ContextPane
Replace section `mode` with `editable`
Remove section `inTrash`
2024-03-30 00:58:57 -04:00
Dan Stillman
920461cd9d fx115: Update lots of OS.File/OS.Path uses 2024-03-30 00:58:54 -04:00
Dan Stillman
f472ee6a4c fx115: Remove global.dtd includes and chromedir attribute
It only had `locale.dir`, which it looks like we can handle in different
ways now:

- CSS rules with `:-moz-locale-dir(ltr)`
- `let isLTR = document.documentElement.matches(":-moz-locale-dir(ltr)");`
2024-03-30 00:58:53 -04:00
Dan Stillman
e76c6c6a1a fx115: Update loadURI() calls to take nsIURI and remove loadURIWithFlags
https://bugzilla.mozilla.org/show_bug.cgi?id=1810141
https://bugzilla.mozilla.org/show_bug.cgi?id=1444760
2024-03-30 00:58:53 -04:00
Dan Stillman
c36f40735c fx115: Change FilePicker to Mozilla ESM style
var { FilePicker } = ChromeUtils.importESModule('chrome://zotero/content/modules/filePicker.mjs');
2024-03-30 00:58:53 -04:00
Dan Stillman
2051f08b4c fx115: Move Zotero object initialization to zotero.mjs 2024-03-30 00:58:53 -04:00
Abe Jellinek
4f0e9bb9bb Scaffold: Enable syntax highlighting/formatting in Test Input 2024-03-26 16:36:05 -04:00
Abe Jellinek
a7044db15e Scaffold: Remember cookies set in browser by default
Making this configurable - it's worth testing translators to make sure
that they *aren't* dependent on some specific cookie configuration,
apart from obvious cases like login-gated sites.
2024-03-26 14:22:08 -04:00
Abe Jellinek
bef7ecd409 Scaffold: Print attachment URLs
Useful for debugging. This doesn't apply to tests.
2024-03-22 12:44:30 -04:00
Abe Jellinek
ff96de8723 Scaffold: Remove id field from returned items
Generates confusing diff output and isn't necessary.
2024-03-22 11:41:14 -04:00
Abe Jellinek
cee1e3a596 Scaffold: Update copyright year automatically 2024-03-18 12:20:22 -04:00
Sebastian Karcher
6d02076a1c
Scaffold: Fix MARC template, update copyright (#3856) 2024-03-18 12:17:48 -04:00
Abe Jellinek
5489b6cc4b
Scaffold: Show current Git branch in title (#3834) 2024-03-12 01:33:03 -04:00
windingwind
23da0d70b0
Implement Windows redesign for native elements (#3727) 2024-03-02 02:51:55 -05:00
Abe Jellinek
0e251b4975 Scaffold: Fix tests losing defer: true on update 2024-01-31 14:30:34 -05:00
Abe Jellinek
7944253bed Scaffold: Update HiddenBrowser to use object-oriented API
Fixes updating tests.
2024-01-31 14:27:21 -05:00
Abe Jellinek
2963b86176 Bidi: Allow switching text direction & add control for bidi pref 2024-01-24 23:32:14 -05:00
windingwind
a3dec4be45 Fix Scaffold for redesign 2024-01-24 23:31:51 -05:00
Abe Jellinek
ba0475810c Scaffold: Implement new toolbar
New icons and new scaffold.scss go into chrome://zotero/skin. The separate root
for Scaffold is mostly a historical relic, and adding special cases to build
scripts, SCSS mixins, and so on would just make things complicated.
2024-01-24 04:03:36 -05:00
Abe Jellinek
e04ef87929 Scaffold: Initial redesign changes
- Space between Min. Version and Priority
- Fix white-on-white tabs
2024-01-24 04:03:35 -05:00
Abe Jellinek
1dd3812e00 Deprecate setFontSize(), replace with new Zotero.UIProperties
This new XPCOM module handles font size and UI density and automatically keeps
registered roots up to date when prefs change. Roots receive a
UIPropertiesChanged event after their properties are updated.
2024-01-24 03:39:09 -05:00
Abe Jellinek
a37dd2462a Disable error reporting in Scaffold 2024-01-23 12:06:40 -05:00